Re: Useless test

2007-09-28 Thread Denys Vlasenko
On Friday 28 September 2007 03:49, Loïc Grenié wrote: > The if () test is useless because it has already been done above. if (flags & (PSSCAN_CMD|PSSCAN_ARGV0)) { if (sp->argv0) { free(sp->argv0);

Useless test

2007-09-27 Thread Loïc Grenié
The if () test is useless because it has already been done above. Loïc Index: libbb/procps.c === --- libbb/procps.c (revision 20067) +++ libbb/procps.c (working copy) @@ -388,8 +388,7 @@ n = read_to_buf(filename, buf