httpd with auth

2007-09-25 Thread Kim B. Heino
Hello, Attached patch fixes httpd's authentication config parser in BusyBox 1.7.1. With gcc/glibc the original code is the same as sprintf(p0,:%s,c);. --- f/networking/httpd.c 2007-09-25 10:01:28.0 +0300 +++ busybox-1.7.1/networking/httpd.c 2007-09-25 10:00:25.0 +0300 @@ -598,7

Re: httpd with auth

2007-09-25 Thread Natanael Copa
On Tue, 2007-09-25 at 10:07 +0300, Kim B. Heino wrote: Hello, Attached patch fixes httpd's authentication config parser in BusyBox 1.7.1. With gcc/glibc the original code is the same as sprintf(p0,:%s,c);. candidate for fixes-1.7.1? Without studying the entire source, it looks like its

Re: httpd with auth

2007-09-25 Thread Denys Vlasenko
On Tuesday 25 September 2007 08:07, Kim B. Heino wrote: Hello, Attached patch fixes httpd's authentication config parser in BusyBox 1.7.1. With gcc/glibc the original code is the same as sprintf(p0,:%s,c);. Both your patches are applied, thanks. -- vda

Re: httpd with auth

2007-09-25 Thread Kim B. Heino
candidate for fixes-1.7.1? Yes, I think so. Without studying the entire source, it looks like its not checking the length of the string. That's fine, as it's xmalloc'ed correctly in the beginning of if-block. If I read the bit cryptic path simplifier correctly, the original source: *p =