Re: [PATCH] ash: avoid GLIBC'ism %m

Hi Markus, On Wed, 19 Jul 2017, Markus Gothe wrote: > However it should be noted that this [scanf's %m format] seems not to be > the same as glibc %m: "To use the dynamic allocation conversion > specifier in C99 and C11, specify m as a length modifier as per > POSIX.1-2008. That is, use %ms or

[PATCH] ash: remove no-longer-used variable

As of 035486c75 (ash: significant overhaul of redirect saving logic, 2017-07-31), the sv_pos variable is no longer used (just assigned to, with no further effect). Let's just remove it. Signed-off-by: Johannes Schindelin --- Published-As:

[PATCH] ash: support BASH_XTRACEFD when built Bash compatibly

There is a very useful feature in Bash where you can redirect the trace enabled by `set -x` to a file descriptor *different* than 2. This comes in particularly handy when validating the error output of commands, say, in Git's test suite, while tracing at the same time. It is such a useful

Re: [PATCH] unzip: fix regression on big-endian machines

On Thu, 27 Jul 2017 15:39:35 +0200 Denys Vlasenko wrote: > Applied, thanks! This should go to 1_27_stable too. Thanks! > > On Tue, Jul 25, 2017 at 8:44 PM, Natanael Copa wrote: > > This fixes a regression which was introduced with commit

Re: [PATCH] miscutils/microcom: Fixed segfault

On Fri, 4 Aug 2017 02:02:36 +0200 Denys Vlasenko wrote: > On Thu, Aug 3, 2017 at 7:11 AM, Marian Buschsieweke > wrote: > > microcom did not check if required parameter TTY is present. Thus, > > bb_basename() was called with a NULL pointer

Re: [PATCH] miscutils/microcom: Fixed segfault

It's hardly a critical error :) On Fri, Aug 4, 2017 at 10:25 AM, Natanael Copa wrote: > On Fri, 4 Aug 2017 02:02:36 +0200 > Denys Vlasenko wrote: > >> On Thu, Aug 3, 2017 at 7:11 AM, Marian Buschsieweke >> wrote: >>

Re: [PATCH] ash: remove no-longer-used variable

applied, thanks! On Fri, Aug 4, 2017 at 12:16 PM, Johannes Schindelin wrote: > As of 035486c75 (ash: significant overhaul of redirect saving logic, > 2017-07-31), the sv_pos variable is no longer used (just assigned to, > with no further effect). > > Let's just remove

Re: [PATCH] unzip: fix regression on big-endian machines

okay On Fri, Aug 4, 2017 at 10:27 AM, Natanael Copa wrote: > On Thu, 27 Jul 2017 15:39:35 +0200 > Denys Vlasenko wrote: > >> Applied, thanks! > > This should go to 1_27_stable too. > > Thanks! > >> >> On Tue, Jul 25, 2017 at 8:44 PM, Natanael

Re: [PATCH] ash: support BASH_XTRACEFD when built Bash compatibly

Applied in this form: preverrout_fd = 2; + if (BASH_XTRACEFD && xflag) { + /* NB: bash closes fd == $BASH_XTRACEFD when it is changed. +* we do not emulate this. We only use its value. +*/ + const char *xtracefd =