Re: Busybox Sendmail segfaults with multiple inline recipients

2017-08-22 Thread Denys Vlasenko
Fixed in git, thanks On Sat, Aug 19, 2017 at 1:08 AM, mark wrote: > Hello, > > I came across a bug in the sendmail function of busybox when using the > "-t" option and including multiple recipients in any of the inline mail > headers (To, Cc, or Bcc). > > When

[PATCH 2/2] ash: when cd fails, say why

2017-08-22 Thread Johannes Schindelin
Signed-off-by: Johannes Schindelin --- shell/ash.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/shell/ash.c b/shell/ash.c index a67a45376..60bcd1b0a 100644 --- a/shell/ash.c +++ b/shell/ash.c @@ -2748,7 +2748,7 @@ cdcmd(int argc UNUSED_PARAM,

Re: Busybox in Debian

2017-08-22 Thread Ben Hutchings
On Tue, 2017-08-22 at 10:38 +0200, Denys Vlasenko wrote: > On Mon, Aug 21, 2017 at 8:38 PM, Ben Hutchings > wrote: > > On Mon, 2017-08-21 at 19:40 +0200, Denys Vlasenko wrote: > > > > On Mon, Aug 14, 2017 at 5:12 PM, Ben Hutchings > > > g.uk> wrote: > > >

[PATCH] tar: fix handling of first argument without '-'

2017-08-22 Thread Ron Yorston
The following no longer works as expected: $ ./busybox tar xfz test.tgz tar: can't open 'z': No such file or directory Signed-off-by: Ron Yorston --- archival/tar.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/archival/tar.c b/archival/tar.c

sed: missing support for empty regular expressions

2017-08-22 Thread Leah Neukirchen
Hi, it seems busybox sed (v1.27.2) does not support empty regular expressions as by POSIX, but instead matches the empty string: >> If an RE is empty (that is, no pattern is specified) sed shall >> behave as if the last RE used in the last command applied (either >> as an address or as part of a

[PATCH 0/2] Use the new ash_msg_and_raise_perror() in more places

2017-08-22 Thread Johannes Schindelin
This is by no means an exhaustive list of patches where using the *_perror() instead of the *_error() function would make sense. Yet, I encountered both errors in my development and really needed to get a better idea what was wrong than, say, "can't cd to ...". Hopefully these patches are useful

[PATCH 1/2] ash: report reason when a script file could not be opened

2017-08-22 Thread Johannes Schindelin
It is always nicer to give the user some sort of indication why an operation failed. Signed-off-by: Johannes Schindelin --- shell/ash.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/shell/ash.c b/shell/ash.c index 703802ff5..a67a45376 100644 ---

stable sort? (sort -s)

2017-08-22 Thread Assaf Gordon
Hello, Does busybox's sort implements a stable sort? I see it accepts "-s" option, and I see in the source code that FLAG_s does disable the last-resort comparison: https://git.busybox.net/busybox/tree/coreutils/sort.c#n343 However, It seems the code also uses qsort() which is not stable -

Re: Busybox in Debian

2017-08-22 Thread Denys Vlasenko
On Mon, Aug 21, 2017 at 8:38 PM, Ben Hutchings wrote: > On Mon, 2017-08-21 at 19:40 +0200, Denys Vlasenko wrote: >> > On Mon, Aug 14, 2017 at 5:12 PM, Ben Hutchings >> > wrote: >> > On Mon, 2017-08-14 at 16:42 +0200, Denys Vlasenko wrote: >> > > > >

Re: [PATCH] ps: Allow ps config options if minips is enabled

2017-08-22 Thread Denys Vlasenko
Applied, thanks! On Sat, Aug 19, 2017 at 8:18 AM, Kang-Che Sung wrote: > Follow-up of commit ab77e81a8527fa11a4f9392d97c2da037d6f4f98 > "klibc-utils: new applets: resume, nuke, minips" > > Also put FEATURE_PS_UNUSUAL_SYSTEMS to under FEATURE_PS_TIME in the > menu. > >

[PATCH] libarchive: fix build failure on NOMMU systems

2017-08-22 Thread Ron Yorston
In the old code fd was an argument, now we need to get the file descriptor from the xstate structure. Signed-off-by: Ron Yorston --- archival/libarchive/open_transformer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/archival/libarchive/open_transformer.c

[PATCH] rpm2cpio: allow building with rpm disabled

2017-08-22 Thread Ron Yorston
With rpm disabled and rpm2cpio enabled the build fails because the symbol ARCHIVE_REPLACE_VIA_RENAME isn't defined. Signed-off-by: Ron Yorston --- archival/rpm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/archival/rpm.c b/archival/rpm.c index

[PATCH] ps: fix build failure if FEATURE_PS_TIME is disabled

2017-08-22 Thread Ron Yorston
The global seconds_since_boot is only defined if FEATURE_PS_TIME is enabled. Signed-off-by: Ron Yorston --- procps/ps.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/procps/ps.c b/procps/ps.c index 7edf6dbd1..8aaa7e178 100644 --- a/procps/ps.c +++

Re: [PATCH] libarchive: fix build failure on NOMMU systems

2017-08-22 Thread Denys Vlasenko
Applied, thanks On Tue, Aug 22, 2017 at 12:34 PM, Ron Yorston wrote: > In the old code fd was an argument, now we need to get the file descriptor > from the xstate structure. > > Signed-off-by: Ron Yorston > --- > archival/libarchive/open_transformer.c | 2 +- >

Re: [PATCH] rpm2cpio: allow building with rpm disabled

2017-08-22 Thread Denys Vlasenko
On Tue, Aug 22, 2017 at 11:57 AM, Ron Yorston wrote: > With rpm disabled and rpm2cpio enabled the build fails because the > symbol ARCHIVE_REPLACE_VIA_RENAME isn't defined. > > Signed-off-by: Ron Yorston > --- > archival/rpm.c | 2 +- > 1 file changed, 1

Re: [PATCH] ps: fix build failure if FEATURE_PS_TIME is disabled

2017-08-22 Thread Denys Vlasenko
Applied, thanks On Tue, Aug 22, 2017 at 12:21 PM, Ron Yorston wrote: > The global seconds_since_boot is only defined if FEATURE_PS_TIME > is enabled. > > Signed-off-by: Ron Yorston > --- > procps/ps.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) >