Re: [PATCH] udhcpc: add support for long options

2020-08-15 Thread Martin Lewis
Tested both regular options and long options against ISC's dhcpd, looks good. Martin On Thu, 13 Aug 2020 at 10:00, Denys Vlasenko wrote: > On Tue, Aug 4, 2020 at 5:25 PM Martin Lewis > wrote: > > Duplicate options are currently overridden (only the last option is > kept). > > This leads to

Re: [PATCH] ip rule: add support for fwmark/fwmask for policy routing

2020-08-15 Thread Rui Salvaterra
Friendly ping! On Fri, 31 Jul 2020 at 10:11, Rui Salvaterra wrote: > > This adds support for fwmark/fwmask in ip rule which is needed, for example, > in > OpenWrt's mwan3. Masks are supported since Linux 2.6.19. > > Fixes: https://bugs.busybox.net/show_bug.cgi?id=11621 > > Signed-off-by: Rui

xxd trailing spaces

2020-08-15 Thread David Timber
Compare the output of these two command: dd if=/dev/zero bs=1 count=1 | busybox xxd -p | hexdump -C dd if=/dev/zero bs=1 count=1 | xxd -p | hexdump -C The bb version of xxd prints extra trailing spaces(0x20). So, if you want to use the output of xxd command in your shell script, you'll need to

Re: [PATCH] hwclock: Fix settimeofday for glibc v2.31+

2020-08-15 Thread Denys Vlasenko
Applied, thanks On Mon, Aug 10, 2020 at 4:59 PM Eddie James wrote: > > From: Eddie James > > The glibc implementation changed for settimeofday, resulting in "invalid > argument" error when attempting to set both timezone and time with a single > call. Fix this by calling settimeofday twice > >

Re: [PATCH 2/4] httpd: Don't add Date header to response

2020-08-15 Thread Denys Vlasenko
On Sun, Aug 9, 2020 at 12:24 AM Sergey Ponomarev wrote: > @@ -1071,16 +1079,18 @@ static void send_headers(unsigned responseNum) > * always fit into those kbytes. > */ > > - strftime(date_str, sizeof(date_str), RFC1123FMT, gmtime_r(, > )); > - /* ^^^ using

Re: [PATCH 2/4] httpd: Don't add Date header to response

2020-08-15 Thread Sergey Ponomarev
yes, but simplifies code. I think that for those who are concerned with one additional sprintf call can just disable the header. On Sun, 16 Aug 2020 at 00:07, Denys Vlasenko wrote: > On Sun, Aug 9, 2020 at 12:24 AM Sergey Ponomarev > wrote: > > @@ -1071,16 +1079,18 @@ static void

Re: [PATCH 3/4] httpd: Don't add Last-Modified header to response

2020-08-15 Thread Denys Vlasenko
On Sun, Aug 9, 2020 at 12:24 AM Sergey Ponomarev wrote: > */ > static void send_headers(unsigned responseNum) > { > +#if ENABLE_FEATURE_HTTPD_DATE || ENABLE_FEATURE_HTTPD_LAST_MODIFIED > static const char RFC1123FMT[] ALIGN1 = "%a, %d %b %Y %H:%M:%S GMT"; > /* Fixed size

Re: [PATCH 4/4] httpd: Support caching via ETag header

2020-08-15 Thread Sergey Ponomarev
Awesome, thanks! I reviewed and tested and all looks fine. I don't want to bother you but I see two improvings: 1. While ETag minimizes load on each load will be sent a new request. To avoid such requests at all for assets we can add a header Cache-Control: public,max-age=31536000,immutable But