[PATCH] udhcp: add PXELINUX path prefix option (code 210) definition

2014-01-16 Thread Jeremy Kerr
Like d3092c99, this change adds support for the DHCP "path-prefix" option, as defined in RFC 5071. We use the string identifer "pxepathprefix". Adding this option makes string parsing in the hook scripts simpler. Signed-off-by: Jeremy Kerr --- networking/udhcp/common.c |

[PATCH resend] udhcp: add PXELINUX path prefix option (code 210) definition

2014-07-14 Thread Jeremy Kerr
Like d3092c99, this change adds support for the DHCP "path-prefix" option, as defined in RFC 5071. We use the string identifer "pxepathprefix". Adding this option makes string parsing in the hook scripts simpler. Signed-off-by: Jeremy Kerr --- networking/udhcp/common.c |

[PATCH] init: handle kexec clean reboot

2013-05-19 Thread Jeremy Kerr
in a method similar to upstart, by adding an rc.d script that performs the reboot() syscall with the correct kexec magic. However, this is a little inconsistent with the existing reboot methods. Signed-off-by: Jeremy Kerr --- init/halt.c | 12 +--- init/init.c |9 ++

Re: [PATCH] init: handle kexec clean reboot

2013-05-19 Thread Jeremy Kerr
Hi Harald, > Do we really need this? That's what I'd like to find out :) > Busybox init has a restart action. If > this action is set to a script it is invoked after normal > shutdown processing. The script may do whatever action may be > required or optionally restart the init process. That se

Re: [PATCH] init: handle kexec clean reboot

2013-05-19 Thread Jeremy Kerr
Hi all, > That seems a little bit clunky; we may not always want the restart > action to be a kexec (but just a normal reboot). In this case, would we > need to be dynamically reconfiguring the restart action? Hm, it looks like we can indeed set up kexec as a "permanent" restart handler without a

Re: [PATCH] init: handle kexec clean reboot

2013-05-20 Thread Jeremy Kerr
Hi Harald, > We have already three types of shutdown: halt, reboot and > poweroff. All three are handled by the same restart action Yep, and my original patch adds a forth to the same path the halt/reboot/poweroff. This is slightly different to the restart path: halt_reboot_pwoff() vs. restart_ha

[PATCH] udhcp: Add config file option (code 209) definition

2013-11-03 Thread Jeremy Kerr
This change adds a definition for DHCP option 209. RFC 5071 defines code 209 as a configuration file for a PXE bootloader; this change uses the string "conffile" as its text identifier. Signed-off-by: Jeremy Kerr --- networking/udhcp/common.c |2 ++ 1 file changed, 2 insertion

Re: [PATCH] udhcp: Add config file option (code 209) definition

2013-11-04 Thread Jeremy Kerr
Hi Denys, >> @@ -62,6 +62,7 @@ const struct dhcp_optflag dhcp_optflags[] = { >> { OPTION_U16 , 0x84 }, /* DHCP_VLAN_ID >> */ >> { OPTION_U8 , 0x85 }, /* >> DHCP_VLAN_PRIORITY */ >> #endif >> + { OPTION_STRING

Race in reboot/poweroff path at init?

2017-10-10 Thread Jeremy Kerr
Hi all, I've been debugging an issue where we can't reboot or poweroff a machine in the early stages of busybox init. Using the poweroff case as an example: - kernel starts /sbin/init - kernel receives a poweroff event, so calls __orderly_poweroff. Effectively, these will just call out to t

Re: Race in reboot/poweroff path at init?

2017-10-10 Thread Jeremy Kerr
Hi Laurent, Thanks for the reply, good to get some conversation going here! >> - using a synchronous channel to send the shutdown/reboot message >> between the poweroff/reboot helpers, rather than an asynchronous >> signal. Say, have init listening on a socket, allowing the poweroff >> bina

Re: Race in reboot/poweroff path at init?

2017-11-06 Thread Jeremy Kerr
Hi Denys, >> - installing the signal handlers even earlier in init_main(). However, >>this will only reduce the window for lost events, rather than >>eliminating it; or > > Sure, this should be done. How about this: > --- a/init/init.c > +++ b/init/init.c > @@ -1064,6 +1064,12 @@ int ini

Re: [PATCH v2 3/6] udhcpc6: Add PXELINUX options

2018-05-13 Thread Jeremy Kerr
Hi all, > Add support for the PXELINUX options 209 ("ConfigFile") and 210 > ("PathPrefix") in the DHCPv6 client. > > See also: RFC5071, "Dynamic Host Configuration Protocol Options Used by > PXELINUX". For those following at home: I've recently requested that these options be added to IANA's DHC

[PATCH] networking/dhcp: Add option 211, "reboot time"

2018-07-02 Thread Jeremy Kerr
As defined in RFC 5071. Signed-off-by: Jeremy Kerr --- networking/udhcp/common.c | 2 ++ networking/udhcp/common.h | 1 + 2 files changed, 3 insertions(+) diff --git a/networking/udhcp/common.c b/networking/udhcp/common.c index 52ef875f0..ca7c8211b 100644 --- a/networking/udhcp/common.c +++ b

Re: [PATCH] networking/dhcp: Add option 211, "reboot time"

2018-07-02 Thread Jeremy Kerr
Hi all, As defined in RFC 5071. Signed-off-by: Jeremy Kerr This depends on udhcpc implementing the reboottime DHCP parameter, which I've contributed to busybox here: http://lists.busybox.net/pipermail/busybox/2018-July/086540.html Cheers, J

Re: [PATCH] networking/dhcp: Add option 211, "reboot time"

2018-07-02 Thread Jeremy Kerr
Hi all, As defined in RFC 5071. Signed-off-by: Jeremy Kerr This depends on udhcpc implementing the reboottime DHCP parameter, which I've contributed to busybox here: http://lists.busybox.net/pipermail/busybox/2018-July/086540.html Sorry for the noise - this was meant to go wit

Re: [PATCH] networking/dhcp: Add option 211, "reboot time"

2018-07-04 Thread Jeremy Kerr
Hi Denys, @@ -133,6 +134,7 @@ const char dhcp_option_strings[] ALIGN1 = #endif "pxeconffile" "\0" /* DHCP_PXE_CONF_FILE */ "pxepathprefix" "\0" /* DHCP_PXE_PATH_PREFIX */ + "reboottime" "\0 " /* DHCP_PXE_PATH_PREFIX */ Stray space after \0, bad comment D'oh! v2 c

[PATCH v2] networking/dhcp: Add option 211, "reboot time"

2018-07-04 Thread Jeremy Kerr
As defined in RFC 5071. Signed-off-by: Jeremy Kerr --- v2: - fix option string definition --- networking/udhcp/common.c | 2 ++ networking/udhcp/common.h | 1 + 2 files changed, 3 insertions(+) diff --git a/networking/udhcp/common.c b/networking/udhcp/common.c index 52ef875f0..6c36adac3

[PATCH 2/3] sysctl: abort reading on NULL keys

2007-11-27 Thread Jeremy Kerr
At present, sysctl_read_setting() detects NULL keys, but keeps processing regardless. This change aborts the read on NULL keys. Signed-off-by: Jeremy Kerr <[EMAIL PROTECTED]> -- bloat-o-meter results on powerpc: function old new

[PATCH 3/3] sysctl: add -e option

2007-11-27 Thread Jeremy Kerr
The sysctl tool is missing the -e option, to supress warnings about invalid keys. This is handy for distributions that ship an /etc/sysctl.conf, which may contain keys that aren't valid for the current kernel. This change adds the -e option. Signed-off-by: Jeremy Kerr <[EMAIL P

[PATCH 1/3] sysctl: Add a flags variable, and use it to pass output parameters

2007-11-27 Thread Jeremy Kerr
Signed-off-by: Jeremy Kerr <[EMAIL PROTECTED]> -- bloat-o-meter results on powerpc: function old new delta sysctl_display_all 220 212 -8 sysctl_main 684