Subject: Re: [PATCH 3/4] lsscsi: code shrink and refactor
Hi Martin,
> Remove the use of strou because scsi device types are signed (as seen in the
> kernel's code).
> Improve the representation of SCSI_DEVICE_LIST.
Maybe you should make those changes in two patches: one that s
Hi Martin,
> Remove the use of strou because scsi device types are signed (as seen in the
> kernel's code).
> Improve the representation of SCSI_DEVICE_LIST.
Maybe you should make those changes in two patches: one that seems
nice and is not attracting much attention (improve SCSI_DEVICE_LIST),
Allowing erroneous pages to render is not inherently bad, especially with
standards that can change in the future. Look at earlier HTML (< 4) vs XHTML.
If a page is written in XHTML and is read by a browser that doesn't understand
XHTML, the browser still attempting to render it by ignoring any
to use the built-in error
handling instead.
//Markus
Sent from my BlackBerry - the most secure mobile device
Original Message
From: mcon...@intellitree.com
Sent: July 9, 2020 23:01
To: busybox@busybox.net
Subject: Re: [PATCH 3/4] lsscsi: code shrink and refactor
On 7/9/2020 3
On 7/9/2020 3:16 PM, Markus Gothe wrote:
Jon Postel formulated the robustness principle decades ago. Still
today it is a good advice to "be liberal in what you accept and strict
in what you send".
Counterexample: Internet Explorer
It allowed so much garbage to render correctly that other
c: busybox@busybox.netSubject: Re: [PATCH 3/4] lsscsi: code shrink and refactor Here's the struct as specified in the kernel:/* From /drivers/scsi/scsi_sysfs.c in the kernel: * sdev_rd_attr (type, "%d\n"); * sdev_rd_attr (vendor, "%.8s\n"); * sdev_rd_attr (model, "%.16
Here's the struct as specified in the kernel:
/* From /drivers/scsi/scsi_sysfs.c in the kernel:
* sdev_rd_attr (type, "%d\n");
* sdev_rd_attr (vendor, "%.8s\n");
* sdev_rd_attr (model, "%.16s\n");
* sdev_rd_attr (rev, "%.4s\n");
*/
As you can see, type is always printed with %d which should
As the original author of the applet I don't want to see atoi() calls in the
code. You know what atoi() returns when it fails? Same as atoi("0").
Please use bb_stroi() for signed integers.
BR,
Markus
Sent from my BlackBerry - the most secure mobile device
Original Message
