Re: [patch] setfiles bugfix

2007-09-26 Thread Natanael Copa
On Wed, 2007-09-26 at 16:44 +0900, Yuichi Nakamura wrote:
 This patch fixes bug in setfiles.
 setfiles segfaults in p[0] = '\0'.

should be added to fixes-1.7.1 as well.

-nc

___
busybox mailing list
busybox@busybox.net
http://busybox.net/cgi-bin/mailman/listinfo/busybox


Re: [patch] setfiles bugfix

2007-09-26 Thread Denys Vlasenko
On Wednesday 26 September 2007 08:44, Yuichi Nakamura wrote:
 
 This patch fixes bug in setfiles.
 setfiles segfaults in p[0] = '\0'.

I am applying this instead:

diff -urN busybox-1.7.1/selinux/setfiles.c 
busybox-1.7.1-setfiles/selinux/setfiles.c
--- busybox-1.7.1/selinux/setfiles.c2007-09-03 12:48:46.0 +0100
+++ busybox-1.7.1-setfiles/selinux/setfiles.c   2007-09-26 18:58:22.0 
+0100
@@ -189,7 +189,7 @@
file_sep = strrchr(tmp_path, '/');
if (file_sep == tmp_path) {
file_sep++;
-   p[0] = '\0';
+   path[0] = '\0';
p = path;
} else if (file_sep) {
*file_sep++ = '\0';
 

It should be shorter.
--
vda
___
busybox mailing list
busybox@busybox.net
http://busybox.net/cgi-bin/mailman/listinfo/busybox