Re: Timeline for a new c-ares release

2016-01-13 Thread Daniel Stenberg
On Sat, 9 Jan 2016, Gregor Jasny wrote: Would it make sense to create a new release? Yes it would! There have been a bunch of patches flying around that I personally haven't paid much attention to. Is there anything important we should make sure to get done before we ship ? -- / daniel.

Re: Unit test suite for c-ares

2015-11-25 Thread Daniel Stenberg
On Wed, 25 Nov 2015, David Drysdale wrote: - Fix double-free from ares__read_line() failure case https://github.com/daviddrysdale/c-ares/commit/d91d731636f5 +1 - Extend the injection of malloc/free to cover realloc too: https://github.com/daviddrysdale/c-ares/commit/492a1cc5e4fa This modif

Re: Unit test suite for c-ares

2015-10-30 Thread Daniel Stenberg
On Thu, 22 Oct 2015, David Drysdale wrote: By the way, I should observe that so far I've only seen one thing that might count as a bug, even running with sanitizers/fuzzers etc -- so kudos for the quality of the code! Cool! That one thing is in this change: https://github.com/daviddrysdale

Re: Unit test suite for c-ares

2015-10-09 Thread Daniel Stenberg
On Fri, 9 Oct 2015, David Drysdale wrote: I've made a start on a unit test suite for c-ares, and I'd be interested in any feedback. In one word? AWESOME. I'm not a big C++ guy myself so I'm not overly thrilled with that choice, but I'm also much more *for* progress than letting my personal p

Re: Time spent in ares_init_options

2015-07-23 Thread Daniel Stenberg
On Mon, 20 Jul 2015, Paul Oliver wrote: https://github.com/bagder/c-ares/blob/bba4dc573f5c31b0145d09aa2c245e94896cf1df/ares_init.c#L1908 . What's RANDOM_FILE in your case? That function does look a bit fishy and possible to improve. /dev/urandom (on OSX) Any suggestion on how to fix that

Re: Re: overly forceful checking of CFLAGS vs CPPFLAGS?

2015-06-29 Thread Daniel Stenberg
On Mon, 29 Jun 2015, Karl Palsson wrote: No problem. I totally agree that they _should_ I was just curious whether it was really c-ares's job to be _enforcing_ that. It feels a little out of scope, and I haven't come across any other projects doing so. It's also handled by special m4 macros

Re: overly forceful checking of CFLAGS vs CPPFLAGS?

2015-06-29 Thread Daniel Stenberg
On Fri, 26 Jun 2015, Peter Pentchev wrote: if a project supports a separation between CPPFLAGS and CFLAGS, then -I, -U, -D and friends should indeed be passed in CPPFLAGS. I'm bound to agree. I would like a stronger use case that really cannot adapt to that rule before loosening our checks.

Re: unchecked double linked list prev pointer cause SIGSEGV

2015-03-26 Thread Daniel Stenberg
On Thu, 26 Mar 2015, massimo dragano wrote: Can you give us a recipe how to repeat this? Which version are you using? -- / daniel.haxx.se

Re: ares_process Segmentation Violation

2015-03-26 Thread Daniel Stenberg
On Thu, 26 Mar 2015, massimo dragano wrote: Program received signal SIGSEGV, Segmentation fault. Same here, can you please tell us how to repeat this? -- / daniel.haxx.se

Re: c-ares and getaddrinfo() for IPv6

2015-01-29 Thread Daniel Stenberg
On Thu, 29 Jan 2015, Ramasamy, Vasanthakumari wrote: I would like to know whether there are plans to use getaddrinfo() instead of gethostbyname() in c-ares. Feel free to take the lead on this. -- / daniel.haxx.se

Re: CVE-2015-0235

2015-01-28 Thread Daniel Stenberg
On Wed, 28 Jan 2015, Daniel Hardman wrote: Do we know if c-ares (indirectly) uses __nss_hostname_digits_dots() from glibc? I can't find any such uses nor can I think of any place that would. -- / daniel.haxx.se

Re: support for event-based loops (or workaround for FD_SETSIZE limit)

2015-01-23 Thread Daniel Stenberg
On Thu, 22 Jan 2015, Daniel Hardman wrote: I would love to switch to an epoll-style approach. I found one interaction between Daniel S and someone else on this forum, where this was discussed. Daniel said he had added ares_getsock() to support just such a use case. However, ares_getsock() only

Re: [PATCH] ares_parse_txt_reply: add `record_start` field

2014-12-11 Thread Daniel Stenberg
On Thu, 11 Dec 2014, Jakub Hrozek wrote: You want me to add a couple of `void*`? I was thinking: uint8_t reserved[16]; Another way, which is one I've used elsewhere, is this: struct larger_in_future { int age; /* generation of struct */ void *member; /* always present */

Re: [PATCH] ares_parse_txt_reply: add `record_start` field

2014-12-10 Thread Daniel Stenberg
On Wed, 10 Dec 2014, Fedor Indutny wrote: The only thing that is missing is an extra field. What about coming up with a way to make the struct possible to change in the future so that we won't have to create yet another function later down the line? -- / daniel.haxx.se

Re: [PATCH] ares_parse_txt_reply: add `record_start` field

2014-12-09 Thread Daniel Stenberg
On Fri, 5 Dec 2014, Fedor Indutny wrote: We kind of did, but never decided on a way of doing it. Do you have any suggestions? We need a new function that returns another struct so that the existing applications remain functional and new ones can use the new shiny. -- / daniel.haxx.se

Re: [PATCH] ares_parse_txt_reply: add `record_start` field

2014-12-04 Thread Daniel Stenberg
On Fri, 5 Dec 2014, Fedor Indutny wrote: The patch was in the first email from this thread. Yes, like almost 200 years ago =) Let me re-paste it here just in case. Thanks! Didn't we already agree that we cannot modify the public struct like that as it risks break existing users of that ca

Re: [PATCH] ares_parse_txt_reply: add `record_start` field

2014-12-04 Thread Daniel Stenberg
On Thu, 4 Dec 2014, Fedor Indutny wrote: I still would like to ask you to land this in the form it has right now. You'd simplify our lives if you'd also attach the patch you're talking about, or a link to it! This has already caused some problems with incompatibility between c-ares in node

Re: 'ares_getaddrinfo' is available?

2014-10-30 Thread Daniel Stenberg
On Thu, 30 Oct 2014, Vinay Kumar wrote: I am using 'c-ares' library in our application. We have used 'getaddrinfo' in many places. Is there any equivalent function called 'ares_getaddrinfo'? Because 'ares_nameinfo.pdf' contains 'ares_getaddrinfo' in SEE ALSO section. If 'ares_getaddrinfo' is a

Re: Periodic Coverity Scan

2014-09-17 Thread Daniel Stenberg
On Wed, 17 Sep 2014, Jakub Hrozek wrote: FWIW, we scan all packages in RHEL with Coverity, but mostly look at diffs between versions -- which already found some bugs. I'm not sure if anyone did a full review of all the messages Coverity would spit out.. Oh, this made me realize my daily clang

Re: Need help in building the C-ares on windows

2014-09-07 Thread Daniel Stenberg
On Sun, 7 Sep 2014, Arif Ali wrote: I searched for ares_build.h and did not find this file instead I found ares_build.h.in ares_build.h.dist You can copy ares_build.h.dist to ares_build.h to get a file that is usually provided in the tarballs. What is "CONFIGURE CAPABLE" ? configure is

Re: Patch for fixing the slow DNS lookup issue

2014-07-25 Thread Daniel Stenberg
On Fri, 25 Jul 2014, David Drysdale wrote: Pushed. Hopefully it might help a bit. Speaking of that, we have three old pull requests pending: https://github.com/bagder/c-ares/pulls -- / daniel.haxx.se

[c-ares] Draft support DNSSEC + DANE (#16) (fwd)

2014-06-12 Thread Daniel Stenberg
FYI -- / daniel.haxx.se -- Forwarded message -- Date: Thu, 12 Jun 2014 16:20:34 From: Nikos Mavrogiannopoulos Reply-To: bagder/c-ares To: bagder/c-ares Subject: [c-ares] Draft support DNSSEC + DANE (#16) This series of patches adds support for DNSSEC + parsing of DANE s

Re: [PATCH] ares_parse_txt_reply: add `record_start` field

2014-05-26 Thread Daniel Stenberg
On Thu, 22 May 2014, Fedor Indutny wrote: Unfortunately, there is no certain description of how TXT records should be used after parsing. Clearly some people may want to get each chunk of each record separately and use them as they want to. Concatenation will definitely make c-ares unusable fo

Re: Patch for fixing the slow DNS lookup issue

2014-05-24 Thread Daniel Stenberg
On Thu, 22 May 2014, Jakub Hrozek wrote: I can't comment on the patch contents myself at all, because I'm not a Windows developer, but I guess it would be easier for others to review if the patch was a git-formatted one or a github pull request since c-ares uses git and github anyway. I gene

Re: [PATCH] ares_parse_soa_reply: Do not leak rr_name on allocation failure

2014-05-22 Thread Daniel Stenberg
On Thu, 22 May 2014, Jakub Hrozek wrote: The updated code change looks OK to me (but I've not actually exercised the new arm). Daniel, is it OK if I push this patch? No need to ask me for permission. I trust you and your judgement, and if there's more people giving their thumbs up I think y

reminder: there's no I in team

2014-05-14 Thread Daniel Stenberg
Hello, It's been a very long time since I last mentioned this but I want to repeat that for me, c-ares is not a top priority project and it hasn't been for years. To get your patches merged into c-ares I *strongly* urge you to get someone else than me to (also) review and vouch for your chan

Re: A patch to fix building on 64-bit powerpc

2014-02-16 Thread Daniel Stenberg
On Fri, 14 Feb 2014, Doug Kwan (關振德) wrote: My patch is two change the order of the checks so that we check the 64-bit case first. Could someone consider that patch and incorporate that into ares? Thanks, seems correct to me and I've merged and pushed this now! -- / daniel.haxx.se

Re: MSVC 2013 - CARESConfig.cmake to allow c-ares uage in CURL

2013-12-09 Thread Daniel Stenberg
On Fri, 22 Nov 2013, Torben Dannhauer wrote: Please find attached the CARESConfig.cmake file required by CURL to detect (or at least allow manual configuration) of C-ares uage in CURL. Thanks for your contribution. (sorry for the excessive response time) Unfortunately, this file doesn't seem

Re: integration of c-ares into various file descriptor based main loops [reposted]

2013-11-14 Thread Daniel Stenberg
On Thu, 7 Nov 2013, Pavel Simerda wrote: Would you consider an additional API as an alternative to `ares_fds()`, `ares_timeout()` and `ares_process_fd()` consisting of functions similar to the following ones useful? * void ares_set_fd_callback(ares_channel channel, int (*callback)(int fd, int

Re: [Patch] Invalid memory access in ares_search.c (for empty string input)

2013-11-12 Thread Daniel Stenberg
On Tue, 12 Nov 2013, David Drysdale wrote: We noticed a small buglet in ares_search() when it gets an empty string as input -- the single_domain() utility function in ares_search.c accesses invalid memory (before the start of the string). I've attached a patch below. Thanks, pushed! -- /

Re: integration of c-ares into various file descriptor based main loops

2013-11-07 Thread Daniel Stenberg
On Wed, 6 Nov 2013, Jakub Hrozek wrote: Maybe you could also include libverto. It's relatively new event loop library that encapsulates other event loop approaches as back ends. It's being used by MIT Kerberos and GSS-Proxy among others. I would say that the most sensible thing for a library

Re: curl with c-ares

2013-09-05 Thread Daniel Stenberg
On Thu, 5 Sep 2013, Fred Huang wrote: the code should focus on saving memory for large volumes users. Low volume users will have no pressure on the memory or performance. Uh? And in which way then do you think leaving the default or lowering them change the memory requirements for large volum

Re: curl with c-ares

2013-09-04 Thread Daniel Stenberg
On Tue, 3 Sep 2013, Shao, Shuchao wrote: Via checking the C-ares souce code, there are two large 'for' loops in function ares_init_options(), #define ARES_QID_TABLE_SIZE 2048 #define ARES_TIMEOUT_TABLE_SIZE 1024 My immediate gut reactions: 1 - try with much smaller values, like 89 and 47 (

Re: [PATCH] ares_rules.h: CARES_SIZEOF_LONG doesn't exist anymore, don't test for it

2013-08-30 Thread Daniel Stenberg
On Fri, 30 Aug 2013, Tor Arntsen wrote: Curl autobuilds using --enable-ares have been broken for some days due to CARES_SIZE_LONG which has been removed but still referenced in ares_rules.h A possible fix is attached (just removes expected existence of CARES_SIZEOF_LONG from ares_rules.h) T

Re: Multilib issue with c-ares

2013-08-28 Thread Daniel Stenberg
On Tue, 27 Aug 2013, Daniel Stenberg wrote: If they all support limits.h *or* have 32 bit longs... I've pushed my solution now! -- / daniel.haxx.se

Re: Multilib issue with c-ares

2013-08-27 Thread Daniel Stenberg
On Tue, 27 Aug 2013, Jakub Hrozek wrote: If all platforms the upstream is interested in support limits.h (even those funky HP-UX etc), then this should work, yes. If they all support limits.h *or* have 32 bit longs... -- / daniel.haxx.se

Re: Multilib issue with c-ares

2013-08-27 Thread Daniel Stenberg
instead relying on which is POSIX ? See my attachment for a fix I belive can work. -- / daniel.haxx.seFrom f19387dd7243239f2f393220ba375b64f06731ed Mon Sep 17 00:00:00 2001 From: Daniel Stenberg Date: Tue, 27 Aug 2013 13:36:41 +0200 Subject: [PATCH] nowarn: use instead of configure for size

Re: Multilib issue with c-ares

2013-08-26 Thread Daniel Stenberg
On Mon, 26 Aug 2013, Jakub Hrozek wrote: I have a problem using c-ares in a multilib environment, for which I found a patch in Fedora that does not seem to have found its way upstream. I actually sent the patch upstream: http://c-ares.haxx.se/mail/c-ares-archive-2010-06/0009.shtml After re-

Re: Ares on mobile devices / IP address changes / DNS server changes

2013-07-31 Thread Daniel Stenberg
On Wed, 31 Jul 2013, Mark Delany wrote: My implementation is a platform-specific hack, so it's not even suitable as an offering. One could perhaps imagine a new function that would return enough information for the application to know what to check for updates? and/or a function that does th

Re: Resolving names without dns-suffix on windows

2013-06-25 Thread Daniel Stenberg
On Tue, 25 Jun 2013, Maxim Ruban wrote: Patch is in attach (pl. let me know if something wrong with it - I've made it by TortoiseCVS on Windows, and don't know if it's compatible with Unix-family tools). Please, review it and improve if neccessary. I'm very interested in "+1"s or other expr

RELEASE: c-ares 1.10.0

2013-05-12 Thread Daniel Stenberg
Hi friends! Almost eleven months since the previous release, I'm glad to announce a brand new c-ares tarball uploaded to the site: http://c-ares.haxx.se/ c-ares version 1.10.0 Changes: o Added ares_create_query(), to be used instead of ares_mkquery() o ares_inet_ntop() and ares_inet_pton()

Re: Cosmetic bugs in http://c-ares.haxx.se/ares_parse_a_reply.html and http://c-ares.haxx.se/ares_parse_aaaa_reply.html

2013-05-02 Thread Daniel Stenberg
On Thu, 21 Mar 2013, Alexander Klauer wrote: in the HTML pages mentioned in the subject, there are spurious '\fB' sequences in the synopses. Possibly they have to be changed to '\fP' in the source man pages, but I don't know enough roff to say for sure. Thanks! It took me forever but I've now

Re: DNS servers on windows

2013-05-02 Thread Daniel Stenberg
On Thu, 2 May 2013, Patrick Valsecchi wrote: In attachment, you'll find my proposed patch for this problem. Where do we stand on this one? Do I have to change something in this proposed patch? Can you please provide a full patch, including a sensible commit message that explains the change

Re: Fixing a few errors and warning detected by coverity

2013-05-02 Thread Daniel Stenberg
On Thu, 2 May 2013, Patrick Valsecchi wrote: A colleague ran Coverity (a static analysis tool) against c-ares and fixed a few reported errors and warnings. Please have a look at the attached patch. Thanks! There's a large amount of added typecasts for malloc() and a few other void pointers

Re: Patch to build current head (3f0ec47) on msvc11

2013-05-02 Thread Daniel Stenberg
On Wed, 1 May 2013, Alex Loukissas wrote: Since I figured out the issue, I thought I'd share the patch with you. Feel free to use it. Thanks, merged and pushed! -- / daniel.haxx.se

Re: Proposal for unittests

2013-04-28 Thread Daniel Stenberg
On Fri, 26 Apr 2013, Steinar H. Gunderson wrote: We have some unit tests internally; nothing complete, but maybe useful. They're written using Google Test (no surprise there :-) ) and not CuTest, though, so it means C++. Thanks for the offer, but I would really prefer us to not get C++ involv

Re: Proposal for unittests

2013-04-28 Thread Daniel Stenberg
On Fri, 26 Apr 2013, Patrick Valsecchi wrote: In attachment, you'll find a small prototype of a unittest suite for c-ares. I didn't integrate it with the autotools stuff, since I don't know it (we use cmake). For the moment, it is only testing the ares_parse_txt_reply function. I've used the

Re: soname

2013-04-23 Thread Daniel Stenberg
On Tue, 23 Apr 2013, Jakub Hrozek wrote: Are there any plans to bump the soname to reflect the API additions? Done! -- / daniel.haxx.se

RE: DNS servers on windows

2013-04-23 Thread Daniel Stenberg
On Tue, 23 Apr 2013, Bert Belder wrote: As a Node.js maintainer I also ran into this problem. Our solution was to ignore these fec0:: servers entirely (https://github.com/piscisaureus/cares/commit/f6cdd7d404d44eb2d6e8866e85ae65 1b89fc769e), and we've never had any complaints about it. I think

Re: ares_parse_txt_reply's output is not usable for DNS-SD

2013-04-23 Thread Daniel Stenberg
On Tue, 23 Apr 2013, Jakub Hrozek wrote: Hi Daniel, are you planning on releasing another point version of c-ares with these fixes in? Or should distributions cherry-pick the patches? Due to the changes we've already merged I'm planning a 1.10.0 release at some point soon. I updated the RELEA

Re: Parsing of 'Additional Records' in SRV response

2013-04-22 Thread Daniel Stenberg
On Mon, 22 Apr 2013, Jakub Hrozek wrote: I implemented the first version of the SRV parsing and I must confess I no longer remember why the additional record was not parsed, sorry. I'm sure a patch would be welcome. Oh indeed. Sounds like an excellent idea to me! -- / daniel.haxx.se

Re: ares_parse_txt_reply's output is not usable for DNS-SD

2013-04-22 Thread Daniel Stenberg
On Tue, 16 Apr 2013, Patrick Valsecchi wrote: Good point, thanks! Here is the patch V2. Thanks, merged and pushed now! -- / daniel.haxx.se

Re: [PATCH 2/3] library init: documentation update

2013-04-22 Thread Daniel Stenberg
On Mon, 22 Apr 2013, Alexander Klauer wrote: sorry for being a pest, but this patchset still has not made it into the master branch at https://github.com/bagder/c-ares/commits/master. Is there still something wrong with it? What can I do to help? Pushed now, thanks! -- / daniel.haxx.se

mDNS (was Re: ares_parse_txt_reply's output is not usable for DNS-SD)

2013-04-15 Thread Daniel Stenberg
On Mon, 15 Apr 2013, Patrick Valsecchi wrote: While I'm writing to this mailing list, I've seen some discussions in the archives about doing an implementation for mDNS. What is the status on that? I'm not aware of anyone working on that! -- / daniel.haxx.se

Re: ares_parse_txt_reply's output is not usable for DNS-SD

2013-04-15 Thread Daniel Stenberg
On Mon, 15 Apr 2013, Patrick Valsecchi wrote: In attachment, you find a patch against the current git that includes yours and the fixes for the other problems. I tested against my feature tests on Linux, but I use only parsing of PTR, SRV and TXT. I pushed the commit 148c8e0353d93d7c0 now.

Re: ares_parse_txt_reply's output is not usable for DNS-SD

2013-04-15 Thread Daniel Stenberg
On Mon, 15 Apr 2013, Patrick Valsecchi wrote: 2) change ares_parse_txt_reply to return another ares_txt_reply node for each sub-string. IMHO, I think this is the right approach. Possibly it's bad changing behavior of that public function... But I wonder how many actually use the parse

Re: ares_parse_txt_reply's output is not usable for DNS-SD

2013-04-15 Thread Daniel Stenberg
On Mon, 15 Apr 2013, Patrick Valsecchi wrote: Who has the authority to accept patches? I do (and a couple of others as well). And of course getting additional +1s on patches make me accept them faster and easier... -- / daniel.haxx.se

[c-ares] Really fix memory leak when parsing AAAA replies. (#10) (fwd)

2013-04-10 Thread Daniel Stenberg
FYI -- / daniel.haxx.se -- Forwarded message -- Date: Wed, 10 Apr 2013 05:43:07 From: psaab To: bagder/c-ares Subject: [c-ares] Really fix memory leak when parsing replies. (#10) bffd67f16a8f42fe6dbf79ab2e39d92eea05c8a6 You can merge this Pull Request by running: git

Re: [PATCH 1/4] ares_cancel(): cancel requests safely

2013-04-08 Thread Daniel Stenberg
On Mon, 8 Apr 2013, Alexander Klauer wrote: An invocation of ares_cancel() walks through the request list, calling the callbacks of all pending requests on a channel. Thanks a lot. Your mini-series has been merged and pushed! -- / daniel.haxx.se

Re: [PATCH 1/4] ares_cancel(): ensure cancellation of all requests

2013-03-23 Thread Daniel Stenberg
On Thu, 21 Mar 2013, Alexander Klauer wrote: Implementation-wise, I think I would just swap the list head in the ares channel with an empty list head on the stack, and then start walking through the list with the list head on the stack. Any new requests would then be added to the now initially

Re: Ares: socklen_t problem

2013-02-19 Thread Daniel Stenberg
On Tue, 19 Feb 2013, Yang Tse wrote: socklen_t in a public header file is potentially problematic.. there used to be one in until 7.18 I think, but it got too troublesome to maintain so it got removed. When it was mentioned if ares_inet_ntop and ares_inet_ntop were to become fully documente

Re: undocumented but used functions

2013-02-14 Thread Daniel Stenberg
On Thu, 14 Feb 2013, Saúl Ibarra Corretgé wrote: FWIW I also use those in pycares, I'd appreciate if they stay around. Many thanks all of you for your input on this. I will now consider them as part of the public c-ares API. I'll move on and make sure they get some basic documentation etc.

undocumented but used functions

2013-02-13 Thread Daniel Stenberg
Hi all, I noticed that acountry.c and ahost.c, two of our demo examples, use ares_inet_ntop() and ares_inet_pton(). None of these functions are part of our documented public API and I would like to clean this up. Anyone who feels strongly enough about this subject to speak up for either ma

Re: Problem on free() method on Windows 7

2013-02-13 Thread Daniel Stenberg
On Wed, 13 Feb 2013, aur.hoffm...@free.fr wrote: By adding traces in my program, I noticed that the problem was on free() method. You should use ares_free_string() to free that data! I've just pushed an updated to the man page clarifying this. -- / daniel.haxx.se

Re: Extending EDNS support in c-ares for sub-options

2012-10-22 Thread Daniel Stenberg
On Mon, 22 Oct 2012, David Drysdale wrote: I've got some code ready for this change, if anyone would like to see something more concrete. Is there a preferred format -- patch sent to the mailing list, or a Github pull request? Just post the patch to the list! -- / daniel.haxx.se

Re: HELP : IPAD can not have DNS resolve when using C-ares on IPAD, update

2012-09-07 Thread Daniel Stenberg
On Fri, 7 Sep 2012, Jérémy Lal wrote: I think rather you should tell us. We can hack c-ares, we may not have special knowledge about iOS devices... Special knowledge : iOS application are sandboxed, meaning you have no direct access to resolv.conf. Hehe, yeah that certainly explains it. I f

RE: HELP : IPAD can not have DNS resolve when using C-ares on IPAD,update

2012-09-07 Thread Daniel Stenberg
On Fri, 7 Sep 2012, Zhijie Yan wrote: The issue is located on resolv.conf , which can not open this file on C-ares on IOS. And this lead to servers is not configured, And the address to connect is 127.0.0.1. Any one can help solve this. Is this file not accessible or need special process? I

Re: Ares change: IRIX problem

2012-08-27 Thread Daniel Stenberg
On Fri, 24 Aug 2012, Tor Arntsen wrote: The problem is c-ares commit 90364defb038d5 which introduced the file ares_create_query.c, this file uses ns_t_opt from nameser.h On IRIX this is , and ns_t_opt does not exist there. It does exist in the local "nameser.h" file in the c-ares source, but t

Ares change: IRIX problem (fwd)

2012-08-27 Thread Daniel Stenberg
FYI, as posted to the libcurl list the other day: ... From: Tor Arntsen <...> This is strictly speaking a problem with c-ares, but I'm not on that mailing list. I just noticed because autobuilds have started to fail on IRIX. http://curl.haxx.se/dev/log.cgi?id=20120824074133-11262#prob1 The pr

Re: Possible bug in get_DNS_AdaptersAddresses

2012-08-22 Thread Daniel Stenberg
On Thu, 28 Jun 2012, Saúl Ibarra Corretgé wrote: While going through the code in get_DNS_AdaptersAddresses I found what could be a bug when dealing with IPv6 addresses. Here: https://github.com/bagder/c-ares/blob/master/ares_init.c#L1018 are_inet_ntop is called with AF_INET as the family, sho

Re: adig.c calls perror()

2012-08-21 Thread Daniel Stenberg
On Wed, 15 Aug 2012, Gisle Vanem wrote: Do we really need that function as part of the c-ares API? I realize that example is wrong, but is that reason enough to introduce a new function? We could probably just drop perror() in adig.c. And just print the error number from SOCKERRNO. I quite

Re: [PATCH] Ignore non-functional IPv6 DNS servers reported by Windows

2012-08-17 Thread Daniel Stenberg
On Fri, 17 Aug 2012, Dima Tisnek wrote: Are there any flags on these dns addresses? Filtering by those would be easier than hardcoded list/mask. Also, another option is to have feature flag to c-ares to enable/disable this filtering in case there's a risk of it causing any trouble. Daniel,

RE: [PATCH] Extension mechanisms for DNS

2012-08-16 Thread Daniel Stenberg
On Wed, 15 Aug 2012, Ghennadi Procopciuc wrote: Any feedback on this version ? Yes, thanks. I've merged and pushed it just now! -- / daniel.haxx.se

Re: adig.c calls perror()

2012-08-14 Thread Daniel Stenberg
On Fri, 10 Aug 2012, Gisle Vanem wrote: adig.c calls perror() when select() fail. This doesn't work on Winsock; perror() prints errno string, not WSAGetLastError(). So I suggest we add a new ares_perror() function to ares_strerror.c: Do we really need that function as part of the c-ares API?

RE: [PATCH] Extension mechanisms for DNS

2012-08-09 Thread Daniel Stenberg
On Tue, 24 Jul 2012, Ghennadi Procopciuc wrote: Version 3. Thanks, and sorry for my delay. I like a new function. I don't like all the new code duplication. ares_mkquery and ares_create_query should be able to be basically the same function with two different entries. ares_mkquery() can jus

Re: [Patch] Fix reading from a tcp socket

2012-07-25 Thread Daniel Stenberg
On Wed, 25 Jul 2012, Ben Greear wrote: Maybe using a while loop would be a little more intuitive? Yes please, make it into a "normal" loop instead! -- / daniel.haxx.se

clang-analyzer scans

2012-07-15 Thread Daniel Stenberg
Hi friends, I've made sure that my clang-analyzer scans of c-ares are running again. See http://c-ares.haxx.se/scans/ -- / daniel.haxx.se

Re: [PATCH] Extension mechanisms for DNS

2012-06-30 Thread Daniel Stenberg
On Fri, 29 Jun 2012, Ghennadi Procopciuc wrote: We observed that actual implementation of c-ares doesn't provides a support for extension mechanisms for DNS (EDNS), so we wrote it. Is there interest in this patch ? Thanks a lot, it looks like functionality we certainly could add. I do have a

Re: [Patch] ares_process.c

2012-06-30 Thread Daniel Stenberg
On Wed, 27 Jun 2012, Gisle Vanem wrote: Sure, but it's not nice IMHO. The code takes care not to call recv/recvfrom with ARES_SOCKET_BAD in the outer-loop. So should the inner-loop IMHO. I suggest something like: Thanks, I crafted a commit message based on your mails on this and pushed your

RE: socket callbacks

2012-06-30 Thread Daniel Stenberg
On Fri, 29 Jun 2012, Fredrik Jansson wrote: Attached is a patch file for that simple change, if it is ok I will add the documentation. You used TABs when the existing code uses spaces and you left trailing white spaces in there. A corrected version looks like attached here. I think it looks

RE: socket callbacks

2012-06-27 Thread Daniel Stenberg
On Wed, 27 Jun 2012, Fredrik Jansson wrote: "ares_set_sockopt_callback" seems like a good name. I no one objects, let's decide on that name. What did you have in mind for the opensocket cb? Anything I can fix while I am at the sockopt cb? It might be an idea to _just_ make it an opensocket

Re: socket callbacks

2012-06-27 Thread Daniel Stenberg
On Wed, 27 Jun 2012, Fredrik Jansson wrote: I am interested in using the ares lib but would need an additional socket callback, one that is called right after socket creation before the socket is configured and connected. I assume you want that so that you can set some options before connect(

Re: [Patch] ares_process.c

2012-06-26 Thread Daniel Stenberg
On Tue, 26 Jun 2012, Gisle Vanem wrote: I can see that recvfrom() in ares_process.c many times is called with 'udp_socket' == ARES_SOCKET_BAD. I think I see why: ..check for ARES_SOCKET_BAD in outer server-loop... but... count = recvfrom(server->udp_socket ...) ... process_answer(channel

Re: ANNOUNCE: c-ares 1.9.0

2012-06-18 Thread Daniel Stenberg
On Mon, 18 Jun 2012, Gregor Jasny wrote: I went though the 1.9.0 diffs and noticed ares_free_soa in ares.h. But as far as I can see it lacks an implementation. Or is there some hidden linker magic? No, there's no such function - that's a mistake. To free the ares_soa_reply struct ares_parse_

Re: ANNOUNCE: c-ares 1.9.0

2012-06-18 Thread Daniel Stenberg
On Mon, 18 Jun 2012, René Berber wrote: Using the link "GPG" on the page: --2012-06-17 16:40:32-- http://c-ares.haxx.se/c-ares-1.9.0.tar.gz.asc Reusing existing connection to c-ares.haxx.se:80. HTTP request sent, awaiting response... 404 Not Found Is it missing a "download/"? ... yes it is.

Re: ANNOUNCE: c-ares 1.9.0

2012-06-18 Thread Daniel Stenberg
On Mon, 18 Jun 2012, Gregor Jasny wrote: During Debian packaging I noticed the absence of a new symbol. It seems the tarball lacks the new file and the build system does not complain or was not re-generated. Thanks, this was also mentioned by Eugeny Gladkih to me in a private mail, and I've

ANNOUNCE: c-ares 1.9.0

2012-06-17 Thread Daniel Stenberg
Hi friends, I'm glad to announce that I've just packaged and uploaded another c-ares release! Get it as usual from http://c-ares.haxx.se/ c-ares version 1.9.0 Changed: o Added ares_parse_soa_reply Fixed: o libcares.pc generation for static MingW* cross builds o ares_dup: UDP and TCP por

Re: release time

2012-06-15 Thread Daniel Stenberg
On Tue, 12 Jun 2012, René Berber wrote: Attached is a change for the "relative names" issue I posted before. The change is only for Windows native, *untested*, and it only adds the use of the domain so relative names can resolve. Untested, sure. I don't think it is a good idea for merge code

Re: [patch] helper function to parsee SOA reply

2012-06-15 Thread Daniel Stenberg
On Thu, 7 Jun 2012, Marko Kreen wrote: I need to do SOA queries, so here is a parser for them. Thanks, I've merged and pushed this into master now! -- / daniel.haxx.se

release time

2012-06-12 Thread Daniel Stenberg
Hi I want to release a c-ares 1.8.1 soonish that has the ares_dup() function fixed, so if there's anything in particular you want shipped in a release, speak up now! -- / daniel.haxx.se

Re: Using relative names

2012-05-24 Thread Daniel Stenberg
On Thu, 24 May 2012, René Berber wrote: You are correct, now that I test again, I see it works on Linux but not on Windows, so its probably the lack of resolv.conf that makes things not work (under Cygwin). If I add resolv.conf to Cygwin, it works! Also on Windows but with a native program t

Re: [PATCH] Fix UDP and TCP port byte order in saved options.

2012-05-21 Thread Daniel Stenberg
On Mon, 21 May 2012, Nick Alcock wrote: The UDP and TCP port are stored in network byte order in the ares_channeldata, but are passed in to ares_init_options() in host byte order. Thus we must return them from ares_save_options() in host byte order too, or a duplicated channel will convert th

Re: Broken link on download page

2012-04-30 Thread Daniel Stenberg
On Mon, 30 Apr 2012, Anthony G. Basile wrote: The link on http://c-ares.haxx.se/download/ for c-ares 1.8.0 is incorrect. Oh, thanks. It was correct from the front page though! Fixed now. BTW, I'm maintaining c-ares for gentoo these days. Cool. Let us know if there's anything we should do t

RELEASE: c-ares 1.8.0

2012-04-27 Thread Daniel Stenberg
Hi! I'm happy to announce that I've just packaged and uploaded c-ares 1.8.0 and it is available at http://c-ares.haxx.se/ as usual. c-ares version 1.8.0 Changed: o Added ares_parse_naptr_reply() Fixed: o handle CNAME-only in ares_parse__reply() o support multiple DNS servers on Andr

Re: [PATCH] Makefile.m32: fix mingw32 build

2012-04-25 Thread Daniel Stenberg
On Wed, 25 Apr 2012, Ben Noordhuis wrote: Thanks for the patch, applied and pushed now! On a side note, can you guys start using GH pull requests? It's kind of annoying to have to subscribe to yet another mailing list, especially when it's a trivial patch like this. I strongly dislike github

Re: Integrating with libev

2012-04-23 Thread Daniel Stenberg
On Mon, 23 Apr 2012, Brian McFarland wrote: It looks like I can use the "ARES_OPT_SOCK_STATE_CB" to detect when I need to enable/disable my watchers (i.e. event listeners) for each socket. It also appears that ares_set_socket_callback can be used to detect when new sockets are created and in t

Re: problem with cross-compile install

2012-04-22 Thread Daniel Stenberg
On Sun, 22 Apr 2012, Guenter wrote: but its probably a good idea to always use 'lib' when cross-compiling ... anyone have some ideas? I agree with this. lib seems more conservative and less risk of being wrong. -- / daniel.haxx.se

release time?

2012-04-20 Thread Daniel Stenberg
Hi friends, If you have anything particular pending you want included in the next release, please speak up! If nothing major happens, I aim to make a new release eary next week. -- / daniel.haxx.se

Re: Patch for Android NDK build

2012-04-17 Thread Daniel Stenberg
On Tue, 17 Apr 2012, Guenter wrote: Thanks for the quick response in getting this fixed. I look forward to the next release! /me too, but that is Daniel's decision ... Yeah, I'm getting ripe for a release too but there's no rush as I see it. Peter Griess' patch seems to be a good idea to m

Re: missing INSTALL file

2012-04-16 Thread Daniel Stenberg
On Mon, 16 Apr 2012, Guenter wrote: I just found that we do not yet have an INSTALL file as we have with curl - what do you think about copying it over to c-ares? I think that most if not all in it applies to c-ares as well, and since we have now c-ares living as standalone project I believe i

<    1   2   3   4   5   >