Re: [PATCH] Cmake-ify c-ares -- v2

On Tue, 18 Oct 2016, Gregor Jasny wrote: Gregor, you can merge this yourself, can't you? I cannot see / find the merge button. Ah sorry, that was my mistake. I intended for you to have that ability. Check again now! -- / daniel.haxx.se

Re: [PATCH] Cmake-ify c-ares -- v2

On 17/10/2016 10:29, Daniel Stenberg wrote: > On Sun, 16 Oct 2016, Gregor Jasny via c-ares wrote: > >> I think this branch is mergeable. Any of the requested changes can be >> made with some small follow-up commits. > > Gregor, you can merge this yourself, can't you? I cannot see / find the

Re: [PATCH] Cmake-ify c-ares -- v2

On 11/10/2016 15:31, Brad House via c-ares wrote: > Any chance this pull request will be merged before too long? I don't like > letting things just hang around. I think this branch is mergeable. Any of the requested changes can be made with some small follow-up commits. Thanks, Gregor

Re: [PATCH] Cmake-ify c-ares -- v2

On 10/03/2016 02:03 PM, Brad House via c-ares wrote: > On 10/03/2016 05:23 AM, Gregor Jasny wrote: >> On 29/09/2016 21:34, Gregor Jasny wrote: >>> On 29/09/2016 14:34, David Drysdale wrote: Gregor / Daniel, did you have any thoughts on the CMake change? >>> >>> Yes, I'm reviewing it but

Re: [PATCH] Cmake-ify c-ares -- v2

On 10/03/2016 05:23 AM, Gregor Jasny wrote: > On 29/09/2016 21:34, Gregor Jasny wrote: >> On 29/09/2016 14:34, David Drysdale wrote: >>> >>> Gregor / Daniel, did you have any thoughts on the CMake change? >> >> Yes, I'm reviewing it but the CVE took most of my spare time. > > I think as soon as

Re: [PATCH] Cmake-ify c-ares -- v2

Hello, On 29/09/2016 21:34, Gregor Jasny wrote: > On 29/09/2016 14:34, David Drysdale wrote: >> >> Gregor / Daniel, did you have any thoughts on the CMake change? > > Yes, I'm reviewing it but the CVE took most of my spare time. I think as soon as the latest comments are addressed, the PR is

Re: [PATCH] Cmake-ify c-ares -- v2

On 9/30/16 3:05 PM, Daniel Stenberg wrote: On Fri, 30 Sep 2016, Brad House via c-ares wrote: Anyone have thoughts on this? It would mean less to maintain for sure with multiple build systems, with the caveat of it being hard to fix if it doesn't work in the future for some reason.

Re: [PATCH] Cmake-ify c-ares -- v2

On Fri, 30 Sep 2016, Brad House via c-ares wrote: Anyone have thoughts on this? It would mean less to maintain for sure with multiple build systems, with the caveat of it being hard to fix if it doesn't work in the future for some reason. Makefile.inc is made like this exactly to allow all

Re: [PATCH] Cmake-ify c-ares -- v2

Wow, impressive ... I think. Looks like voodoo to me :) Anyone have thoughts on this? It would mean less to maintain for sure with multiple build systems, with the caveat of it being hard to fix if it doesn't work in the future for some reason. -Brad On 09/30/2016 02:24 PM, bdoetsch wrote: >

Re: [PATCH] Cmake-ify c-ares -- v2

On Thu, Sep 29, 2016 at 12:14 PM, Brad House wrote: > On 9/28/16 9:19 AM, Brad House via c-ares wrote: >> >> On 9/28/16 7:40 AM, David Drysdale wrote: >>> >>> Any pull request will get run through Travis automatically [1], so you >>> shouldn't need a Travis account.

Re: [PATCH] Cmake-ify c-ares -- v2

On Wed, Sep 28, 2016 at 1:10 AM, Brad House via c-ares wrote: > On 9/27/16 9:52 AM, Gregor Jasny via c-ares wrote: >> >> Hi Brad, >> >> On 27/09/2016 13:44, Brad House via c-ares wrote: >>> >>> I've attached v2 of my CMake patch for c-ares. The changes are: >>> * Sync with

Re: [PATCH] Cmake-ify c-ares -- v2

On 9/28/16 7:40 AM, David Drysdale wrote: On Wed, Sep 28, 2016 at 1:09 AM, Brad House wrote: On 9/27/16 10:26 AM, David Drysdale via c-ares wrote: On Tue, Sep 27, 2016 at 2:52 PM, Gregor Jasny via c-ares wrote: Hi Brad, On 27/09/2016

Re: [PATCH] Cmake-ify c-ares -- v2

On Wed, Sep 28, 2016 at 1:09 AM, Brad House wrote: > On 9/27/16 10:26 AM, David Drysdale via c-ares wrote: >> >> On Tue, Sep 27, 2016 at 2:52 PM, Gregor Jasny via c-ares >> wrote: >>> >>> Hi Brad, >>> >>> On 27/09/2016 13:44, Brad House via

Re: [PATCH] Cmake-ify c-ares -- v2

On 9/27/16 9:52 AM, Gregor Jasny via c-ares wrote: Hi Brad, On 27/09/2016 13:44, Brad House via c-ares wrote: I've attached v2 of my CMake patch for c-ares. The changes are: * Sync with master (no configure-time type size checks) * Support iOS multi-arch building * Require only CMake v2.8

Re: [PATCH] Cmake-ify c-ares -- v2

On 9/27/16 10:26 AM, David Drysdale via c-ares wrote: On Tue, Sep 27, 2016 at 2:52 PM, Gregor Jasny via c-ares wrote: Hi Brad, On 27/09/2016 13:44, Brad House via c-ares wrote: I've attached v2 of my CMake patch for c-ares. The changes are: * Sync with master (no

Re: [PATCH] Cmake-ify c-ares -- v2

Just following up on a couple of points from last time round, plus a question for Daniel below. On Tue, Sep 27, 2016 at 12:44 PM, Brad House via c-ares wrote: > I've attached v2 of my CMake patch for c-ares. The changes are: [snip] - The CMake build seems to assume

Re: [PATCH] Cmake-ify c-ares -- v2

I've attached v2 of my CMake patch for c-ares. The changes are: * Sync with master (no configure-time type size checks) * Support iOS multi-arch building * Require only CMake v2.8 The main thing that still needs to be done is to build the tests, however I'm not seeing how to do that with

Re: [PATCH] Cmake-ify c-ares

I've just confirmed CMake 2.8 (tested 2.8.12.2 on Ubuntu 14.04) works fine, it doesn't appear I'm depending on any v3 features, so it is safe to reduce the minimum version. -Brad On 6/28/16 7:56 AM, Brad House via c-ares wrote: Commenting below ... On 6/28/16 6:42 AM, David Drysdale via

Re: [PATCH] Cmake-ify c-ares

Commenting below ... On 6/28/16 6:42 AM, David Drysdale via c-ares wrote: > Hi Brad, > > This seems to run pretty well -- as you say, it's vastly faster than > the ./configure variant! :) > My main concern would be that having 2 parallel build systems adds a > bit more friction to the