Re: Proposal for unittests

2013-04-29 Thread Patrick Valsecchi
On 04/28/2013 11:50 PM, Daniel Stenberg wrote: I think it is a fine direction indeed! I've never used 'CuTest' myself before and I've noticed that there's no package in Debian for it and it makes me a little concerned. I've never used it myself either. I'm more a C++ guy... No need of

Re: Proposal for unittests

2013-04-29 Thread Patrick Valsecchi
On 04/29/2013 08:42 AM, Marko Kreen wrote: On Mon, Apr 29, 2013 at 08:13:38AM +0200, Patrick Valsecchi wrote: No need of external dependency. That's the beauty of the thing. You just drop 3 files in the test directory (AllTests.c, CuTest.c, CuTest.h) and you're all set. I don't think a test

Re: Proposal for unittests

2013-04-29 Thread Guenter
Hi Daniel, Am 28.04.2013 23:50, schrieb Daniel Stenberg: I think it is a fine direction indeed! I've never used 'CuTest' myself before and I've noticed that there's no package in Debian for it and it makes me a little concerned. BTW libmetalink uses it too IIRC, but I've not yet tested with it

Re: Proposal for unittests

2013-04-28 Thread Daniel Stenberg
On Fri, 26 Apr 2013, Patrick Valsecchi wrote: In attachment, you'll find a small prototype of a unittest suite for c-ares. I didn't integrate it with the autotools stuff, since I don't know it (we use cmake). For the moment, it is only testing the ares_parse_txt_reply function. I've used

Re: Proposal for unittests

2013-04-28 Thread Daniel Stenberg
On Fri, 26 Apr 2013, Steinar H. Gunderson wrote: We have some unit tests internally; nothing complete, but maybe useful. They're written using Google Test (no surprise there :-) ) and not CuTest, though, so it means C++. Thanks for the offer, but I would really prefer us to not get C++

Proposal for unittests

2013-04-26 Thread Patrick Valsecchi
Hi, In attachment, you'll find a small prototype of a unittest suite for c-ares. I didn't integrate it with the autotools stuff, since I don't know it (we use cmake). For the moment, it is only testing the ares_parse_txt_reply function. I've used the simplest C testing framework I've found

Re: Proposal for unittests

2013-04-26 Thread Jakub Hrozek
On Fri, Apr 26, 2013 at 09:47:02AM +0200, Patrick Valsecchi wrote: Hi, In attachment, you'll find a small prototype of a unittest suite for c-ares. I didn't integrate it with the autotools stuff, since I don't know it (we use cmake). For the moment, it is only testing the

Re: Proposal for unittests

2013-04-26 Thread Steinar H. Gunderson
2013/4/26 Patrick Valsecchi pvals...@cisco.com: In attachment, you'll find a small prototype of a unittest suite for c-ares. I didn't integrate it with the autotools stuff, since I don't know it (we use cmake). For the moment, it is only testing the ares_parse_txt_reply function. We have some