Missing input validation on hostnames returned by DNS servers
=
Project c-ares Security Advisory, August 10, 2021 -
[Permalink](https://c-ares.haxx.se/adv_20210810.html)
VULNERABILITY
-
Missing input validation of host
for their efforts and contributions:
Anton Danielsson (@anton-danielsson)
Brad House (@bradh352)
Daniel Stenberg (@bagder)
Dhrumil Rana (@dhrumilrana)
František Dvořák (@valtri)
@halx99
Jay Freeman (@saurik)
Jean-pierre Cartal (@jeanpierrecartal)
Michael Kourlas
Philipp Jeitner
@vburdo
(11
On Wed, 6 Jan 2021, Brad House wrote:
Unfortunately I don't have that answer, I'd have to dig into the code to see
under what circumstances connections are torn down with
ARES_FLAG_STAY_OPEN. Considering UDP connections aren't actually
connection-based, I'd suspect the fds aren't closed
On Fri, 1 Jan 2021, Jeffrey Walton wrote:
We typically recommend end users exclude the live tests for this reason.
It's unfortunate Daniel turned this project over to someone less capable
than himself.
Jeff,
It would be more appropriate if you'd instead try to provide a solution or a
way
Hi,
As some of you noticed, the 1.17.0 release was slightly borked and there will
soon be a patch release made. Thanks for your understanding and cooperation!
--
/ daniel.haxx.se
lat Gaifullin (@bgaifullin)
Daniela Sonnenschein (@lxdicted)
Daniel Stenberg (@bagder)
David Hotham (@dimbleby)
Fionn Fitzmaurice (@fionn)
Gisle Vanem (@gavenm)
Ivan Baidakou (@basiliscos)
Jonathan Maye-Hobbs (@wheelpharoah)
Łukasz Marszał (@lmarszal)
lutianxiong (@ltx2018)
Seraph
On Fri, 31 Jul 2020, Brad House wrote:
We are doing OSX on travis but the other systems aren't available on travis.
They offer arm64, ppc64le and s390x in "alpha stage":
https://docs.travis-ci.com/user/multi-cpu-architectures/
--
/ daniel.haxx.se
On Sat, 18 Jul 2020, Brad House wrote:
I haven't yet analyzed your result. But I don't personally have problems
with accepting PRs that silence analyzer warnings, even if they are false
positives.
As long as such changes improve the project, I agree completely. However the
nature of false
On Sat, 18 Jul 2020, Jeffrey Walton wrote:
I'm testing on Fedora 32, which provides GCC 10.1. GCC 10 offers an
analyzer. You can engage the analyzer with -fanalyzer.
I didn't actually try to understand these exact issues but just want to
emphasize that these are still early days for the
On Sat, 18 Jul 2020, Jeffrey Walton wrote:
I was not sure what Daniel is aiming for - c89 or c99.
I always aimed for c89 to remain functional even for the most stubborn legacy
compilers, as that's where we draw the line for curl and I've always wanted
c-ares to be a viable option for curl
for the ares_getaddrinfo.3 man page
Thanks go to these friendly people for their efforts and contributions:
Brad House (@bradh352), Daniel Stenberg (@bagder), Dmitry Igrishin (@dmitigr),
Jann Horn, Shelly Vohr, Teemu R (@rytilahti)
(6 contributors)
References to bug reports and discussions
On Fri, 13 Mar 2020, Brad House wrote:
Any chance you could sync one more time. I fixed another man2html issue ...
As of now, the site pulls the source and git repos every hour and updates the
site accordingly.
--
/ daniel.haxx.se
On Fri, 13 Mar 2020, Brad House wrote:
Also, it seems that the man2html isn't honoring the .PP macro so things
don't render nicely. I committed a change for that just now but doesn't
explain why it pulled in an older man page that is wrong for the release.
And somehow after my latest commit
On Fri, 13 Mar 2020, Brad House wrote:
Hmm, the ares_getaddrinfo man pages didn't make it onto
https://c-ares.haxx.se/docs.html ... what's necessary to do that ?
I justed needed to update the git repo on the site and run make:
https://c-ares.haxx.se/ares_getaddrinfo.html
--
/
Thanks go to these friendly people for their efforts and contributions:
Abhishek Arya (@inferno-chromium), Adam Majer (@AdamMajer),
Andrew Selivanov (@ki11roy), Ben Noordhuis (@bnoordhuis),
Brad House (@bradh352), Christian Ammer (@ChristianAmmer), Dan Noé (@dnoe),
Daniel Stenberg (@bagder
On Thu, 8 Aug 2019, Nayanā Topolsky wrote:
I used stat64 function to check mtime and ctime and also size and ino values
in very similar way as it is done in libc.
stat(), or variations of it, should be fairly portable over many systems. (In
the curl project we do stat on basically *all*
On Tue, 23 Oct 2018, Brad House wrote:
What do we need to do to update the docs on c-ares.haxx.se?
Looks like there have been some changes that aren't live, then also missing
man pages like ares_library_init_android() and possibly others?
Is this auto-generated, or a semi-manual process?
Hi friends!
I'm happy to announce a fresh c-ares release. As always, get it from:
https://c-ares.haxx.se/
c-ares version 1.15.0
Changes:
o Add ares_init_options() configurability for path to resolv.conf file [1]
o Ability to exclude building of tools (adig, ahost, acountry) in CMake [3]
On Tue, 23 Oct 2018, Brad House wrote:
Ok, I've done some release prep. @Daniel Stenberg, want to verify and push?
On another note, I see a new PR https://github.com/c-ares/c-ares/pull/228
recently
came in, in the last 24hrs related to bug
https://github.com/c-ares/c-ares/issues/196
Looks
On Wed, 10 Oct 2018, Brad House wrote:
Its been about 8 months since our last release and I think we've accumulated
some good bugfixes that would justify a 1.14.1 release. There were a couple
of files missing for android in the 1.14.0 release tarball that would mean
it couldn't be used on
On Wed, 4 Jul 2018, Basil 2 wrote:
First: welcome, and thanks for considering contributing to the c-ares project!
I am going to implement CNAME redirection for TXT-type records. Which rules
should I follow for this?
Should I make a separate branch?
You should fork the github repo, create a
, Daniel Stenberg, David Drysdale, David Hotham, Felix Yan,
Gergely Nagy, Gregor Jasny, Jakub Hrozek, John Schember,
Konstantinos Sofokleous, Roman Teterin, Sergey Kolomenkin, Sheel Bedi,
(18 contributors)
References to bug reports and discussions on issues:
[1] = https://github.com/c-ares/c
On Fri, 16 Feb 2018, Brad House wrote:
I think I'm done for this release. I just tied in the new CMake tests into
travis and those seem to be working.
Did you force-push that? My RELEASE-NOTES changes from this morning are gone
now!
--
/ daniel.haxx.se
Hi team,
I would like to propose a stricter approach on how to write commit messages in
this project. I'm personally very happy with the format we use in the curl
project and that's where the template below comes from.
The primary principle is that the first line should better explain for
On Wed, 14 Feb 2018, Brad House wrote:
Ok, I've updated RELEASE-NOTES if someone wants to look it over to make sure
I complied with the current format.
That said, I'd still like to get PR#168 done for the release, I think I
provided Gregor the necessary info.
Thanks!
I added a few small
On Fri, 9 Feb 2018, Brad House wrote:
Any thoughts on actually pushing out a new release?
I'm up for it. I can do the necessary tricks to push it out the door and
upload it to the site etc.
How about we do it on February 15 to give everyone a few extra days to check
and polish things up?
On Mon, 5 Feb 2018, David Hotham wrote:
I notice that while you are saying that you don't consider yourself senior
enough to make such decisions, Daniel has expressed his hope that others
will step up... it seems to me that we have a square peg and a square hole
here! If you and the other
Hi friends!
I would like us to start requiring members and collaborators of the c-ares
organization and repos to have two-factor authentication (2FA) enabled on
github.
This of course to indirectly enhance the security of the project and repos
themselves by reducing attack risks.
Many
Hi,
I think this newly submitted pull request by Christian Ammer is worth some
extra attention (this function/feature has been requested multiple times in
the past) so I'm forwarding this to the list.
--- snip ---
Currently AF_UNSPEC is not well supported by ares. This Pull Request is a
On Tue, 14 Mar 2017, David Drysdale via c-ares wrote:
Actually, a pull request might be helpful -- that way we get to see the
results of a few build combinations on Travis.
Ah yes, good point!
I've also offered Brad to get push rights to the repo, as he's been around
this project for a long
On Tue, 18 Oct 2016, Gregor Jasny wrote:
Gregor, you can merge this yourself, can't you?
I cannot see / find the merge button.
Ah sorry, that was my mistake. I intended for you to have that ability. Check
again now!
--
/ daniel.haxx.se
On Sun, 16 Oct 2016, bch wrote:
I read it, and it's incredibly interesting. I sure hope there's follow up
material for this...
The (little) public info from Google on this issue was posted here:
https://googlechromereleases.blogspot.se/2016/09/stable-channel-updates-for-chrome-os.html
On Fri, 30 Sep 2016, Brad House via c-ares wrote:
Anyone have thoughts on this? It would mean less to maintain for sure with
multiple build systems, with the caveat of it being hard to fix if it
doesn't work in the future for some reason.
Makefile.inc is made like this exactly to allow all
On Tue, 27 Sep 2016, David Drysdale via c-ares wrote:
That made me think. Do you think we should bump the version number for the
pending release to 1.12.0 because of this new ARES_OPT_NOROTATE value?
That probably makes sense -- I think the change is generally
back-compatible, but there is a
Hey,
News on the web site as of today:
I made a single changelog page and concatenated all release-notes since 1.4.0
into that so that we have a single page that is easier to search:
https://c-ares.haxx.se/changelog.html
For the sake of better visibility, I also created a new page to more
On Mon, 26 Sep 2016, David Drysdale wrote:
I've pushed a commit with that change in it, so hopefully things should work
for you now...
Thanks David, that's awesome. Works perfectly fine now!
--
/ daniel.haxx.se
On Fri, 23 Sep 2016, David Drysdale wrote:
I can't reproduce the problem, so could you try doing a non-valgrind debug
build and seeing what pops out in the debugger (e.g. libtool --mode=execute
gdb ./arestest)? The stack makes it look like a null pointer is being
passed down, only it's for a
On Sun, 25 Sep 2016, Brad House wrote:
What other systems end up requiring a double-compile due to this?
Most *nix* systems can build applications either 32bit or 64bit. And while I
beleve most differences in 32 vs 64 bit builds can be found in the data size
checks (that your patch removes)
On Sun, 25 Sep 2016, Brad House wrote:
I should also-recap the GOAL of the patch. The goal is for MacOSX and iOS
to allow multi-arch building.
Right, and I'm looking beyond MacOSX and I want to completely remove the need
to double compile for *all* systems. And the safest way to really make
On Sun, 25 Sep 2016, Brad House wrote:
The *type* detection was not modified in any way what-so-ever by my patch
set.
That's what I'm saying. And until we introduce a way to figure out that type
in the public header, we can't remove the build-time generation of the header.
So yes, we can
On Sat, 24 Sep 2016, Brad House wrote:
The 'ares_socklen_t' seems to be a particular problem in the current
ares_build.h file that sticks out. How does your suggested replacement look
for that that?
Can you elaborate? CARES_SIZEOF_ARES_SOCKLEN_T was completely unused by any
logic
On Fri, 23 Sep 2016, Brad House wrote:
As far as I'm aware it was complete,
Sorry, but this quote from your email on September 1st:
"The exceptions that needed fixing are NS_IN6ADDRSZ, NS_INADDRSZ, and
CARES_MASK_{SHORT,USHORT,SINT,UINT,SLONG,ULONG} (which basically all systems
should have
On Fri, 23 Sep 2016, Brad House via c-ares wrote:
I'd like to re-open the discussion of the last patch I sent via this mailing
list: "[PATCH] remove configure-time type size checks"
This fixes multi-arch building for iOS and MacOSX (without requiring
separate builds and using lipo to join
Hello!
I think it is about time to bring the band back together and do another c-ares
release! I don't have a date just yet, this is just a wake-up call.
So, if you have stuff to merge before we ship anything please bring it back up
on the table and let's see what we can do.
There are
On Fri, 23 Sep 2016, David Drysdale wrote:
Is that just with valgrind, or are there problems with a normal run too?
Ah sorry for being unclear: no it crashes in normal runs as well which is why
I decided to try valgrind on it to see what it says.
When I run 'make test' the end of my
Hey,
As I'm currently fiddling with some c-ares functions I figured I should get
the tests running properly to allow me to verify my pending changes.
I built c-ares with the tests enabled, only to figure out that 'make test'
ends up in a segfault with the current git master!
If I manually
On Mon, 12 Sep 2016, Brad House wrote:
So, is this patch being rejected then?
I've not seen anyone reject it, so I'd say no it isn't. It's just not being
handled (yet).
I'm sorry for that, but we seem to have a shortage of developers with energy
and time to spend on c-ares. There has
Hi!
As another step towards reaching "100% CII best practices", I've just pushed a
suggested "security process" for the c-ares project to the git repo. You can
view it easily here: https://github.com/c-ares/c-ares/blob/master/SECURITY.md
The document is a blatant rip-off from the one we use
Hey friends,
I finally got my act together and enabled HTTPS for the c-ares web site. I
intend to redirect all traffic from HTTP to HTTPS unconditionally within a day
or two.
I also created an entry for c-ares in the CII best practices project and
started to fill in data for it:
FYI
Wget is now another project (optionally) using c-ares since this commit:
http://git.savannah.gnu.org/cgit/wget.git/commit/?id=76ef65b23cc8b315f9
--
/ daniel.haxx.se
On Fri, 11 Mar 2016, Brad House wrote:
Anyone know why this change was made or if it was intentional? The solution
is to replace XC_LIBTOOL with LT_INIT in configure.ac, but I'm not exactly
what XC_LIBTOOL provides over LT_INIT and why that change was made. Since
LT_INIT isn't in
On Thu, 18 Feb 2016, Avi Kivity wrote:
My intent was on not requiring recompilation or ifdefs, so a single shared
library can work for both the standard socket API and user-space TCP/IP
stacks. I somehow missed that ares_socket_t is a public type :(.
So instead of this, I'd make a new
On Wed, 17 Feb 2016, Avi Kivity wrote:
Hello!
1. make ares_socket_t a struct wrapping either an int or a WIN32 SOCKET
type; any operations on ares_socket_t (close, sendmsg, etc.) will be
forwarded to helper functions that extract the fd and call the library
function; for example
int
On Wed, 17 Feb 2016, Gregor Jasny wrote:
The build bots seem to like the release. All green:
https://buildd.debian.org/status/package.php?p=c-ares=experimental
Thank you for running this Gregor! Then we're still on schedule for a Friday
release.
--
/ daniel.haxx.se
On Thu, 11 Feb 2016, Daniel Stenberg wrote:
Good idea! It made me realize the test suite isn't bundled in the dist
archive so I'll just fix that first...
Okay, here we go:
http://c-ares.haxx.se/daily-snapshot/c-ares-1.11.0-rc1.tar.gz
This is also tagged in git as "cares-1_11_
On Thu, 11 Feb 2016, David Drysdale wrote:
I kind of assumed you wouldn't want to distribute the test suite; OTOH
verifying an install with it would be helpful.
Yes, I generally believe in shipping "everything" so that tarball users can do
virtually all the same things as git users can. And
On Mon, 1 Feb 2016, Fedor Indutny wrote:
I have made fixes to the patch from 2015-03-21, according to your comments.
Please take a look.
Two comments from me:
1. Please don't refer to source code file names in ares.h. That's a public
header file and users of c-ares will read that and have
On Thu, 28 Jan 2016, Fedor Indutny wrote:
Just FYI, this `age` thing was actually suggested by you earlier in this
thread, but I will be more than happy to remove it.
I know, and I'm sorry I lead you down that path! :-(
--
/ daniel.haxx.se
On Mon, 18 Jan 2016, dan...@poradnik-webmastera.com wrote:
Integration of epoll with c-ares is a bit problematic, because
current version misses some functionality.
I'd agree that it is less than ideal, but as I've most likely said here
before: I've built libcurl's event-based API and it can
On Sun, 17 Jan 2016, Brad House wrote:
I also ran across this patch which may be useful when not using select() or
poll() to monitor the file descriptors, but rather epoll() in EPOLLET mode
(Edge Triggered), or using FreeBSD kqueue()'s which are always edge
triggered:
On Thu, 14 Jan 2016, David Drysdale wrote:
Also, does acountry still work for you? I get "Could not contact DNS
servers" ...
Works for me:
$ ./acountry c-ares.haxx.se
Sweden (se), number 752.
--
/ daniel.haxx.se
On Sat, 9 Jan 2016, Gregor Jasny wrote:
Would it make sense to create a new release?
Yes it would!
There have been a bunch of patches flying around that I personally haven't
paid much attention to. Is there anything important we should make sure to get
done before we ship ?
--
/
On Wed, 25 Nov 2015, David Drysdale wrote:
- Fix double-free from ares__read_line() failure case
https://github.com/daviddrysdale/c-ares/commit/d91d731636f5
+1
- Extend the injection of malloc/free to cover realloc too:
https://github.com/daviddrysdale/c-ares/commit/492a1cc5e4fa
This
On Thu, 22 Oct 2015, David Drysdale wrote:
By the way, I should observe that so far I've only seen one thing that might
count as a bug, even running with sanitizers/fuzzers etc -- so kudos for the
quality of the code!
Cool!
That one thing is in this change:
On Fri, 9 Oct 2015, David Drysdale wrote:
I've made a start on a unit test suite for c-ares, and I'd be interested in
any feedback.
In one word? AWESOME.
I'm not a big C++ guy myself so I'm not overly thrilled with that choice, but
I'm also much more *for* progress than letting my personal
On Mon, 20 Jul 2015, Paul Oliver wrote:
https://github.com/bagder/c-ares/blob/bba4dc573f5c31b0145d09aa2c245e94896cf1df/ares_init.c#L1908
.
What's RANDOM_FILE in your case? That function does look a bit fishy and
possible to improve.
/dev/urandom (on OSX)
Any suggestion on how to fix
On Fri, 26 Jun 2015, Peter Pentchev wrote:
if a project supports a separation between CPPFLAGS and CFLAGS, then -I, -U,
-D and friends should indeed be passed in CPPFLAGS.
I'm bound to agree. I would like a stronger use case that really cannot adapt
to that rule before loosening our checks.
On Thu, 26 Mar 2015, massimo dragano wrote:
Can you give us a recipe how to repeat this? Which version are you using?
--
/ daniel.haxx.se
On Thu, 26 Mar 2015, massimo dragano wrote:
Program received signal SIGSEGV, Segmentation fault.
Same here, can you please tell us how to repeat this?
--
/ daniel.haxx.se
On Thu, 29 Jan 2015, Ramasamy, Vasanthakumari wrote:
I would like to know whether there are plans to use getaddrinfo() instead of
gethostbyname() in c-ares.
Feel free to take the lead on this.
--
/ daniel.haxx.se
On Thu, 22 Jan 2015, Daniel Hardman wrote:
I would love to switch to an epoll-style approach. I found one interaction
between Daniel S and someone else on this forum, where this was discussed.
Daniel said he had added ares_getsock() to support just such a use case.
However, ares_getsock()
On Thu, 30 Oct 2014, Vinay Kumar wrote:
I am using 'c-ares' library in our application. We have used 'getaddrinfo'
in many places. Is there any equivalent function called 'ares_getaddrinfo'?
Because 'ares_nameinfo.pdf' contains 'ares_getaddrinfo' in SEE ALSO section.
If 'ares_getaddrinfo' is
On Sun, 7 Sep 2014, Arif Ali wrote:
I searched for ares_build.h and did not find this file instead I found
ares_build.h.in
ares_build.h.dist
You can copy ares_build.h.dist to ares_build.h to get a file that is usually
provided in the tarballs.
What is CONFIGURE CAPABLE ?
configure is a
On Fri, 25 Jul 2014, David Drysdale wrote:
Pushed. Hopefully it might help a bit.
Speaking of that, we have three old pull requests pending:
https://github.com/bagder/c-ares/pulls
--
/ daniel.haxx.se
On Thu, 22 May 2014, Fedor Indutny wrote:
Unfortunately, there is no certain description of how TXT records should be
used after parsing. Clearly some people may want to get each chunk of each
record separately and use them as they want to. Concatenation will
definitely make c-ares unusable
On Thu, 22 May 2014, Jakub Hrozek wrote:
The updated code change looks OK to me (but I've not actually exercised the
new arm).
Daniel, is it OK if I push this patch?
No need to ask me for permission. I trust you and your judgement, and if
there's more people giving their thumbs up I think
Hello,
It's been a very long time since I last mentioned this but I want to repeat
that for me, c-ares is not a top priority project and it hasn't been for
years.
To get your patches merged into c-ares I *strongly* urge you to get someone
else than me to (also) review and vouch for your
On Wed, 6 Nov 2013, Jakub Hrozek wrote:
Maybe you could also include libverto. It's relatively new event loop
library that encapsulates other event loop approaches as back ends. It's
being used by MIT Kerberos and GSS-Proxy among others.
I would say that the most sensible thing for a library
On Thu, 5 Sep 2013, Fred Huang wrote:
the code should focus on saving memory for large volumes users. Low volume
users will have no pressure on the memory or performance.
Uh? And in which way then do you think leaving the default or lowering them
change the memory requirements for large
On Fri, 30 Aug 2013, Tor Arntsen wrote:
Curl autobuilds using --enable-ares have been broken for some days due to
CARES_SIZE_LONG which has been removed but still referenced in ares_rules.h
A possible fix is attached (just removes expected existence of
CARES_SIZEOF_LONG from ares_rules.h)
On Tue, 27 Aug 2013, Daniel Stenberg wrote:
If they all support limits.h *or* have 32 bit longs...
I've pushed my solution now!
--
/ daniel.haxx.se
on limits.h which is POSIX ? See my attachment for
a fix I belive can work.
--
/ daniel.haxx.seFrom f19387dd7243239f2f393220ba375b64f06731ed Mon Sep 17 00:00:00 2001
From: Daniel Stenberg dan...@haxx.se
Date: Tue, 27 Aug 2013 13:36:41 +0200
Subject: [PATCH] nowarn: use limits.h instead of configure
On Tue, 27 Aug 2013, Jakub Hrozek wrote:
If all platforms the upstream is interested in support limits.h (even those
funky HP-UX etc), then this should work, yes.
If they all support limits.h *or* have 32 bit longs...
--
/ daniel.haxx.se
On Mon, 26 Aug 2013, Jakub Hrozek wrote:
I have a problem using c-ares in a multilib environment, for which I found
a patch in Fedora that does not seem to have found its way upstream.
I actually sent the patch upstream:
http://c-ares.haxx.se/mail/c-ares-archive-2010-06/0009.shtml
After
On Wed, 31 Jul 2013, Mark Delany wrote:
My implementation is a platform-specific hack, so it's not even suitable as
an offering.
One could perhaps imagine a new function that would return enough information
for the application to know what to check for updates? and/or a function that
does
On Tue, 25 Jun 2013, Maxim Ruban wrote:
Patch is in attach (pl. let me know if something wrong with it - I've made
it by TortoiseCVS on Windows, and don't know if it's compatible with
Unix-family tools).
Please, review it and improve if neccessary.
I'm very interested in +1s or other
On Wed, 1 May 2013, Alex Loukissas wrote:
Since I figured out the issue, I thought I'd share the patch with you. Feel
free to use it.
Thanks, merged and pushed!
--
/ daniel.haxx.se
On Thu, 2 May 2013, Patrick Valsecchi wrote:
A colleague ran Coverity (a static analysis tool) against c-ares and fixed a
few reported errors and warnings.
Please have a look at the attached patch.
Thanks!
There's a large amount of added typecasts for malloc() and a few other void
On Fri, 26 Apr 2013, Patrick Valsecchi wrote:
In attachment, you'll find a small prototype of a unittest suite for c-ares.
I didn't integrate it with the autotools stuff, since I don't know it (we
use cmake). For the moment, it is only testing the ares_parse_txt_reply
function.
I've used
On Fri, 26 Apr 2013, Steinar H. Gunderson wrote:
We have some unit tests internally; nothing complete, but maybe useful.
They're written using Google Test (no surprise there :-) ) and not CuTest,
though, so it means C++.
Thanks for the offer, but I would really prefer us to not get C++
On Tue, 23 Apr 2013, Bert Belder wrote:
As a Node.js maintainer I also ran into this problem. Our solution was to
ignore these fec0:: servers entirely
(https://github.com/piscisaureus/cares/commit/f6cdd7d404d44eb2d6e8866e85ae65
1b89fc769e), and we've never had any complaints about it. I think
On Tue, 23 Apr 2013, Jakub Hrozek wrote:
Are there any plans to bump the soname to reflect the API additions?
Done!
--
/ daniel.haxx.se
On Mon, 22 Apr 2013, Jakub Hrozek wrote:
I implemented the first version of the SRV parsing and I must confess I no
longer remember why the additional record was not parsed, sorry.
I'm sure a patch would be welcome.
Oh indeed. Sounds like an excellent idea to me!
--
/ daniel.haxx.se
On Mon, 15 Apr 2013, Patrick Valsecchi wrote:
2) change ares_parse_txt_reply to return another ares_txt_reply
node for each sub-string.
IMHO, I think this is the right approach. Possibly it's bad changing
behavior of that public function... But I wonder how many actually use the
On Mon, 15 Apr 2013, Patrick Valsecchi wrote:
In attachment, you find a patch against the current git that includes yours
and the fixes for the other problems. I tested against my feature tests on
Linux, but I use only parsing of PTR, SRV and TXT.
I pushed the commit 148c8e0353d93d7c0 now.
On Mon, 15 Apr 2013, Patrick Valsecchi wrote:
While I'm writing to this mailing list, I've seen some discussions in the
archives about doing an implementation for mDNS. What is the status on that?
I'm not aware of anyone working on that!
--
/ daniel.haxx.se
FYI
--
/ daniel.haxx.se
-- Forwarded message --
Date: Wed, 10 Apr 2013 05:43:07
From: psaab notificati...@github.com
To: bagder/c-ares c-a...@noreply.github.com
Subject: [c-ares] Really fix memory leak when parsing replies. (#10)
bffd67f16a8f42fe6dbf79ab2e39d92eea05c8a6
On Mon, 8 Apr 2013, Alexander Klauer wrote:
An invocation of ares_cancel() walks through the request list, calling
the callbacks of all pending requests on a channel.
Thanks a lot. Your mini-series has been merged and pushed!
--
/ daniel.haxx.se
On Thu, 21 Mar 2013, Alexander Klauer wrote:
Implementation-wise, I think I would just swap the list head in the ares
channel with an empty list head on the stack, and then start walking through
the list with the list head on the stack. Any new requests would then be
added to the now
On Tue, 19 Feb 2013, Yang Tse wrote:
socklen_t in a public header file is potentially problematic.. there used
to be one in curl/curl.h until 7.18 I think, but it got too troublesome
to maintain so it got removed.
When it was mentioned if ares_inet_ntop and ares_inet_ntop were to become
1 - 100 of 218 matches
Mail list logo