Re: [PATCH] Cmake-ify c-ares -- v2

2016-09-27 Thread Gregor Jasny via c-ares
Hi Brad, On 27/09/2016 13:44, Brad House via c-ares wrote: > I've attached v2 of my CMake patch for c-ares. The changes are: > * Sync with master (no configure-time type size checks) > * Support iOS multi-arch building > * Require only CMake v2.8 > > The main thing that still needs to be done

Re: [PATCH] Cmake-ify c-ares -- v2

2016-09-29 Thread Gregor Jasny via c-ares
On 29/09/2016 14:34, David Drysdale wrote: > On Wed, Sep 28, 2016 at 1:10 AM, Brad House via c-ares >> https://github.com/c-ares/c-ares/pull/64 >> >> -Brad > > Gregor / Daniel, did you have any thoughts on the CMake change? Yes, I'm reviewing it but the CVE took most of my spare time. -Gregor

Re: [PATCH] Cmake-ify c-ares -- v2

2016-10-03 Thread Gregor Jasny via c-ares
Hello, On 29/09/2016 21:34, Gregor Jasny wrote: > On 29/09/2016 14:34, David Drysdale wrote: >> >> Gregor / Daniel, did you have any thoughts on the CMake change? > > Yes, I'm reviewing it but the CVE took most of my spare time. I think as soon as the latest comments are addressed, the PR is goo

Re: [PATCH] Cmake-ify c-ares -- v2

2016-10-16 Thread Gregor Jasny via c-ares
On 11/10/2016 15:31, Brad House via c-ares wrote: > Any chance this pull request will be merged before too long? I don't like > letting things just hang around. I think this branch is mergeable. Any of the requested changes can be made with some small follow-up commits. Thanks, Gregor

Re: [PATCH] Cmake-ify c-ares -- v2

2016-10-18 Thread Gregor Jasny via c-ares
On 17/10/2016 10:29, Daniel Stenberg wrote: > On Sun, 16 Oct 2016, Gregor Jasny via c-ares wrote: > >> I think this branch is mergeable. Any of the requested changes can be >> made with some small follow-up commits. > > Gregor, you can merge this yourself, can't

Re: CMake modernization

2017-01-04 Thread Gregor Jasny via c-ares
Hello, On 03/01/2017 19:29, Stephen Sorley wrote: Just submitted a PR for c-ares' CMake build system, pinging the list as requested by the contributor instructions. Here's the link: https://github.com/c-ares/c-ares/pull/77 The proposed patch explicitly sets the minimum version to 2.8.12 (the