rleigh-codelibre commented on pull request #2:
URL: https://github.com/apache/xerces-c/pull/2#issuecomment-647028400
If all the work is individual and there is no corporate ownership of any of
it, then if you both submit the needed ICLA that should be sufficient. Thanks.
rleigh-codelibre commented on a change in pull request #2:
URL: https://github.com/apache/xerces-c/pull/2#discussion_r443149185
##
File path: CMakeLists.txt
##
@@ -177,8 +177,14 @@ install(
# Process subdirectories
add_subdirectory(doc)
add_subdirectory(src)
viniul edited a comment on pull request #2:
URL: https://github.com/apache/xerces-c/pull/2#issuecomment-646989210
@rleigh-codelibre We have not yet submitted the Apache licensing agreement -
this is individual work by me and @bshastry, so I think if we both submit the
ICLA this should be
viniul commented on pull request #2:
URL: https://github.com/apache/xerces-c/pull/2#issuecomment-646989210
@rleigh-codelibre We have not yet submitted the Apache licensing agreement -
this is individual work by me and @bshastry, so I think if we both submit the
ICLA this should be
viniul commented on a change in pull request #2:
URL: https://github.com/apache/xerces-c/pull/2#discussion_r443127661
##
File path: CMakeLists.txt
##
@@ -177,8 +177,14 @@ install(
# Process subdirectories
add_subdirectory(doc)
add_subdirectory(src)
-add_subdirectory(tests)
viniul commented on a change in pull request #2:
URL: https://github.com/apache/xerces-c/pull/2#discussion_r443127695
##
File path: CMakeLists.txt
##
@@ -177,8 +177,14 @@ install(
# Process subdirectories
add_subdirectory(doc)
add_subdirectory(src)
-add_subdirectory(tests)
viniul commented on a change in pull request #2:
URL: https://github.com/apache/xerces-c/pull/2#discussion_r443127487
##
File path: CMakeLists.txt
##
@@ -177,8 +177,14 @@ install(
# Process subdirectories
add_subdirectory(doc)
add_subdirectory(src)
-add_subdirectory(tests)
viniul commented on a change in pull request #2:
URL: https://github.com/apache/xerces-c/pull/2#discussion_r443127356
##
File path: build_fuzzer.sh
##
@@ -0,0 +1,8 @@
+#!/bin/bash
Review comment:
Not necessarily needed, but I thought it might be helpful if someone
rleigh-codelibre commented on pull request #2:
URL: https://github.com/apache/xerces-c/pull/2#issuecomment-646988406
@viniul I have done a preliminary review, please see the above comments.
Please could you also answer the question regarding the licensing. I see
Google copyrights
viniul commented on pull request #2:
URL: https://github.com/apache/xerces-c/pull/2#issuecomment-646988283
@rleigh-codelibre Thank you very much for reviewing this PR. I will
implement the suggested changes and open a new PR based on the current master.
rleigh-codelibre commented on a change in pull request #2:
URL: https://github.com/apache/xerces-c/pull/2#discussion_r443126284
##
File path: .gitignore
##
@@ -105,3 +105,6 @@ tests/scripts/*.log
tests/scripts/*.trs
tests/test-suite.log
Testing/
+
+# Vincent
+build/
Review
viniul commented on pull request #2:
URL: https://github.com/apache/xerces-c/pull/2#issuecomment-646984925
@rleigh-codelibre I updated the PR to also includes the changes for CMake.
Is this sufficient to get the PR merge dfor now? I f so, let me create a new
clean PR based on the currnet
viniul edited a comment on pull request #2:
URL: https://github.com/apache/xerces-c/pull/2#issuecomment-646984925
@rleigh-codelibre I updated the PR to also includes the changes for CMake.
Is this sufficient to get the PR merge dfor now? I f so, let me create a new
clean PR based on the
rleigh-codelibre commented on pull request #2:
URL: https://github.com/apache/xerces-c/pull/2#issuecomment-646975989
@viniul The addition of a test looks fairly low-risk in terms of wider
impact on the project.
Has the necessary Apache ICLA and/or company CLA been done?
On
viniul commented on pull request #2:
URL: https://github.com/apache/xerces-c/pull/2#issuecomment-646973122
CC @rleigh-codelibre As described above, this PR adds some fuzzing harnesses
for xerces, which we (@bshastry and me) think would be nice to have in the
master branch, because it
I moved all the issues using version 3.3.0 to version 4.0.0.
I don't have Jira admin access, so I can't delete the 3.3.0 release
version, which is no longer in use.
Roger
[
https://issues.apache.org/jira/browse/XERCESC-2141?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Roger Leigh updated XERCESC-2141:
-
Fix Version/s: (was: 3.3.0)
4.0.0
> Enable C++11/14/17 with autoconf
[
https://issues.apache.org/jira/browse/XERCESC-2202?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Roger Leigh updated XERCESC-2202:
-
Fix Version/s: (was: 3.3.0)
4.0.0
> Update version of master branch to
[
https://issues.apache.org/jira/browse/XERCESC-2201?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Roger Leigh updated XERCESC-2201:
-
Fix Version/s: (was: 3.3.0)
4.0.0
> Update Travis-CI image in use
>
[
https://issues.apache.org/jira/browse/XERCESC-2200?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Roger Leigh updated XERCESC-2200:
-
Fix Version/s: (was: 3.3.0)
4.0.0
> Update AppVeyor image in use
>
[
https://issues.apache.org/jira/browse/XERCESC-2203?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Roger Leigh updated XERCESC-2203:
-
Fix Version/s: (was: 3.3.0)
4.0.0
> MingGW time functions are broken
>
[
https://issues.apache.org/jira/browse/XERCESC-2210?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Roger Leigh updated XERCESC-2210:
-
Fix Version/s: (was: 3.3.0)
4.0.0
> Remove
[
https://issues.apache.org/jira/browse/XERCESC-2208?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Roger Leigh updated XERCESC-2208:
-
Fix Version/s: (was: 3.3.0)
4.0.0
> Rationalise XercesIntTypes
>
[
https://issues.apache.org/jira/browse/XERCESC-2205?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Roger Leigh updated XERCESC-2205:
-
Fix Version/s: (was: 3.3.0)
4.0.0
> Require std::mutex and std::thread
[
https://issues.apache.org/jira/browse/XERCESC-2207?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Roger Leigh updated XERCESC-2207:
-
Fix Version/s: (was: 3.3.0)
4.0.0
> Rationalise network accessors
>
25 matches
Mail list logo
