Re: [PR] XERCESC-2208: XMLSize_t size_t revert [xerces-c]

2024-05-22 Thread via GitHub
boris-kolpackov commented on PR #41: URL: https://github.com/apache/xerces-c/pull/41#issuecomment-2124857712 > ... in `src/xalanc/...` Hm, this seems to be about Xalan, not Xerces-C? -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] XERCESC-2208: XMLSize_t size_t revert [xerces-c]

2024-05-22 Thread via GitHub
Tyrben commented on PR #41: URL: https://github.com/apache/xerces-c/pull/41#issuecomment-2124463834 There is still one reference to type `XMLSSize_t` in _src/xalanc/Include/PlatformDefinitions.hpp.in_ l.123 -- This is an automated message from the Apache Git Service. To respond to

[PR] cmake: use enumerations for possible values, so that cmake-gui offersa drop-down selection [xerces-c]

2024-04-10 Thread via GitHub
dilyanpalauzov opened a new pull request, #57: URL: https://github.com/apache/xerces-c/pull/57 I have read on https://xerces.apache.org/xerces-c/source-repository.html that Jira.apache is the preferred way for submitting changesets, but it is unclear how long getting an account there will

[PR] Fix improper check for `mbrlen`/`mblen`, to deal with the configuration failure for Android below API level 26 [xerces-c]

2024-04-08 Thread via GitHub
zjyhjqs opened a new pull request, #56: URL: https://github.com/apache/xerces-c/pull/56 (I know this is not a GitHub project. But my application for JIRA account hasn't been replied yet.) The usage place (`IconvLCPTranscoder::calcRequiredSize`) will check the existence of `::mbrlen`

Re: [PR] autotools: Add ws2_32 library for Windows platform [xerces-c]

2024-02-20 Thread via GitHub
Biswa96 closed pull request #50: autotools: Add ws2_32 library for Windows platform URL: https://github.com/apache/xerces-c/pull/50 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Update version.rc.cmake.in [xerces-c]

2024-01-08 Thread via GitHub
scantor commented on PR #55: URL: https://github.com/apache/xerces-c/pull/55#issuecomment-1881018330 This isn't a GitHub project, if you want patches considered, file issues at https://issues.apache.org -- This is an automated message from the Apache Git Service. To respond to the

[PR] Update version.rc.cmake.in [xerces-c]

2024-01-08 Thread via GitHub
ssattl opened a new pull request, #55: URL: https://github.com/apache/xerces-c/pull/55 The code page for translation must be set to Unicode instead of EN-US like in rc block. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] [XERCESC-2188] Fix potential double-free in usage of ReaderMgr::pushReader() [xerces-c]

2023-12-13 Thread via GitHub
boris-kolpackov closed pull request #47: [XERCESC-2188] Fix potential double-free in usage of ReaderMgr::pushReader() URL: https://github.com/apache/xerces-c/pull/47 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] [XERCESC-2188] Fix potential double-free in usage of ReaderMgr::pushReader() [xerces-c]

2023-12-13 Thread via GitHub
boris-kolpackov commented on PR #47: URL: https://github.com/apache/xerces-c/pull/47#issuecomment-1853495327 PR #54 has been merged: `master`: https://github.com/apache/xerces-c/commit/b38ab79e934b9c27de191ee7af6926c7af42069d `xerces-3.2`:

Re: [PR] XERCESC-2188 - Use-after-free on external DTD scan [xerces-c]

2023-12-13 Thread via GitHub
boris-kolpackov closed pull request #54: XERCESC-2188 - Use-after-free on external DTD scan URL: https://github.com/apache/xerces-c/pull/54 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] XERCESC-2188 - Use-after-free on external DTD scan [xerces-c]

2023-12-13 Thread via GitHub
boris-kolpackov commented on PR #54: URL: https://github.com/apache/xerces-c/pull/54#issuecomment-1853490361 This PR has been merged (with whitespace issues addressed): `master`: https://github.com/apache/xerces-c/commit/b38ab79e934b9c27de191ee7af6926c7af42069d `xerces-3.2`:

Re: [PR] build: Install XercesMessages_en_US.cat to /usr/share/xerces-c/msg [xerces-c]

2023-12-08 Thread via GitHub
boris-kolpackov closed pull request #7: build: Install XercesMessages_en_US.cat to /usr/share/xerces-c/msg URL: https://github.com/apache/xerces-c/pull/7 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] build: Install XercesMessages_en_US.cat to /usr/share/xerces-c/msg [xerces-c]

2023-12-08 Thread via GitHub
boris-kolpackov commented on PR #7: URL: https://github.com/apache/xerces-c/pull/7#issuecomment-1846909947 I am closing this per the above comment. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] build: Install XercesMessages_en_US.cat to /usr/share/xerces-c/msg [xerces-c]

2023-12-06 Thread via GitHub
scantor commented on PR #7: URL: https://github.com/apache/xerces-c/pull/7#issuecomment-1843295992 I applied the patch directly as I cannot do that with GitHub due to their terms of service, this can be closed by somebody that knows how. -- This is an automated message from the Apache

Re: [PR] XERCESC-2188 - Use-after-free on external DTD scan [xerces-c]

2023-12-06 Thread via GitHub
boris-kolpackov commented on code in PR #54: URL: https://github.com/apache/xerces-c/pull/54#discussion_r1417168833 ## src/xercesc/internal/ReaderMgr.cpp: ## @@ -873,33 +921,50 @@ bool ReaderMgr::isScanningPERefOutOfLiteral() const return false; } - bool

Re: [PR] XERCESC-2188 - Use-after-free on external DTD scan [xerces-c]

2023-12-05 Thread via GitHub
theta682 commented on code in PR #54: URL: https://github.com/apache/xerces-c/pull/54#discussion_r1416808653 ## src/xercesc/internal/ReaderMgr.cpp: ## @@ -1020,7 +1070,9 @@ ReaderMgr::getLastExtEntity(const XMLEntityDecl*& itsEntity) const // search the stack; else, keep

Re: [PR] [XERCESC-2188] Fix potential double-free in usage of ReaderMgr::pushReader() [xerces-c]

2023-12-05 Thread via GitHub
boris-kolpackov commented on PR #47: URL: https://github.com/apache/xerces-c/pull/47#issuecomment-1840893452 FYI: https://github.com/apache/xerces-c/pull/54 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] XERCESC-2188 - Use-after-free on external DTD scan [xerces-c]

2023-12-05 Thread via GitHub
boris-kolpackov commented on PR #54: URL: https://github.com/apache/xerces-c/pull/54#issuecomment-1840890853 This fix follows the same overall idea as https://github.com/apache/xerces-c/pull/47 with the following key differences: 1. It addresses the lifetime issue when throwing

[PR] XERCESC-2188 - Use-after-free on external DTD scan [xerces-c]

2023-12-05 Thread via GitHub
boris-kolpackov opened a new pull request, #54: URL: https://github.com/apache/xerces-c/pull/54 These are the instructions for observing the bug (before this commit): $ git clone https://github.com/apache/xerces-c.git $ cd xerces-c $ mkdir build $ cd build $ cmake -G

[GitHub] [xerces-c] scantor commented on pull request #47: [XERCESC-2188] Fix potential double-free in usage of ReaderMgr::pushReader()

2023-08-22 Thread via GitHub
scantor commented on PR #47: URL: https://github.com/apache/xerces-c/pull/47#issuecomment-1688414268 > I will consider becoming a committer to this project to fix this vulnerability Only if you're in it for the long haul, it's a commitment (pun intended) to actually sustain the code

[GitHub] [xerces-c] johnjamesmccann commented on pull request #47: [XERCESC-2188] Fix potential double-free in usage of ReaderMgr::pushReader()

2023-08-22 Thread via GitHub
johnjamesmccann commented on PR #47: URL: https://github.com/apache/xerces-c/pull/47#issuecomment-1688371818 [Apache-496067-disclosure-report.pdf](https://github.com/apache/xerces-c/files/12409994/Apache-496067-disclosure-report.pdf) Hello Scott here is the vulnerability report as

[GitHub] [xerces-c] johnjamesmccann commented on pull request #47: [XERCESC-2188] Fix potential double-free in usage of ReaderMgr::pushReader()

2023-08-22 Thread via GitHub
johnjamesmccann commented on PR #47: URL: https://github.com/apache/xerces-c/pull/47#issuecomment-1688282792 Thanks for your response Scott, How does it get to be known that the "fix is correct."? It appears that the tests are passing and there are no regressions. This hotfix is

[GitHub] [xerces-c] scantor commented on pull request #47: [XERCESC-2188] Fix potential double-free in usage of ReaderMgr::pushReader()

2023-08-22 Thread via GitHub
scantor commented on PR #47: URL: https://github.com/apache/xerces-c/pull/47#issuecomment-1688246591 It has not, and I don't think it's even known that the fix is correct. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [xerces-c] rleigh-codelibre closed pull request #16: XERCESC-2200: Update AppVeyor for VS2017 and vcpkg

2023-08-18 Thread via GitHub
rleigh-codelibre closed pull request #16: XERCESC-2200: Update AppVeyor for VS2017 and vcpkg URL: https://github.com/apache/xerces-c/pull/16 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [xerces-c] labossip commented on a diff in pull request #47: [XERCESC-2188] Fix potential double-free in usage of ReaderMgr::pushReader()

2023-06-16 Thread via GitHub
labossip commented on code in PR #47: URL: https://github.com/apache/xerces-c/pull/47#discussion_r1231205312 ## src/xercesc/internal/ReaderMgr.cpp: ## @@ -1080,10 +1099,7 @@ bool ReaderMgr::popReader() // Delete the current reader and pop a new reader and entity off

[GitHub] [xerces-c] labossip commented on a diff in pull request #47: [XERCESC-2188] Fix potential double-free in usage of ReaderMgr::pushReader()

2023-06-15 Thread via GitHub
labossip commented on code in PR #47: URL: https://github.com/apache/xerces-c/pull/47#discussion_r1231205312 ## src/xercesc/internal/ReaderMgr.cpp: ## @@ -1080,10 +1099,7 @@ bool ReaderMgr::popReader() // Delete the current reader and pop a new reader and entity off

[GitHub] [xerces-c] rleigh-codelibre commented on pull request #53: The windows.h header files is with lower case

2023-06-09 Thread via GitHub
rleigh-codelibre commented on PR #53: URL: https://github.com/apache/xerces-c/pull/53#issuecomment-1584388338 The CI has been broken for some time, particularly the AppVeyor build environment. It needs updating, but I'm afraid I can no longer spend any time on this, and someone else will

[GitHub] [xerces-c] boris-kolpackov commented on pull request #53: The windows.h header files is with lower case

2023-06-09 Thread via GitHub
boris-kolpackov commented on PR #53: URL: https://github.com/apache/xerces-c/pull/53#issuecomment-1584340715 Merged to `master` and `xerces-3.2`, thanks! Not sure about CI build failures, someone else will need to look into this. -- This is an automated message from the Apache Git

[GitHub] [xerces-c] boris-kolpackov merged pull request #53: The windows.h header files is with lower case

2023-06-09 Thread via GitHub
boris-kolpackov merged PR #53: URL: https://github.com/apache/xerces-c/pull/53 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [xerces-c] Torbjorn-Svensson commented on pull request #53: The windows.h header files is with lower case

2023-06-06 Thread via GitHub
Torbjorn-Svensson commented on PR #53: URL: https://github.com/apache/xerces-c/pull/53#issuecomment-1578649721 The build failure appears to be unrelated to the case change. Can someone look at why the windows build fails to install the required cygwin components? -- This is an

[GitHub] [xerces-c] Torbjorn-Svensson opened a new pull request, #53: The windows.h header files is with lower case

2023-06-02 Thread via GitHub
Torbjorn-Svensson opened a new pull request, #53: URL: https://github.com/apache/xerces-c/pull/53 Contributed by STMicroelectronics -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [xerces-c] ffontaine closed pull request #23: fix static linking with curl

2023-02-22 Thread via GitHub
ffontaine closed pull request #23: fix static linking with curl URL: https://github.com/apache/xerces-c/pull/23 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[GitHub] [xerces-c] ffontaine commented on pull request #23: fix static linking with curl

2023-02-22 Thread via GitHub
ffontaine commented on PR #23: URL: https://github.com/apache/xerces-c/pull/23#issuecomment-1440532507 I'm closing this PR as building statically xerces has been disabled in buildroot -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [xerces-c] DDoS commented on pull request #52: Fix macOS platform check when finding transcoders

2023-02-01 Thread via GitHub
DDoS commented on PR #52: URL: https://github.com/apache/xerces-c/pull/52#issuecomment-1412150888 The cygwin build is failing because Cygwin fails to install. I doubt that's related to my changes. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [xerces-c] DDoS opened a new pull request, #52: Fix macOS platform check when finding transcoders

2023-01-31 Thread via GitHub
DDoS opened a new pull request, #52: URL: https://github.com/apache/xerces-c/pull/52 The check must verify the target platform, instead of the host. This fixes cross-compiling on macOS. Also when targeting iOS, install(TARGET) commands require a BUNDLE destination for executables.