[GitHub] [xerces-c] johnjamesmccann commented on pull request #47: [XERCESC-2188] Fix potential double-free in usage of ReaderMgr::pushReader()

2023-08-22 Thread via GitHub
johnjamesmccann commented on PR #47: URL: https://github.com/apache/xerces-c/pull/47#issuecomment-1688371818 [Apache-496067-disclosure-report.pdf](https://github.com/apache/xerces-c/files/12409994/Apache-496067-disclosure-report.pdf) Hello Scott here is the vulnerability report as

[GitHub] [xerces-c] johnjamesmccann commented on pull request #47: [XERCESC-2188] Fix potential double-free in usage of ReaderMgr::pushReader()

2023-08-22 Thread via GitHub
johnjamesmccann commented on PR #47: URL: https://github.com/apache/xerces-c/pull/47#issuecomment-1688282792 Thanks for your response Scott, How does it get to be known that the "fix is correct."? It appears that the tests are passing and there are no regressions. This hotfix is

[GitHub] [xerces-c] johnjamesmccann commented on pull request #47: [XERCESC-2188] Fix potential double-free in usage of ReaderMgr::pushReader()

2022-02-01 Thread GitBox
johnjamesmccann commented on pull request #47: URL: https://github.com/apache/xerces-c/pull/47#issuecomment-1026877695 So just to confirm there is nothing you need me to do to get this fix in the code base? From: Even Rouault ***@***.***> Sent: 01 February 2022 14:02 To:

[GitHub] [xerces-c] johnjamesmccann commented on pull request #47: [XERCESC-2188] Fix potential double-free in usage of ReaderMgr::pushReader()

2022-02-01 Thread GitBox
johnjamesmccann commented on pull request #47: URL: https://github.com/apache/xerces-c/pull/47#issuecomment-1026872614 Ah yes I can see that now, thanks for picking up on that. Do I need to add that change to my fork or has it been added in your fork which is later than mine?

[GitHub] [xerces-c] johnjamesmccann commented on pull request #47: [XERCESC-2188] Fix potential double-free in usage of ReaderMgr::pushReader()

2022-01-25 Thread GitBox
johnjamesmccann commented on pull request #47: URL: https://github.com/apache/xerces-c/pull/47#issuecomment-1021204613 Hi Rouault, I cant see how my changes could cause a test regression, all my change does is delete 4 smart pointers that are not used in the code base. Kind

[GitHub] [xerces-c] johnjamesmccann commented on pull request #47: [XERCESC-2188] Fix potential double-free in usage of ReaderMgr::pushReader()

2022-01-25 Thread GitBox
johnjamesmccann commented on pull request #47: URL: https://github.com/apache/xerces-c/pull/47#issuecomment-1021204613 Hi Rouault, I cant see how my changes could cause a test regression, all my change does is delete 4 smart pointers that are not used in the code base. Kind