[jira] [Commented] (XERCESC-2101) Add support for XERCES_XMLCH_T = char16_t
[ https://issues.apache.org/jira/browse/XERCESC-2101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16106268#comment-16106268 ] Roger Leigh commented on XERCESC-2101: -- Regarding being from scratch, it's about as different a reimplementation as I could make it while still retaining the same functional effect. Unnecessary parts like the config header changes for windows were dropped outright. Some parts can't be reimplemented differently and so are the same out of necessity; what's in the patch 0001 is mostly just the addition of reinterpret_cast for wchar_t*, and there's very little freedom to be creative there--I've used reinterpret_cast in place of C style casts wherever possible. > Add support for XERCES_XMLCH_T = char16_t > - > > Key: XERCESC-2101 > URL: https://issues.apache.org/jira/browse/XERCESC-2101 > Project: Xerces-C++ > Issue Type: Improvement >Reporter: Vemund Handeland >Assignee: Roger Leigh >Priority: Minor > Fix For: 3.2.0 > > Attachments: > 0001-Add-Windows-support-for-XERCES_XMLCH_T-char16_t.patch, > 0002-Add-MacOS-X-support-for-XERCES_XMLCH_T-char16_t.patch, > 0003-cmake-Check-for-char16_t.patch, 0004-autoconf-Check-for-char16_t.patch, > 0005-tests-Add-Char16Test.patch, char16_t.diff > > > Attached diff contains the required changes for msvc. The diff is from my > local git repo created from the 3.1.4 release. > Added new macro XERCES_USE_CHAR16_T. > User can enable the support by define this macro both when building the > library and her own application. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: c-dev-unsubscr...@xerces.apache.org For additional commands, e-mail: c-dev-h...@xerces.apache.org
[jira] [Resolved] (XERCESC-2101) Add support for XERCES_XMLCH_T = char16_t
[ https://issues.apache.org/jira/browse/XERCESC-2101?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Scott Cantor resolved XERCESC-2101. --- Resolution: Fixed Applied patches to trunk, r1803393 > Add support for XERCES_XMLCH_T = char16_t > - > > Key: XERCESC-2101 > URL: https://issues.apache.org/jira/browse/XERCESC-2101 > Project: Xerces-C++ > Issue Type: Improvement >Reporter: Vemund Handeland >Assignee: Roger Leigh >Priority: Minor > Fix For: 3.2.0 > > Attachments: > 0001-Add-Windows-support-for-XERCES_XMLCH_T-char16_t.patch, > 0002-Add-MacOS-X-support-for-XERCES_XMLCH_T-char16_t.patch, > 0003-cmake-Check-for-char16_t.patch, 0004-autoconf-Check-for-char16_t.patch, > 0005-tests-Add-Char16Test.patch, char16_t.diff > > > Attached diff contains the required changes for msvc. The diff is from my > local git repo created from the 3.1.4 release. > Added new macro XERCES_USE_CHAR16_T. > User can enable the support by define this macro both when building the > library and her own application. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: c-dev-unsubscr...@xerces.apache.org For additional commands, e-mail: c-dev-h...@xerces.apache.org
[jira] [Commented] (XERCESC-2101) Add support for XERCES_XMLCH_T = char16_t
[ https://issues.apache.org/jira/browse/XERCESC-2101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16106217#comment-16106217 ] Scott Cantor commented on XERCESC-2101: --- If it's done from scratch, I'll certainly look it over. > Add support for XERCES_XMLCH_T = char16_t > - > > Key: XERCESC-2101 > URL: https://issues.apache.org/jira/browse/XERCESC-2101 > Project: Xerces-C++ > Issue Type: Improvement >Reporter: Vemund Handeland >Assignee: Roger Leigh >Priority: Minor > Fix For: 3.2.0 > > Attachments: > 0001-Add-Windows-support-for-XERCES_XMLCH_T-char16_t.patch, > 0002-Add-MacOS-X-support-for-XERCES_XMLCH_T-char16_t.patch, > 0003-cmake-Check-for-char16_t.patch, 0004-autoconf-Check-for-char16_t.patch, > 0005-tests-Add-Char16Test.patch, char16_t.diff > > > Attached diff contains the required changes for msvc. The diff is from my > local git repo created from the 3.1.4 release. > Added new macro XERCES_USE_CHAR16_T. > User can enable the support by define this macro both when building the > library and her own application. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: c-dev-unsubscr...@xerces.apache.org For additional commands, e-mail: c-dev-h...@xerces.apache.org
[jira] [Updated] (XERCESC-2101) Add support for XERCES_XMLCH_T = char16_t
[ https://issues.apache.org/jira/browse/XERCESC-2101?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roger Leigh updated XERCESC-2101: - Attachment: (was: 0003-cmake-Check-for-char16_t.patch) > Add support for XERCES_XMLCH_T = char16_t > - > > Key: XERCESC-2101 > URL: https://issues.apache.org/jira/browse/XERCESC-2101 > Project: Xerces-C++ > Issue Type: Improvement >Reporter: Vemund Handeland >Assignee: Roger Leigh >Priority: Minor > Fix For: 3.2.0 > > Attachments: > 0001-Add-Windows-support-for-XERCES_XMLCH_T-char16_t.patch, > 0002-Add-MacOS-X-support-for-XERCES_XMLCH_T-char16_t.patch, > 0003-cmake-Check-for-char16_t.patch, 0004-autoconf-Check-for-char16_t.patch, > 0005-tests-Add-Char16Test.patch, char16_t.diff > > > Attached diff contains the required changes for msvc. The diff is from my > local git repo created from the 3.1.4 release. > Added new macro XERCES_USE_CHAR16_T. > User can enable the support by define this macro both when building the > library and her own application. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: c-dev-unsubscr...@xerces.apache.org For additional commands, e-mail: c-dev-h...@xerces.apache.org
[jira] [Updated] (XERCESC-2101) Add support for XERCES_XMLCH_T = char16_t
[ https://issues.apache.org/jira/browse/XERCESC-2101?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roger Leigh updated XERCESC-2101: - Attachment: (was: 0005-tests-Add-Char16Test.patch) > Add support for XERCES_XMLCH_T = char16_t > - > > Key: XERCESC-2101 > URL: https://issues.apache.org/jira/browse/XERCESC-2101 > Project: Xerces-C++ > Issue Type: Improvement >Reporter: Vemund Handeland >Assignee: Roger Leigh >Priority: Minor > Fix For: 3.2.0 > > Attachments: > 0001-Add-Windows-support-for-XERCES_XMLCH_T-char16_t.patch, > 0002-Add-MacOS-X-support-for-XERCES_XMLCH_T-char16_t.patch, > 0003-cmake-Check-for-char16_t.patch, 0004-autoconf-Check-for-char16_t.patch, > 0005-tests-Add-Char16Test.patch, char16_t.diff > > > Attached diff contains the required changes for msvc. The diff is from my > local git repo created from the 3.1.4 release. > Added new macro XERCES_USE_CHAR16_T. > User can enable the support by define this macro both when building the > library and her own application. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: c-dev-unsubscr...@xerces.apache.org For additional commands, e-mail: c-dev-h...@xerces.apache.org
[jira] [Updated] (XERCESC-2101) Add support for XERCES_XMLCH_T = char16_t
[ https://issues.apache.org/jira/browse/XERCESC-2101?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roger Leigh updated XERCESC-2101: - Attachment: (was: 0004-autoconf-Check-for-char16_t.patch) > Add support for XERCES_XMLCH_T = char16_t > - > > Key: XERCESC-2101 > URL: https://issues.apache.org/jira/browse/XERCESC-2101 > Project: Xerces-C++ > Issue Type: Improvement >Reporter: Vemund Handeland >Assignee: Roger Leigh >Priority: Minor > Fix For: 3.2.0 > > Attachments: > 0001-Add-Windows-support-for-XERCES_XMLCH_T-char16_t.patch, > 0002-Add-MacOS-X-support-for-XERCES_XMLCH_T-char16_t.patch, > 0003-cmake-Check-for-char16_t.patch, 0004-autoconf-Check-for-char16_t.patch, > 0005-tests-Add-Char16Test.patch, char16_t.diff > > > Attached diff contains the required changes for msvc. The diff is from my > local git repo created from the 3.1.4 release. > Added new macro XERCES_USE_CHAR16_T. > User can enable the support by define this macro both when building the > library and her own application. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: c-dev-unsubscr...@xerces.apache.org For additional commands, e-mail: c-dev-h...@xerces.apache.org
[jira] [Updated] (XERCESC-2101) Add support for XERCES_XMLCH_T = char16_t
[ https://issues.apache.org/jira/browse/XERCESC-2101?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roger Leigh updated XERCESC-2101: - Attachment: 0001-Add-Windows-support-for-XERCES_XMLCH_T-char16_t.patch 0002-Add-MacOS-X-support-for-XERCES_XMLCH_T-char16_t.patch 0003-cmake-Check-for-char16_t.patch 0004-autoconf-Check-for-char16_t.patch 0005-tests-Add-Char16Test.patch In the absence of a response, I've rewritten the patch myself in the interest of getting this in. Builds passed in https://travis-ci.org/rleigh-codelibre/xerces-c/builds/258621587 and https://ci.appveyor.com/project/rleigh-codelibre/xerces-c/build/1.0.116 Would this be OK to merge? > Add support for XERCES_XMLCH_T = char16_t > - > > Key: XERCESC-2101 > URL: https://issues.apache.org/jira/browse/XERCESC-2101 > Project: Xerces-C++ > Issue Type: Improvement >Reporter: Vemund Handeland >Assignee: Roger Leigh >Priority: Minor > Fix For: 3.2.0 > > Attachments: > 0001-Add-Windows-support-for-XERCES_XMLCH_T-char16_t.patch, > 0002-Add-MacOS-X-support-for-XERCES_XMLCH_T-char16_t.patch, > 0003-cmake-Check-for-char16_t.patch, 0003-cmake-Check-for-char16_t.patch, > 0004-autoconf-Check-for-char16_t.patch, > 0004-autoconf-Check-for-char16_t.patch, 0005-tests-Add-Char16Test.patch, > 0005-tests-Add-Char16Test.patch, char16_t.diff > > > Attached diff contains the required changes for msvc. The diff is from my > local git repo created from the 3.1.4 release. > Added new macro XERCES_USE_CHAR16_T. > User can enable the support by define this macro both when building the > library and her own application. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: c-dev-unsubscr...@xerces.apache.org For additional commands, e-mail: c-dev-h...@xerces.apache.org
[jira] [Updated] (XERCESC-2101) Add support for XERCES_XMLCH_T = char16_t
[ https://issues.apache.org/jira/browse/XERCESC-2101?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roger Leigh updated XERCESC-2101: - Attachment: (was: 0002-Add-MacOS-X-support-for-XERCES_XMLCH_T-char16_t.patch) > Add support for XERCES_XMLCH_T = char16_t > - > > Key: XERCESC-2101 > URL: https://issues.apache.org/jira/browse/XERCESC-2101 > Project: Xerces-C++ > Issue Type: Improvement >Reporter: Vemund Handeland >Assignee: Roger Leigh >Priority: Minor > Fix For: 3.2.0 > > Attachments: > 0001-Add-Windows-support-for-XERCES_XMLCH_T-char16_t.patch, > 0002-Add-MacOS-X-support-for-XERCES_XMLCH_T-char16_t.patch, > 0003-cmake-Check-for-char16_t.patch, 0003-cmake-Check-for-char16_t.patch, > 0004-autoconf-Check-for-char16_t.patch, > 0004-autoconf-Check-for-char16_t.patch, 0005-tests-Add-Char16Test.patch, > 0005-tests-Add-Char16Test.patch, char16_t.diff > > > Attached diff contains the required changes for msvc. The diff is from my > local git repo created from the 3.1.4 release. > Added new macro XERCES_USE_CHAR16_T. > User can enable the support by define this macro both when building the > library and her own application. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: c-dev-unsubscr...@xerces.apache.org For additional commands, e-mail: c-dev-h...@xerces.apache.org
[jira] [Updated] (XERCESC-2101) Add support for XERCES_XMLCH_T = char16_t
[ https://issues.apache.org/jira/browse/XERCESC-2101?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roger Leigh updated XERCESC-2101: - Attachment: (was: 0001-Add-Windows-support-for-XERCES_XMLCH_T-char16_t.patch) > Add support for XERCES_XMLCH_T = char16_t > - > > Key: XERCESC-2101 > URL: https://issues.apache.org/jira/browse/XERCESC-2101 > Project: Xerces-C++ > Issue Type: Improvement >Reporter: Vemund Handeland >Assignee: Roger Leigh >Priority: Minor > Fix For: 3.2.0 > > Attachments: > 0001-Add-Windows-support-for-XERCES_XMLCH_T-char16_t.patch, > 0002-Add-MacOS-X-support-for-XERCES_XMLCH_T-char16_t.patch, > 0003-cmake-Check-for-char16_t.patch, 0003-cmake-Check-for-char16_t.patch, > 0004-autoconf-Check-for-char16_t.patch, > 0004-autoconf-Check-for-char16_t.patch, 0005-tests-Add-Char16Test.patch, > 0005-tests-Add-Char16Test.patch, char16_t.diff > > > Attached diff contains the required changes for msvc. The diff is from my > local git repo created from the 3.1.4 release. > Added new macro XERCES_USE_CHAR16_T. > User can enable the support by define this macro both when building the > library and her own application. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: c-dev-unsubscr...@xerces.apache.org For additional commands, e-mail: c-dev-h...@xerces.apache.org
