[jira] [Commented] (XERCESC-2136) Add support for versioning sources and documentation automatically
[ https://issues.apache.org/jira/browse/XERCESC-2136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16366458#comment-16366458 ] Scott Cantor commented on XERCESC-2136: --- Everything looks good to me. I did have to do some screwing around to point it at the old Java I had to use to get the site built, but that's expected and doesn't impact the final distribution files. There are three files that have been a manual thing to deal with in the site, releases.xml, releases_plan.xml, and release_archive.xml. They have links to each release's fix list, and automating it in its current form would be difficult. I did clean up one of them to eliminate a reference to release date, but the other two remain manual. I updated them for now. They could be updated really any time the Jira versions are in place for the next release. > Add support for versioning sources and documentation automatically > -- > > Key: XERCESC-2136 > URL: https://issues.apache.org/jira/browse/XERCESC-2136 > Project: Xerces-C++ > Issue Type: Improvement > Components: Build, Utilities >Affects Versions: 3.2.0 >Reporter: Roger Leigh >Assignee: Roger Leigh >Priority: Major > Fix For: 3.2.1 > > Attachments: > 0001-Automatically-generate-versioned-documentation-and-h.patch > > > Making a release requires a number of manual updates to various files > including: > * configure.ac > * versions.incl > * xerces-c.spec > * src/xercesc/util/XercesVersion.hpp > * doc/style/dtd/entities.ent > * doc/source-repository.xml > * doc/Doxyfile > It would be more efficient to make the majority of these updates automatic. > > I've worked on some simple updates to the autoconf and cmake builds to do the > following: > * move library versioning into configure.ac (no separate updates to > versions.incl) > * generate a Xerces_version_config.hpp header like the > Xerces_autoconf_config.hpp header, for inclusion by XercesVersion.hpp > * generating entities.ent to automate docs version updates > * making source-repository.xml use version entities to eliminate manual > updates > * generating Doxyfile to avoid manual version updates > > This narrows down updates to two files: > * configure.ac > * xerces-c.spec > > I'll attach a patch once I've done some more testing. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: c-dev-unsubscr...@xerces.apache.org For additional commands, e-mail: c-dev-h...@xerces.apache.org
[jira] [Commented] (XERCESC-2137) CMake Build Doesn't Activate XERCES_MFC_SUPPORT
[ https://issues.apache.org/jira/browse/XERCESC-2137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16366267#comment-16366267 ] Roger Leigh commented on XERCESC-2137: -- [~blumf] Please could you try testing with the attached patch. Also available here if it's easier: [https://github.com/rleigh-codelibre/xerces-c/tree/mfc-support] Should be enabled by default, though you can disable if you wish, which matches the defaults of the 3.1 MSVC configuration header. This is based on your patch, but matches the style of the existing options and adds some documentation. Thanks, Roger > CMake Build Doesn't Activate XERCES_MFC_SUPPORT > --- > > Key: XERCESC-2137 > URL: https://issues.apache.org/jira/browse/XERCESC-2137 > Project: Xerces-C++ > Issue Type: Bug > Components: Build > Environment: MS Visual Studio >Reporter: Scott Morgan >Priority: Major > Attachments: 0001-cmake-Add-mfc-debug-option.patch, > mfc_debug_cmake.patch > > > The XERCES_MFC_SUPPORT define is needed for Visual Studio debug builds, it > activates some code in XMemory.hpp/cpp > Should just be a case of detecting MSVC in the main CMakeLists.txt and adding > a '#cmakedefine XERCES_MFC_SUPPORT' line in > Xerces_autoconf_config.hpp.cmake.in -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: c-dev-unsubscr...@xerces.apache.org For additional commands, e-mail: c-dev-h...@xerces.apache.org
[jira] [Updated] (XERCESC-2137) CMake Build Doesn't Activate XERCES_MFC_SUPPORT
[ https://issues.apache.org/jira/browse/XERCESC-2137?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roger Leigh updated XERCESC-2137: - Attachment: 0001-cmake-Add-mfc-debug-option.patch > CMake Build Doesn't Activate XERCES_MFC_SUPPORT > --- > > Key: XERCESC-2137 > URL: https://issues.apache.org/jira/browse/XERCESC-2137 > Project: Xerces-C++ > Issue Type: Bug > Components: Build > Environment: MS Visual Studio >Reporter: Scott Morgan >Priority: Major > Attachments: 0001-cmake-Add-mfc-debug-option.patch, > mfc_debug_cmake.patch > > > The XERCES_MFC_SUPPORT define is needed for Visual Studio debug builds, it > activates some code in XMemory.hpp/cpp > Should just be a case of detecting MSVC in the main CMakeLists.txt and adding > a '#cmakedefine XERCES_MFC_SUPPORT' line in > Xerces_autoconf_config.hpp.cmake.in -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: c-dev-unsubscr...@xerces.apache.org For additional commands, e-mail: c-dev-h...@xerces.apache.org
[jira] [Commented] (XERCESC-2137) CMake Build Doesn't Activate XERCES_MFC_SUPPORT
[
https://issues.apache.org/jira/browse/XERCESC-2137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16365734#comment-16365734
]
Scott Morgan commented on XERCESC-2137:
---
Yes, MFC apps in Debug mode throw build errors without the XERCES_MFC_SUPPORT
items.
Basic steps to reproduce:
# In Visual Studio, create an MFC app
# Open up the app's main .cpp file (same as project name)
# include
# In app's InitInstance function add in
{code:java}
XMLCh tempStr[100];
XERCES_CPP_NAMESPACE::XMLString::transcode("abc", tempStr, 99){code}
# Compile file in debug mode. You get a load of errors that tie back to
operator new use. Release mode is okay.
Doesn't seem to hit plain win32 apps.
> CMake Build Doesn't Activate XERCES_MFC_SUPPORT
> ---
>
> Key: XERCESC-2137
> URL: https://issues.apache.org/jira/browse/XERCESC-2137
> Project: Xerces-C++
> Issue Type: Bug
> Components: Build
> Environment: MS Visual Studio
>Reporter: Scott Morgan
>Priority: Major
> Attachments: mfc_debug_cmake.patch
>
>
> The XERCES_MFC_SUPPORT define is needed for Visual Studio debug builds, it
> activates some code in XMemory.hpp/cpp
> Should just be a case of detecting MSVC in the main CMakeLists.txt and adding
> a '#cmakedefine XERCES_MFC_SUPPORT' line in
> Xerces_autoconf_config.hpp.cmake.in
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: c-dev-unsubscr...@xerces.apache.org
For additional commands, e-mail: c-dev-h...@xerces.apache.org
[jira] [Commented] (XERCESC-2137) CMake Build Doesn't Activate XERCES_MFC_SUPPORT
[ https://issues.apache.org/jira/browse/XERCESC-2137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16365656#comment-16365656 ] Roger Leigh commented on XERCESC-2137: -- The fix is pretty straightforward. I can apply this with a bit of extra documentation. What's actually breaking here? I do daily debug builds and I've never had a problem. Does you project need to be explicitly using MFC stuff for this to be an issue? > CMake Build Doesn't Activate XERCES_MFC_SUPPORT > --- > > Key: XERCESC-2137 > URL: https://issues.apache.org/jira/browse/XERCESC-2137 > Project: Xerces-C++ > Issue Type: Bug > Components: Build > Environment: MS Visual Studio >Reporter: Scott Morgan >Priority: Major > Attachments: mfc_debug_cmake.patch > > > The XERCES_MFC_SUPPORT define is needed for Visual Studio debug builds, it > activates some code in XMemory.hpp/cpp > Should just be a case of detecting MSVC in the main CMakeLists.txt and adding > a '#cmakedefine XERCES_MFC_SUPPORT' line in > Xerces_autoconf_config.hpp.cmake.in -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: c-dev-unsubscr...@xerces.apache.org For additional commands, e-mail: c-dev-h...@xerces.apache.org
[jira] [Commented] (XERCESC-2137) CMake Build Doesn't Activate XERCES_MFC_SUPPORT
[ https://issues.apache.org/jira/browse/XERCESC-2137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16365564#comment-16365564 ] Scott Morgan commented on XERCESC-2137: --- Debug build of Xerces under Visual Studio don't work without them. VC++/MFC uses some alternate memory operators in that mode which is covered by that XERCES_MFC_SUPPORT define. It's a pretty easy fix: [^mfc_debug_cmake.patch] > CMake Build Doesn't Activate XERCES_MFC_SUPPORT > --- > > Key: XERCESC-2137 > URL: https://issues.apache.org/jira/browse/XERCESC-2137 > Project: Xerces-C++ > Issue Type: Bug > Components: Build > Environment: MS Visual Studio >Reporter: Scott Morgan >Priority: Major > Attachments: mfc_debug_cmake.patch > > > The XERCES_MFC_SUPPORT define is needed for Visual Studio debug builds, it > activates some code in XMemory.hpp/cpp > Should just be a case of detecting MSVC in the main CMakeLists.txt and adding > a '#cmakedefine XERCES_MFC_SUPPORT' line in > Xerces_autoconf_config.hpp.cmake.in -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: c-dev-unsubscr...@xerces.apache.org For additional commands, e-mail: c-dev-h...@xerces.apache.org
[jira] [Updated] (XERCESC-2137) CMake Build Doesn't Activate XERCES_MFC_SUPPORT
[ https://issues.apache.org/jira/browse/XERCESC-2137?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Scott Morgan updated XERCESC-2137: -- Attachment: mfc_debug_cmake.patch > CMake Build Doesn't Activate XERCES_MFC_SUPPORT > --- > > Key: XERCESC-2137 > URL: https://issues.apache.org/jira/browse/XERCESC-2137 > Project: Xerces-C++ > Issue Type: Bug > Components: Build > Environment: MS Visual Studio >Reporter: Scott Morgan >Priority: Major > Attachments: mfc_debug_cmake.patch > > > The XERCES_MFC_SUPPORT define is needed for Visual Studio debug builds, it > activates some code in XMemory.hpp/cpp > Should just be a case of detecting MSVC in the main CMakeLists.txt and adding > a '#cmakedefine XERCES_MFC_SUPPORT' line in > Xerces_autoconf_config.hpp.cmake.in -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: c-dev-unsubscr...@xerces.apache.org For additional commands, e-mail: c-dev-h...@xerces.apache.org
[jira] [Commented] (XERCESC-2137) CMake Build Doesn't Activate XERCES_MFC_SUPPORT
[ https://issues.apache.org/jira/browse/XERCESC-2137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16365536#comment-16365536 ] Roger Leigh commented on XERCESC-2137: -- The code in XMemory appears to be just stubs that delegate to operator new(size), and there are no callers in the tree. As far as I can tell, it's completely pointless and does nothing at all! We could likely delete them with no functional impact. Did you need them for any specific purpose? I'm not an MFC expert; if there's a good reason to have this we can write the necessary CMake logic to detect MFC support is available and enable it. But if it's non-functional, we might be better removing it entirely? > CMake Build Doesn't Activate XERCES_MFC_SUPPORT > --- > > Key: XERCESC-2137 > URL: https://issues.apache.org/jira/browse/XERCESC-2137 > Project: Xerces-C++ > Issue Type: Bug > Components: Build > Environment: MS Visual Studio >Reporter: Scott Morgan >Priority: Major > > The XERCES_MFC_SUPPORT define is needed for Visual Studio debug builds, it > activates some code in XMemory.hpp/cpp > Should just be a case of detecting MSVC in the main CMakeLists.txt and adding > a '#cmakedefine XERCES_MFC_SUPPORT' line in > Xerces_autoconf_config.hpp.cmake.in -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: c-dev-unsubscr...@xerces.apache.org For additional commands, e-mail: c-dev-h...@xerces.apache.org
[jira] [Created] (XERCESC-2137) CMake Build Doesn't Activate XERCES_MFC_SUPPORT
Scott Morgan created XERCESC-2137: - Summary: CMake Build Doesn't Activate XERCES_MFC_SUPPORT Key: XERCESC-2137 URL: https://issues.apache.org/jira/browse/XERCESC-2137 Project: Xerces-C++ Issue Type: Bug Components: Build Environment: MS Visual Studio Reporter: Scott Morgan The XERCES_MFC_SUPPORT define is needed for Visual Studio debug builds, it activates some code in XMemory.hpp/cpp Should just be a case of detecting MSVC in the main CMakeLists.txt and adding a '#cmakedefine XERCES_MFC_SUPPORT' line in Xerces_autoconf_config.hpp.cmake.in -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: c-dev-unsubscr...@xerces.apache.org For additional commands, e-mail: c-dev-h...@xerces.apache.org
[jira] [Commented] (XERCESC-2136) Add support for versioning sources and documentation automatically
[ https://issues.apache.org/jira/browse/XERCESC-2136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16365408#comment-16365408 ] Roger Leigh commented on XERCESC-2136: -- Added in r1824295. > Add support for versioning sources and documentation automatically > -- > > Key: XERCESC-2136 > URL: https://issues.apache.org/jira/browse/XERCESC-2136 > Project: Xerces-C++ > Issue Type: Improvement > Components: Build, Utilities >Affects Versions: 3.2.0 >Reporter: Roger Leigh >Assignee: Roger Leigh >Priority: Major > Fix For: 3.2.1 > > Attachments: > 0001-Automatically-generate-versioned-documentation-and-h.patch > > > Making a release requires a number of manual updates to various files > including: > * configure.ac > * versions.incl > * xerces-c.spec > * src/xercesc/util/XercesVersion.hpp > * doc/style/dtd/entities.ent > * doc/source-repository.xml > * doc/Doxyfile > It would be more efficient to make the majority of these updates automatic. > > I've worked on some simple updates to the autoconf and cmake builds to do the > following: > * move library versioning into configure.ac (no separate updates to > versions.incl) > * generate a Xerces_version_config.hpp header like the > Xerces_autoconf_config.hpp header, for inclusion by XercesVersion.hpp > * generating entities.ent to automate docs version updates > * making source-repository.xml use version entities to eliminate manual > updates > * generating Doxyfile to avoid manual version updates > > This narrows down updates to two files: > * configure.ac > * xerces-c.spec > > I'll attach a patch once I've done some more testing. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: c-dev-unsubscr...@xerces.apache.org For additional commands, e-mail: c-dev-h...@xerces.apache.org
[jira] [Resolved] (XERCESC-2136) Add support for versioning sources and documentation automatically
[ https://issues.apache.org/jira/browse/XERCESC-2136?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roger Leigh resolved XERCESC-2136. -- Resolution: Fixed Fix Version/s: 3.2.1 > Add support for versioning sources and documentation automatically > -- > > Key: XERCESC-2136 > URL: https://issues.apache.org/jira/browse/XERCESC-2136 > Project: Xerces-C++ > Issue Type: Improvement > Components: Build, Utilities >Affects Versions: 3.2.0 >Reporter: Roger Leigh >Assignee: Roger Leigh >Priority: Major > Fix For: 3.2.1 > > Attachments: > 0001-Automatically-generate-versioned-documentation-and-h.patch > > > Making a release requires a number of manual updates to various files > including: > * configure.ac > * versions.incl > * xerces-c.spec > * src/xercesc/util/XercesVersion.hpp > * doc/style/dtd/entities.ent > * doc/source-repository.xml > * doc/Doxyfile > It would be more efficient to make the majority of these updates automatic. > > I've worked on some simple updates to the autoconf and cmake builds to do the > following: > * move library versioning into configure.ac (no separate updates to > versions.incl) > * generate a Xerces_version_config.hpp header like the > Xerces_autoconf_config.hpp header, for inclusion by XercesVersion.hpp > * generating entities.ent to automate docs version updates > * making source-repository.xml use version entities to eliminate manual > updates > * generating Doxyfile to avoid manual version updates > > This narrows down updates to two files: > * configure.ac > * xerces-c.spec > > I'll attach a patch once I've done some more testing. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: c-dev-unsubscr...@xerces.apache.org For additional commands, e-mail: c-dev-h...@xerces.apache.org
