[
https://issues.apache.org/jira/browse/XERCESC-2100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16049702#comment-16049702
]
Roger Leigh commented on XERCESC-2100:
--
I've committed these minus the virtual dtor patches (12 and
[
https://issues.apache.org/jira/browse/XERCESC-2100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16048004#comment-16048004
]
Roger Leigh commented on XERCESC-2100:
--
For me, mainly for robustness in the face of future changes
[
https://issues.apache.org/jira/browse/XERCESC-2100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16048001#comment-16048001
]
Vitaly Prapirny commented on XERCESC-2100:
--
How adding virtual destructor to class, not used as
[
https://issues.apache.org/jira/browse/XERCESC-2100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16047953#comment-16047953
]
Roger Leigh commented on XERCESC-2100:
--
For 0012, it's something which GCC/clang were warning
[
https://issues.apache.org/jira/browse/XERCESC-2100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16047971#comment-16047971
]
Roger Leigh commented on XERCESC-2100:
--
The main thing I can see in favour of a non-virtual dtor is
[
https://issues.apache.org/jira/browse/XERCESC-2100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16047956#comment-16047956
]
Scott Cantor commented on XERCESC-2100:
---
There's also no reason not to make the change for simple
[
https://issues.apache.org/jira/browse/XERCESC-2100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16047918#comment-16047918
]
Roger Leigh commented on XERCESC-2100:
--
Yes, the reinterpret_cast instances look dodgy due to the
[
https://issues.apache.org/jira/browse/XERCESC-2100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16047911#comment-16047911
]
Scott Cantor commented on XERCESC-2100:
---
The cast warnings concerns me because some of those
[
https://issues.apache.org/jira/browse/XERCESC-2100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16047667#comment-16047667
]
Roger Leigh commented on XERCESC-2100:
--
I've opened the ticket here in case anyone wanted to have a