[jira] [Commented] (XERCESC-2101) Add support for XERCES_XMLCH_T = char16_t
[ https://issues.apache.org/jira/browse/XERCESC-2101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16106379#comment-16106379 ] Roger Leigh commented on XERCESC-2101: -- The existing commit missed the execute perms on tests/scripts/Char16Test and the output tests/expected/Char16Test.log. I've added both of these changes. > Add support for XERCES_XMLCH_T = char16_t > - > > Key: XERCESC-2101 > URL: https://issues.apache.org/jira/browse/XERCESC-2101 > Project: Xerces-C++ > Issue Type: Improvement >Reporter: Vemund Handeland >Assignee: Roger Leigh >Priority: Minor > Fix For: 3.2.0 > > Attachments: > 0001-Add-Windows-support-for-XERCES_XMLCH_T-char16_t.patch, > 0002-Add-MacOS-X-support-for-XERCES_XMLCH_T-char16_t.patch, > 0003-cmake-Check-for-char16_t.patch, 0004-autoconf-Check-for-char16_t.patch, > 0005-tests-Add-Char16Test.patch, char16_t.diff > > > Attached diff contains the required changes for msvc. The diff is from my > local git repo created from the 3.1.4 release. > Added new macro XERCES_USE_CHAR16_T. > User can enable the support by define this macro both when building the > library and her own application. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: c-dev-unsubscr...@xerces.apache.org For additional commands, e-mail: c-dev-h...@xerces.apache.org
[jira] [Commented] (XERCESC-2101) Add support for XERCES_XMLCH_T = char16_t
[ https://issues.apache.org/jira/browse/XERCESC-2101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16106268#comment-16106268 ] Roger Leigh commented on XERCESC-2101: -- Regarding being from scratch, it's about as different a reimplementation as I could make it while still retaining the same functional effect. Unnecessary parts like the config header changes for windows were dropped outright. Some parts can't be reimplemented differently and so are the same out of necessity; what's in the patch 0001 is mostly just the addition of reinterpret_cast for wchar_t*, and there's very little freedom to be creative there--I've used reinterpret_cast in place of C style casts wherever possible. > Add support for XERCES_XMLCH_T = char16_t > - > > Key: XERCESC-2101 > URL: https://issues.apache.org/jira/browse/XERCESC-2101 > Project: Xerces-C++ > Issue Type: Improvement >Reporter: Vemund Handeland >Assignee: Roger Leigh >Priority: Minor > Fix For: 3.2.0 > > Attachments: > 0001-Add-Windows-support-for-XERCES_XMLCH_T-char16_t.patch, > 0002-Add-MacOS-X-support-for-XERCES_XMLCH_T-char16_t.patch, > 0003-cmake-Check-for-char16_t.patch, 0004-autoconf-Check-for-char16_t.patch, > 0005-tests-Add-Char16Test.patch, char16_t.diff > > > Attached diff contains the required changes for msvc. The diff is from my > local git repo created from the 3.1.4 release. > Added new macro XERCES_USE_CHAR16_T. > User can enable the support by define this macro both when building the > library and her own application. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: c-dev-unsubscr...@xerces.apache.org For additional commands, e-mail: c-dev-h...@xerces.apache.org
[jira] [Commented] (XERCESC-2101) Add support for XERCES_XMLCH_T = char16_t
[ https://issues.apache.org/jira/browse/XERCESC-2101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16106217#comment-16106217 ] Scott Cantor commented on XERCESC-2101: --- If it's done from scratch, I'll certainly look it over. > Add support for XERCES_XMLCH_T = char16_t > - > > Key: XERCESC-2101 > URL: https://issues.apache.org/jira/browse/XERCESC-2101 > Project: Xerces-C++ > Issue Type: Improvement >Reporter: Vemund Handeland >Assignee: Roger Leigh >Priority: Minor > Fix For: 3.2.0 > > Attachments: > 0001-Add-Windows-support-for-XERCES_XMLCH_T-char16_t.patch, > 0002-Add-MacOS-X-support-for-XERCES_XMLCH_T-char16_t.patch, > 0003-cmake-Check-for-char16_t.patch, 0004-autoconf-Check-for-char16_t.patch, > 0005-tests-Add-Char16Test.patch, char16_t.diff > > > Attached diff contains the required changes for msvc. The diff is from my > local git repo created from the 3.1.4 release. > Added new macro XERCES_USE_CHAR16_T. > User can enable the support by define this macro both when building the > library and her own application. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: c-dev-unsubscr...@xerces.apache.org For additional commands, e-mail: c-dev-h...@xerces.apache.org
[jira] [Commented] (XERCESC-2101) Add support for XERCES_XMLCH_T = char16_t
[ https://issues.apache.org/jira/browse/XERCESC-2101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16093436#comment-16093436 ] Scott Cantor commented on XERCESC-2101: --- I was about to look at pulling in the patches, and noticed the question about the CLA. Definitely can't do a change of this magnitude without confirmation on that. I'd like to start moving toward a RC for testing so I can't wait too long on it. > Add support for XERCES_XMLCH_T = char16_t > - > > Key: XERCESC-2101 > URL: https://issues.apache.org/jira/browse/XERCESC-2101 > Project: Xerces-C++ > Issue Type: Improvement >Reporter: Vemund Handeland >Assignee: Roger Leigh >Priority: Minor > Fix For: 3.2.0 > > Attachments: > 0001-Add-Windows-support-for-XERCES_XMLCH_T-char16_t.patch, > 0002-Add-MacOS-X-support-for-XERCES_XMLCH_T-char16_t.patch, > 0003-cmake-Check-for-char16_t.patch, 0004-autoconf-Check-for-char16_t.patch, > 0005-tests-Add-Char16Test.patch, char16_t.diff > > > Attached diff contains the required changes for msvc. The diff is from my > local git repo created from the 3.1.4 release. > Added new macro XERCES_USE_CHAR16_T. > User can enable the support by define this macro both when building the > library and her own application. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: c-dev-unsubscr...@xerces.apache.org For additional commands, e-mail: c-dev-h...@xerces.apache.org
[jira] [Commented] (XERCESC-2101) Add support for XERCES_XMLCH_T = char16_t
[ https://issues.apache.org/jira/browse/XERCESC-2101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16085916#comment-16085916 ] Roger Leigh commented on XERCESC-2101: -- Working on all platform in https://travis-ci.org/rleigh-codelibre/xerces-c/builds/253216852 and https://ci.appveyor.com/project/rleigh-codelibre/xerces-c/build/1.0.111 > Add support for XERCES_XMLCH_T = char16_t > - > > Key: XERCESC-2101 > URL: https://issues.apache.org/jira/browse/XERCESC-2101 > Project: Xerces-C++ > Issue Type: Improvement >Reporter: Vemund Handeland >Assignee: Roger Leigh >Priority: Minor > Fix For: 3.2.0 > > Attachments: > 0001-Add-Windows-support-for-XERCES_XMLCH_T-char16_t.patch, > 0002-Add-MacOS-X-support-for-XERCES_XMLCH_T-char16_t.patch, > 0003-cmake-Check-for-char16_t.patch, 0004-autoconf-Check-for-char16_t.patch, > 0005-tests-Add-Char16Test.patch, char16_t.diff > > > Attached diff contains the required changes for msvc. The diff is from my > local git repo created from the 3.1.4 release. > Added new macro XERCES_USE_CHAR16_T. > User can enable the support by define this macro both when building the > library and her own application. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: c-dev-unsubscr...@xerces.apache.org For additional commands, e-mail: c-dev-h...@xerces.apache.org
[jira] [Commented] (XERCESC-2101) Add support for XERCES_XMLCH_T = char16_t
[ https://issues.apache.org/jira/browse/XERCESC-2101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16085718#comment-16085718 ] Roger Leigh commented on XERCESC-2101: -- [~hvemha] Are the attached patches OK with you? Did you submit the Apache CLA for xerces-c contributions? I just want to be sure it's allowed to commit these changes to subversion. Thanks, Roger > Add support for XERCES_XMLCH_T = char16_t > - > > Key: XERCESC-2101 > URL: https://issues.apache.org/jira/browse/XERCESC-2101 > Project: Xerces-C++ > Issue Type: Improvement >Reporter: Vemund Handeland >Assignee: Roger Leigh >Priority: Minor > Fix For: 3.2.0 > > Attachments: > 0001-Add-Windows-support-for-XERCES_XMLCH_T-char16_t.patch, > 0002-Add-MacOS-X-support-for-XERCES_XMLCH_T-char16_t.patch, > 0003-cmake-Check-for-char16_t.patch, 0004-autoconf-Check-for-char16_t.patch, > 0005-tests-Add-Char16Test.patch, char16_t.diff > > > Attached diff contains the required changes for msvc. The diff is from my > local git repo created from the 3.1.4 release. > Added new macro XERCES_USE_CHAR16_T. > User can enable the support by define this macro both when building the > library and her own application. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: c-dev-unsubscr...@xerces.apache.org For additional commands, e-mail: c-dev-h...@xerces.apache.org
[jira] [Commented] (XERCESC-2101) Add support for XERCES_XMLCH_T = char16_t
[ https://issues.apache.org/jira/browse/XERCESC-2101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16082358#comment-16082358 ] Scott Cantor commented on XERCESC-2101: --- I think I thought the patches had already been applied, my error. I will try the patches out when I have a chance, still marching through bugs at this point obviously. > Add support for XERCES_XMLCH_T = char16_t > - > > Key: XERCESC-2101 > URL: https://issues.apache.org/jira/browse/XERCESC-2101 > Project: Xerces-C++ > Issue Type: Improvement >Reporter: Vemund Handeland >Assignee: Roger Leigh >Priority: Minor > Fix For: 3.2.0 > > Attachments: > 0001-Add-Windows-support-for-XERCES_XMLCH_T-char16_t.patch, > 0002-cmake-Check-for-char16_t.patch, 0003-autoconf-Check-for-char16_t.patch, > char16_t.diff > > > Attached diff contains the required changes for msvc. The diff is from my > local git repo created from the 3.1.4 release. > Added new macro XERCES_USE_CHAR16_T. > User can enable the support by define this macro both when building the > library and her own application. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: c-dev-unsubscr...@xerces.apache.org For additional commands, e-mail: c-dev-h...@xerces.apache.org
[jira] [Commented] (XERCESC-2101) Add support for XERCES_XMLCH_T = char16_t
[ https://issues.apache.org/jira/browse/XERCESC-2101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16082206#comment-16082206 ] Roger Leigh commented on XERCESC-2101: -- I might also write a C++11-specific unit test to exercise the direct use of u"" strings, but the code that's here should be ready to commit if you're happy with it. > Add support for XERCES_XMLCH_T = char16_t > - > > Key: XERCESC-2101 > URL: https://issues.apache.org/jira/browse/XERCESC-2101 > Project: Xerces-C++ > Issue Type: Improvement >Reporter: Vemund Handeland >Assignee: Roger Leigh >Priority: Minor > Fix For: 3.2.0 > > Attachments: > 0001-Add-Windows-support-for-XERCES_XMLCH_T-char16_t.patch, > 0002-cmake-Check-for-char16_t.patch, 0003-autoconf-Check-for-char16_t.patch, > char16_t.diff > > > Attached diff contains the required changes for msvc. The diff is from my > local git repo created from the 3.1.4 release. > Added new macro XERCES_USE_CHAR16_T. > User can enable the support by define this macro both when building the > library and her own application. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: c-dev-unsubscr...@xerces.apache.org For additional commands, e-mail: c-dev-h...@xerces.apache.org
[jira] [Commented] (XERCESC-2101) Add support for XERCES_XMLCH_T = char16_t
[ https://issues.apache.org/jira/browse/XERCESC-2101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16078683#comment-16078683 ] Scott Cantor commented on XERCESC-2101: --- Anything else to do on this? > Add support for XERCES_XMLCH_T = char16_t > - > > Key: XERCESC-2101 > URL: https://issues.apache.org/jira/browse/XERCESC-2101 > Project: Xerces-C++ > Issue Type: Improvement >Reporter: Vemund Handeland >Assignee: Roger Leigh >Priority: Minor > Fix For: 3.2.0 > > Attachments: > 0001-Add-Windows-support-for-XERCES_XMLCH_T-char16_t.patch, > 0002-cmake-Check-for-char16_t.patch, 0003-autoconf-Check-for-char16_t.patch, > char16_t.diff > > > Attached diff contains the required changes for msvc. The diff is from my > local git repo created from the 3.1.4 release. > Added new macro XERCES_USE_CHAR16_T. > User can enable the support by define this macro both when building the > library and her own application. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: c-dev-unsubscr...@xerces.apache.org For additional commands, e-mail: c-dev-h...@xerces.apache.org
[jira] [Commented] (XERCESC-2101) Add support for XERCES_XMLCH_T = char16_t
[
https://issues.apache.org/jira/browse/XERCESC-2101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16049226#comment-16049226
]
Roger Leigh commented on XERCESC-2101:
--
- [Unix build
results|https://travis-ci.org/rleigh-codelibre/xerces-c/builds/242814234]
- [Windows build
results|https://ci.appveyor.com/project/rleigh-codelibre/xerces-c/build/1.0.92]
All builds have passed using a mixture of old and new compilers using the
previous defaults and char16_t, respectively.
Overall, this is a fairly trivial change to a typedef with the changes to the
supporting build infrastructure to detect and enable it. It enables the use of
{{u"Unicode string"}}, which offers a significant usability improvement for end
users of the library API, as well as a potential minor performance improvement
by removing the need to transcode from 8-bit strings. No need to transcode to
wide strings for every element and attribute name, it's all handled at compile
time by the compiler.
> Add support for XERCES_XMLCH_T = char16_t
> -
>
> Key: XERCESC-2101
> URL: https://issues.apache.org/jira/browse/XERCESC-2101
> Project: Xerces-C++
> Issue Type: Improvement
>Reporter: Vemund Handeland
>Priority: Minor
> Attachments:
> 0001-Add-Windows-support-for-XERCES_XMLCH_T-char16_t.patch,
> 0002-cmake-Check-for-char16_t.patch, 0003-autoconf-Check-for-char16_t.patch,
> char16_t.diff
>
>
> Attached diff contains the required changes for msvc. The diff is from my
> local git repo created from the 3.1.4 release.
> Added new macro XERCES_USE_CHAR16_T.
> User can enable the support by define this macro both when building the
> library and her own application.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: c-dev-unsubscr...@xerces.apache.org
For additional commands, e-mail: c-dev-h...@xerces.apache.org
