Re: ETag support broken on hackage.haskell.org

2014-06-16 Thread Gintautas Miliauskas
Hi, I spent some time looking into this and was able to get etags checking to work, see [1] [1] https://github.com/haskell/hackage-server/pull/236 However, my approach only deals with etags only for the index tarball. I poked around for quite a while seeing if there is a more general solution, b

Re: ETag support broken on hackage.haskell.org

2014-06-10 Thread Gintautas Miliauskas
I just checked and indeed hackage-server is ignoring the If-none-match header. I'll see if I can make it work. On Tue, Jun 10, 2014 at 11:38 AM, Duncan Coutts < duncan.cou...@googlemail.com> wrote: > I'm pretty sure it's the hackage-server. I think we simply don't have > code yet to react to the

Re: ETag support broken on hackage.haskell.org

2014-06-10 Thread Duncan Coutts
I'm pretty sure it's the hackage-server. I think we simply don't have code yet to react to the if-none-match. Happstack has some util for the time-based conditionals, but not the etag one. So it should just be a matter of us adding a combinator that both serves the etag and reacts to the if-none-ma

Re: ETag support broken on hackage.haskell.org

2014-06-10 Thread Johan Tibell
We need to figure out if nginx or the hackage-server is to blame here. On Tue, Jun 10, 2014 at 1:34 AM, Gintautas Miliauskas < gintautas.miliaus...@gmail.com> wrote: > Hi, > > first of all, a shout out to all ZuriHac2014 folks, thanks for the gentle > introduction to the deeper trenches of Haske