Hi Vilius,
> I did not know a PR is required.
It is. PRs automate a lot of things. Ci is run,
reviews are collected, including comments to specific
lines, and responded to via text and via code and marked
as done. The patch is automatically rebased and merged.
Backports are created, etc., etc.,
On Sat, 28 May 2022 14:30:30 -0600
emil...@cohomolo.gy wrote:
> gonna be completely honest - i appreciate the patches but i'm not
> going to go through the labor of applying something this trivial.
> Unless not using Github is a conscientious protest against ICE or
> their military contracts or th
On Sat, 28 May 2022 22:22:41 +0200
Mikolaj Konarski wrote:
> Here you go:
>
> https://github.com/haskell/cabal/pull/8176
>
> If there are review comments, I guess I will be copying them
> in emails to you and you will be sending me replies and new
> commits to paste into the pull request?
I di
gonna be completely honest - i appreciate the patches but i'm not going to go
through the labor of applying something this trivial. Unless not using Github
is a conscientious protest against ICE or their military contracts or the like
, i'm liable to just reject email patches that are not securi
Here you go:
https://github.com/haskell/cabal/pull/8176
If there are review comments, I guess I will be copying them
in emails to you and you will be sending me replies and new
commits to paste into the pull request?
All the best,
Mikolaj
On Sat, May 28, 2022 at 8:55 PM Vilius Panevėžys wrote:
Hi Mikolaj,
thank you for the prompt reply!
On Sat, 28 May 2022 17:10:24 +0200
Mikolaj Konarski wrote:
> Would you like to create a pull request on github with these changes
> to help us see them in context, e.g., whether they merge cleanly and
> which branch, and to help us credit you properly?
Hi Vilius,
Thank you for the patches. I've printed and read them
and they look good! Would you like to create a pull request
on github with these changes to help us see them in context,
e.g., whether they merge cleanly and which branch,
and to help us credit you properly? If you encounter any
prob
