Re: pre-710 compatibility stuff

2015-10-24 Thread lennart spitzner
On 24/10/15 15:05, Thomas Tuegel wrote: > MIN_VERSION_base is defined by Cabal, so it is not available during > bootstrapping. This means we unfortunately need to use > __GLASGOW_HASKELL__ in Cabal, even though it isn't really the right > macro. It should be safe to use MIN_VERSION_base in cabal-in

Re: pre-710 compatibility stuff

2015-10-24 Thread Thomas Tuegel
On Sat, Oct 24, 2015 at 10:00 AM, Herbert Valerio Riedel wrote: > On 2015-10-24 at 15:05:44 +0200, Thomas Tuegel wrote: > > [...] > >> MIN_VERSION_base is defined by Cabal, so it is not available during >> bootstrapping. > > yes, and that's why we have a cabal_macros_boot.h in GHC's build-system >

Re: pre-710 compatibility stuff

2015-10-24 Thread Herbert Valerio Riedel
On 2015-10-24 at 15:05:44 +0200, Thomas Tuegel wrote: [...] > MIN_VERSION_base is defined by Cabal, so it is not available during > bootstrapping. yes, and that's why we have a cabal_macros_boot.h in GHC's build-system for bootstrapping purposes, http://git.haskell.org/ghc.git/blob/HEAD:/util

Re: pre-710 compatibility stuff

2015-10-24 Thread Thomas Tuegel
On Sat, Oct 24, 2015 at 5:19 AM, lennart spitzner wrote: > hi, > > should we use > #if __GLASGOW_HASKELL__ < 710 > or > #if !MIN_VERSION_base(4,8,0) > ? > > currently both are used in different places, and i have no idea if > there is a difference/if it matters. if it does not, i suggest > convent

Re: pre-710 compatibility stuff

2015-10-24 Thread Herbert Valerio Riedel
On 2015-10-24 at 12:19:38 +0200, lennart spitzner wrote: > hi, > > should we use > #if __GLASGOW_HASKELL__ < 710 > or > #if !MIN_VERSION_base(4,8,0) > ? > > currently both are used in different places, and i have no idea if > there is a difference/if it matters. if it does not, i suggest > conventi