Re: Code style guide?

2013-03-23 Thread Brent Yorgey
On Thu, Mar 21, 2013 at 01:21:11PM -0700, Johan Tibell wrote: On Thu, Mar 21, 2013 at 12:48 PM, Ben Millwood hask...@benmachine.co.ukwrote: I'm in favour of the first style, and if there's no objections, the patch I'm currently writing will be split into two commits, the first of which

Re: Code style guide?

2013-03-22 Thread Duncan Coutts
On Tue, 2013-03-19 at 07:29 -0700, Johan Tibell wrote: On Tue, Mar 19, 2013 at 6:35 AM, Duncan Coutts duncan.cou...@googlemail.com wrote: Go for it! You'll also notice that the code uses different styles in different places (because of different authors). We've not gone through and

Re: Code style guide?

2013-03-21 Thread Ben Millwood
On Tue, Mar 19, 2013 at 07:29:27AM -0700, Johan Tibell wrote: If you need to write a style guide, why not use https://github.com/tibbe/haskell-style-guide/blob/master/haskell-style.md as a starting point. It's widely used in the Haskell community nowadays (e.g. it's a common recommendation on

Re: Code style guide?

2013-03-21 Thread Johan Tibell
On Thu, Mar 21, 2013 at 12:48 PM, Ben Millwood hask...@benmachine.co.ukwrote: I'm in favour of the first style, and if there's no objections, the patch I'm currently writing will be split into two commits, the first of which will beautify all the import lists I'm going to touch, and the second

Re: Code style guide?

2013-03-19 Thread Duncan Coutts
On Tue, 2013-03-19 at 00:15 +, Ben Millwood wrote: Hi everyone, Do we have a general notion of what we consider best practices for contributed code to Cabal? Perhaps we should formalise something? One of the reasons I wanted to get the wiki back online was in the hope that it had

Re: Code style guide?

2013-03-19 Thread Johan Tibell
On Tue, Mar 19, 2013 at 6:35 AM, Duncan Coutts duncan.cou...@googlemail.com wrote: Go for it! You'll also notice that the code uses different styles in different places (because of different authors). We've not gone through and tidied stuff up because we're lazy and because there never

Re: Code style guide?

2013-03-19 Thread Gregory Collins
+1 for stylish-haskell --- I have it enabled in my save-hook for most of my patches. It would be good to check in a stylish haskell YAML dotfile into the repo with some sane/uncontroversial settings (I like the horizontal alignment but a lot of people don't), then make a one-time pass over the

Re: Code style guide?

2013-03-19 Thread Jason Dagit
On Tue, Mar 19, 2013 at 7:29 AM, Johan Tibell johan.tib...@gmail.comwrote: On Tue, Mar 19, 2013 at 6:35 AM, Duncan Coutts duncan.cou...@googlemail.com wrote: Go for it! You'll also notice that the code uses different styles in different places (because of different authors). We've not

Re: Code style guide?

2013-03-19 Thread Johan Tibell
Hi Jason, On Tue, Mar 19, 2013 at 10:49 AM, Jason Dagit dag...@gmail.com wrote: There are a few recommendations in that guide that I'm not a fan of. Below are the main ones. I'm confident that for each Haskell programmer out there there are a few recommendations that Haskell programmer is

Re: Code style guide?

2013-03-19 Thread Ben Millwood
On Tue, Mar 19, 2013 at 07:29:27AM -0700, Johan Tibell wrote: If you need to write a style guide, why not use https://github.com/tibbe/haskell-style-guide/blob/master/haskell-style.md as a starting point. It's widely used in the Haskell community nowadays (e.g. it's a common recommendation on

Code style guide?

2013-03-18 Thread Ben Millwood
Hi everyone, Do we have a general notion of what we consider best practices for contributed code to Cabal? Perhaps we should formalise something? One of the reasons I wanted to get the wiki back online was in the hope that it had some pointers, but it doesn't seem to. (I've started

Re: Code style guide?

2013-03-18 Thread Jason Dagit
On Mon, Mar 18, 2013 at 5:15 PM, Ben Millwood hask...@benmachine.co.ukwrote: Hi everyone, Do we have a general notion of what we consider best practices for contributed code to Cabal? Perhaps we should formalise something? One of the reasons I wanted to get the wiki back online was in the