Re: [Cake] [PATCH 0/3] net/sched: Load modules via alias

2023-12-06 Thread Stephen Hemminger via Cake
On Wed, 6 Dec 2023 23:49:14 +0100 Michal Koutný wrote: > On Wed, Dec 06, 2023 at 02:28:57PM -0800, Stephen Hemminger > wrote: > > It is not clear to me what this patchset is trying to fix. > > Autoloading happens now, but it does depend on the name not alias. > > The

Re: [Cake] [PATCH 0/3] net/sched: Load modules via alias

2023-12-06 Thread Stephen Hemminger via Cake
On Wed, 6 Dec 2023 22:18:25 +0100 Michal Koutný wrote: > On Wed, Dec 06, 2023 at 05:16:28PM -0300, Pedro Tammela > wrote: > > Can't you just keep the sch-, cls-, act- prefixes for the aliases? > > They look odd in the current patchset TBH > > I'm open to different better naming. > > Althoug

Re: [Cake] vyos w/fq_codel and cake

2023-10-11 Thread Stephen Hemminger via Cake
On Wed, 11 Oct 2023 08:26:17 -0700 Dave Taht wrote: > After successfully having got them to switch the default over to > fq_codel last week, > I started looking over their very old skool traffic shaping policies. > Does anyone here use vyos? I used to really like it, but kind of went > pure openw

Re: [Cake] Cake - flow (or host) weight request - how to implement

2023-09-27 Thread Stephen Hemminger via Cake
On Wed, 27 Sep 2023 17:48:06 + Jan Rovner via Cake wrote: > Hello, > > I am trying to experiment with sch_cake.c, my goal is to ad-hoc prioritize / > deprioritize traffic served to specified a host(s). The prioritization would > be controlled by an external system and it should handle well

Re: [Cake] [Bloat] Two questions re high speed congestionmanagement anddatagram protocols

2023-07-10 Thread Stephen Hemminger via Cake
On Mon, 10 Jul 2023 23:27:46 +0200 Sebastian Moeller wrote: > For what it is worth, the tsv working group is considering whether to process > mp-dccp on the standards track, but then the IETF seems not to care too > deeply about open-source licence compliance. Or recent kernel implementations

Re: [Cake] [Bloat] Two questions re high speed congestionmanagement anddatagram protocols

2023-07-10 Thread Stephen Hemminger via Cake
On Wed, 28 Jun 2023 10:32:32 -0400 (EDT) "David P. Reed" wrote: > How to find a kernel maintainer to care about DCCP, seems to be the question > for Linux. > I am tempted... Not to get involved with IETF "barriers" (what a mess, given > the folks in IETF who resisted in AQM, I wouldn't last a m

Re: [Cake] [Bloat] Two questions re high speed congestion management anddatagram protocols

2023-06-27 Thread Stephen Hemminger via Cake
On Tue, 27 Jun 2023 12:47:01 -0700 (PDT) David Lang wrote: > On Mon, 26 Jun 2023, David P. Reed via Bloat wrote: > > > Sorry for top posting, but ... Bigger question: > > Why would DCCP be deprecated by Linux kernel? > > Who makes that decision? Who argues against it? > > Linus or the network

Re: [Cake] [Bloat] Two questions re high speed congestion management anddatagram protocols

2023-06-27 Thread Stephen Hemminger via Cake
On Mon, 26 Jun 2023 23:41:59 -0400 (EDT) "David P. Reed" wrote: > Sorry for top posting, but ... Bigger question: > Why would DCCP be deprecated by Linux kernel? > Who makes that decision? Who argues against it? No one uses it, and unused protocols are targeted by hackers. And there are few test

Re: [Cake] [Bloat] Two questions re high speed congestion management and datagram protocols

2023-06-25 Thread Stephen Hemminger via Cake
On Sat, 24 Jun 2023 14:41:52 -0400 (EDT) "David P. Reed via Bloat" wrote: > I also was looking back to DCCP as a useful way to get a UDP that handled > congestion without engaging the higher layers, and preserving the other > flexibility of UDP. DCCP never got widely used, and Linux is on the

Re: [Cake] [Bloat] [Make-wifi-fast] The most wonderful video ever about bufferbloat

2022-10-19 Thread Stephen Hemminger via Cake
On Wed, 19 Oct 2022 14:33:28 -0700 (PDT) David Lang via Bloat wrote: > On Wed, 19 Oct 2022, Stuart Cheshire via Bloat wrote: > > > On Mon, Oct 17, 2022 at 5:02 PM Stuart Cheshire wrote: > > > >> Accuracy be damned. The analogy to common experience resonates more. > > > > I feel it is not an

Re: [Cake] cake srchost/dsthost stopped working?

2021-08-10 Thread Stephen Hemminger
On Wed, 04 Aug 2021 13:14:30 +0200 Toke Høiland-Jørgensen via Cake wrote: > + else if (use_skbhash && flow_mode & CAKE_FLOW_FLOWS) I think some compilers and static checkers are going to give a warning unless you add a parenthesis in this statement.

Re: [Cake] [Cerowrt-devel] merlin gains cake support

2021-03-03 Thread Stephen Hemminger
On Wed, 3 Mar 2021 09:12:36 -0800 Dave Taht wrote: > it was the fact there is a cake port at all that was so exciting, and > that some broadcom APIs existed, even more so. > > On Wed, Mar 3, 2021 at 9:09 AM Toke Høiland-Jørgensen wrote: > > > > Dave Taht writes: > > > > > https://github.com/

Re: [Cake] [Bloat] Fwd: [Galene] Dave on bufferbloat and jitter at 8pm CET Tuesday 23

2021-02-23 Thread Stephen Hemminger
On Tue, 23 Feb 2021 17:14:31 -0800 Dave Taht wrote: > wow, that is (predictably) miserable, even with cake. The only > solution that is going to > work is to somehow actively monitor your link quality and adjust cake > to suit. Or we can start trying to use kathie's passive ping tools. > > On Tu

Re: [Cake] [PATCH net-next 1/5] sch_cake: fix IP protocol handling in the presence of VLAN tags

2020-06-26 Thread Stephen Hemminger
On Fri, 26 Jun 2020 16:11:49 +0300 Jonathan Morton wrote: > Toke has already replied, but: > > > Sure, my proposal does not cover the problem of mangling the CE bit inside > > VLAN-tagged packets, i.e. if we should understand if qdiscs should allow > > it or not. > > This is clearly wrong-hea

Re: [Cake] DSCP ramblings

2020-04-22 Thread Stephen Hemminger
On Wed, 22 Apr 2020 09:20:29 -0700 Dave Taht wrote: > and because of your I'm off building collectd because those graphs > look so good. :) > > https://forum.openwrt.org/t/sqm-reporting/59960/24 > > I have long just used snmpd, and collectd looks interesting. I fear > it's too heavyweight, part

Re: [Cake] Fwd: Re: Unable to create htb tc classes more than 64K

2019-08-27 Thread Stephen Hemminger
On Mon, 26 Aug 2019 09:35:14 +0200 Toke Høiland-Jørgensen wrote: > Turns out that with the "earliest departure time" support in sched_fq, > it is now possible to write a shaper in eBPF, thus avoiding the global > qdisc lock in sched_htb. This is pretty cool, if you ask me! :) > > -Toke > Thank

Re: [Cake] [PATCH iproute2] q_cake: Add support for setting the fwmark option

2019-04-05 Thread Stephen Hemminger
On Thu, 4 Apr 2019 15:09:10 +0200 Toke Høiland-Jørgensen wrote: > This adds support for the newly added fwmark option to CAKE, which allows > overriding the tin selection from the per-packet firewall marks. The fwmark > field is a bitmask that is applied to the fwmark to select the tin. > > Sig

Re: [Cake] [PATCH net 2/2] sch_cake: Make sure we can write the IP header before changing DSCP bits

2019-04-04 Thread Stephen Hemminger
On Thu, 04 Apr 2019 22:44:33 +0200 Toke Høiland-Jørgensen wrote: > Stephen Hemminger writes: > > > On Thu, 04 Apr 2019 15:01:33 +0200 > > Toke Høiland-Jørgensen wrote: > > > >> static u8 cake_handle_diffserv(struct sk_buff *skb, u16 wash) > >> {

Re: [Cake] [PATCH net 2/2] sch_cake: Make sure we can write the IP header before changing DSCP bits

2019-04-04 Thread Stephen Hemminger
On Thu, 04 Apr 2019 15:01:33 +0200 Toke Høiland-Jørgensen wrote: > static u8 cake_handle_diffserv(struct sk_buff *skb, u16 wash) > { > + int wlen = skb_network_offset(skb); In theory this could be negative, you should handle that? Rather than calling may_pull() with a huge unsigned value.

Re: [Cake] [Ecn-sane] The two SCE tests I have in mind

2019-04-01 Thread Stephen Hemminger
On Sun, 24 Mar 2019 13:32:03 +0100 Michael Richardson wrote: > Jonathan Morton wrote: > >> On 24 Mar, 2019, at 12:05 pm, Pete Heist wrote: > >> > >> tcpdump -r file.pcap udp port 2112 and greater 80 and "ip[1] != 0x1” > >> > >> “greater 80” ignores the handshake packets an

Re: [Cake] Ingress classification

2019-02-06 Thread Stephen Hemminger
On Wed, 6 Feb 2019 12:52:22 + Kevin Darbyshire-Bryant wrote: > > On 5 Feb 2019, at 13:38, John Sager wrote: > > > > As you say, an unsolicited incoming packet doesn't get marked. However it > > creates a conntrack record with zero mark. What you then do is to mark the > > conntrack record l

Re: [Cake] Emulating Bufferbloat

2018-11-22 Thread Stephen Hemminger
On Thu, 22 Nov 2018 12:28:36 -0800 Fabian Ruffy wrote: > Hello, > > this is a somewhat esoteric question. I am trying to actually force > bufferbloat in an emulation setup I am using. I set up a dumbbell topology > and push traffic through it, causing congestion at the central link. I use > t

Re: [Cake] [PATCH iproute2] q_cake: Also print nonat, nowash and no-ack-filter keywords

2018-09-14 Thread Stephen Hemminger
On Fri, 14 Sep 2018 15:51:39 +0200 Toke Høiland-Jørgensen wrote: > Similar to the previous patch for no-split-gso, the negative keywords for > 'nat', 'wash' and 'ack-filter' were not printed either. Add those well. > > Signed-off-by: Toke Høiland-Jørgensen Applied, thanks.

Re: [Cake] passing args to bpf programs

2018-08-01 Thread Stephen Hemminger
On Wed, 1 Aug 2018 09:22:41 -0700 Dave Taht wrote: > this really isn't the right list for this... but I wanted to build on > the ack_filter bpf code I had, to create impairments, like dropping > acks every X packets, or randomly, or when a specific pattern is seen > (like timestamps or sack). Thi

Re: [Cake] fq in p4

2018-07-26 Thread Stephen Hemminger
Typical academic paper testing with Reno. At least they compared DCTCP On Wed, Jul 25, 2018, 10:04 PM Dave Taht wrote: > https://homes.cs.washington.edu/~arvind/papers/afq.pdf > > -- > > Dave Täht > CEO, TekLibre, LLC > http://www.teklibre.com > Tel: 1-669-226-2619 >

Re: [Cake] [PATCH iproute2-next v10] Add support for CAKE qdisc

2018-07-16 Thread Stephen Hemminger
On Mon, 16 Jul 2018 19:56:00 +0200 Toke Høiland-Jørgensen wrote: > Stephen Hemminger writes: > > > On Mon, 16 Jul 2018 18:39:26 +0200 > > Toke Høiland-Jørgensen wrote: > > > >> +#define PRINT_TSTAT(name, attr, fmts, val)do {\ > >>

Re: [Cake] [PATCH iproute2-next v10] Add support for CAKE qdisc

2018-07-16 Thread Stephen Hemminger
On Mon, 16 Jul 2018 18:39:26 +0200 Toke Høiland-Jørgensen wrote: > +#define PRINT_TSTAT(name, attr, fmts, val) do {\ > + if (GET_TSTAT(0, attr)) { \ > + fprintf(f, name); \ > + fo

Re: [Cake] Bandwidith rate by host instead of global while using [dual-]srchost and [dual-]dsthost

2018-06-11 Thread Stephen Hemminger
On Mon, 11 Jun 2018 21:44:25 +0200 Toke Høiland-Jørgensen wrote: > Michel Blais writes: > > > Hi all, > > > > Is it possible while using srchost, or dual-srchost, and dsthost, or > > dual-dsthost, to do a bandwidth limitation by host instead of global ? From > > what I read, seem like not. >

Re: [Cake] [PATCH iproute2-next v7] Add support for cake qdisc

2018-04-27 Thread Stephen Hemminger
On Fri, 27 Apr 2018 21:57:20 +0200 Toke Høiland-Jørgensen wrote: > sch_cake is intended to squeeze the most bandwidth and latency out of even > the slowest ISP links and routers, while presenting an API simple enough > that even an ISP can configure it. > > Example of use on a cable ISP uplink:

Re: [Cake] [PATCH iproute2-next v5] Add support for cake qdisc

2018-04-27 Thread Stephen Hemminger
On Fri, 27 Apr 2018 14:17:06 +0200 Toke Høiland-Jørgensen wrote: > + } else if (strcmp(*argv, "datacentre") == 0) { > + interval = 100; > + target = 5; > + } else if (strcmp(*argv, "lan") == 0) { > + interval

Re: [Cake] CAKE upstreaming - testers wanted, ACK filtering rescuers needed

2018-04-25 Thread Stephen Hemminger
On Thu, 26 Apr 2018 10:40:29 +0930 Ryan Mounce wrote: > I'll investigate making the ACK filtering code safe, it is my mess after all > :) > > Eric obviously understands this stuff a lot better than me, it looks > like there are two issues? > - Lack of minimum length check for TCP header, should

Re: [Cake] [PATCH net-next v2] Add Common Applications Kept Enhanced (cake) qdisc

2018-04-24 Thread Stephen Hemminger
On Tue, 24 Apr 2018 13:44:06 +0200 Toke Høiland-Jørgensen wrote: > +static const u8 precedence[] = {0, 0, 0, 0, 0, 0, 0, 0, > + 1, 1, 1, 1, 1, 1, 1, 1, > + 2, 2, 2, 2, 2, 2, 2, 2, > + 3, 3, 3, 3, 3, 3, 3, 3, > +

Re: [Cake] [PATCH net-next v2] Add Common Applications Kept Enhanced (cake) qdisc

2018-04-24 Thread Stephen Hemminger
On Tue, 24 Apr 2018 13:44:06 +0200 Toke Høiland-Jørgensen wrote: > +struct tc_cake_xstats { > + __u16 version; > + __u16 tin_stats_size; /* == sizeof(struct tc_cake_tin_stats) */ > + __u32 capacity_estimate; > + __u32 memory_limit; > + __u32 memory_used; > + __u8 tin_cnt;

Re: [Cake] [PATCH iproute2-next v3] Add support for cake qdisc

2018-04-24 Thread Stephen Hemminger
On Tue, 24 Apr 2018 16:52:57 +0200 Toke Høiland-Jørgensen wrote: > Well, this is leftover from keeping track of different versions of the > out-of-tree patch, and we already broke compatibility pretty thoroughly > as a preparation for upstreaming. So I'm fine with dropping the version > check; wi

Re: [Cake] [PATCH iproute2-next v3] Add support for cake qdisc

2018-04-24 Thread Stephen Hemminger
On Tue, 24 Apr 2018 14:30:46 +0200 Toke Høiland-Jørgensen wrote: > +static void cake_print_json_tin(struct tc_cake_tin_stats *tst, uint version) > +{ > + open_json_object(NULL); > + print_uint(PRINT_JSON, "threshold_rate", NULL, tst->threshold_rate); > + print_uint(PRINT_JSON, "target

Re: [Cake] [PATCH iproute2-next v3] Add support for cake qdisc

2018-04-24 Thread Stephen Hemminger
On Tue, 24 Apr 2018 14:30:46 +0200 Toke Høiland-Jørgensen wrote: > diff --git a/tc/q_cake.c b/tc/q_cake.c > new file mode 100644 > index ..12263361 > --- /dev/null > +++ b/tc/q_cake.c > @@ -0,0 +1,778 @@ > +/* SPDX-License-Identifier: (GPL-2.0 OR BSD-3-Clause) */ > +/* > + * Common Applic

Re: [Cake] [PATCH 1/2] cake: print_uint format fixes

2018-03-12 Thread Stephen Hemminger
On Mon, 12 Mar 2018 10:56:09 +0100 Toke Høiland-Jørgensen wrote: > Kevin Darbyshire-Bryant writes: > > >> On 11 Mar 2018, at 23:34, Stephen Hemminger > >> wrote: > >> > >> On Sun, 11 Mar 2018 22:10:51 + > >> Kevin Darbyshire-Bryant w

Re: [Cake] [PATCH 1/2] cake: print_uint format fixes

2018-03-11 Thread Stephen Hemminger
On Sun, 11 Mar 2018 22:10:51 + Kevin Darbyshire-Bryant wrote: > negative? > > Tried it, and you’d sort of guess wrong. I’ll write it up tomorrow > ‘properly’ but ‘int’ is int length whereas uint is uint64 length. On big > endian it goes wrong. > > Anyway, glad you’ve tested on someth

Re: [Cake] [PATCH] q_cake: Update xstats format to use per-tin structure

2018-03-06 Thread Stephen Hemminger
On Sun, 11 Feb 2018 18:26:18 +0100 Toke Høiland-Jørgensen wrote: > This updates tc to understand the updated cake xstats structure (which > splits out the tin stats in a separate structure the length of which is > included in the containing struct). > > Old versions of the cake stats will no lon

Re: [Cake] [Bloat] benefits of ack filtering

2017-11-29 Thread Stephen Hemminger
On Wed, 29 Nov 2017 10:41:41 -0800 Dave Taht wrote: > On Wed, Nov 29, 2017 at 10:21 AM, Juliusz Chroboczek wrote: > >> The better solution would of course be to have the TCP peeps change the > >> way TCP works so that it sends fewer ACKs. > > > > Which tends to perturb the way the TCP self-clo

Re: [Cake] [PATCH 1/3] pkt_sched.h: add support for sch_cake API

2017-11-22 Thread Stephen Hemminger
On Tue, 21 Nov 2017 16:58:54 -0800 Dave Taht wrote: > Stephen Hemminger writes: > > > On Tue, 21 Nov 2017 16:09:40 -0800 > > Dave Taht wrote: > > > >> > >> +/* CAKE */ > >> +enum { > >> + TCA_CAKE_UNSPEC, > >> + TCA

Re: [Cake] [PATCH 1/3] pkt_sched.h: add support for sch_cake API

2017-11-21 Thread Stephen Hemminger
On Tue, 21 Nov 2017 16:09:40 -0800 Dave Taht wrote: > > +/* CAKE */ > +enum { > + TCA_CAKE_UNSPEC, > + TCA_CAKE_BASE_RATE, > + TCA_CAKE_DIFFSERV_MODE, > + TCA_CAKE_ATM, > + TCA_CAKE_FLOW_MODE, > + TCA_CAKE_OVERHEAD, > + TCA_CAKE_RTT, > + TCA_CAKE_TARGET, > +

Re: [Cake] [RFC PATCH 1/5] Update to the actual net-next

2017-11-17 Thread Stephen Hemminger
On Fri, 17 Nov 2017 13:19:24 -0800 Dave Taht wrote: > --- > include/uapi/linux/pkt_sched.h | 10 ++ > 1 file changed, 10 insertions(+) > > diff --git a/include/uapi/linux/pkt_sched.h b/include/uapi/linux/pkt_sched.h > index 6a2c5ea..af3cc2f 100644 > --- a/include/uapi/linux/pkt_sched.h

Re: [Cake] Cake on LEDE - package maintainer required

2017-06-27 Thread Stephen Hemminger
On Wed, 21 Jun 2017 17:42:20 -0700 Dave Taht wrote: > I have long sought sufficient funding to push cake into the mainstream > and come up empty. Cake represents thousands of hours of volunteer labor > as it is, and everyone that has worked on it deserves kudos... > > ... and a check... > > or

Re: [Cake] Cake on LEDE - package maintainer required

2017-06-13 Thread Stephen Hemminger
On Tue, 13 Jun 2017 18:41:05 +0100 Kevin Darbyshire-Bryant wrote: > Hi All, > > This email finds me looking for a volunteer/s to take over the ownership > of the cake qdisc module package in LEDE. > > It's not particularly onerous, in essence making sure the package points > at the git commit

Re: [Cake] [Make-wifi-fast] flent testers wanted prior to next release

2017-01-31 Thread Stephen Hemminger
On Tue, 31 Jan 2017 17:35:40 +0100 Toke Høiland-Jørgensen wrote: > Stephen Hemminger writes: > > > On Tue, 20 Dec 2016 11:02:44 -0800 > > Dave Taht wrote: > > > >> Toke has been busy adding new features to the flent network test tool. > >> I co

Re: [Cake] flent testers wanted prior to next release

2017-01-31 Thread Stephen Hemminger
On Tue, 20 Dec 2016 11:02:44 -0800 Dave Taht wrote: > Toke has been busy adding new features to the flent network test tool. > I consider it *almost* stable enough for a new release. Some of the > development has been focused on making the flent-gui much faster and > more responsive (as our data

Re: [Cake] upstreaming cake in 2017?

2016-12-22 Thread Stephen Hemminger
On Thu, 22 Dec 2016 21:02:28 +0100 Sebastian Moeller wrote: > Hi Dave, > > > On Dec 22, 2016, at 20:43, Dave Taht wrote: > > > > I think most of the reasons why cake could not be upstreamed are now > > on their way towards being resolved, and after lede ships, I can't > > think of any left to

Re: [Cake] Fwd: [Codel] fq_codel_drop vs a udp flood

2016-05-06 Thread Stephen Hemminger
On Fri, 6 May 2016 02:00:02 -0700 (PDT) David Lang wrote: > On Fri, 6 May 2016, moeller0 wrote: > > > Hi Jonathan, > > > >> On May 6, 2016, at 06:44 , Jonathan Morton wrote: > >> > >> > >>> On 6 May, 2016, at 07:35, Dave Taht wrote: > >>> > >>> this would be a pretty nifty feature for cake

Re: [Cake] [Bloat] are anyone playing with dpdk and vpp?

2016-04-27 Thread Stephen Hemminger
DPDK gets impressive performance on large systems (like 14M packets/sec per core), but not convinced on smaller systems. Performance depends on having good CPU cache. I get poor performance on Atom etc. Also driver support is limited (mostly 10G and above) On Wed, Apr 27, 2016 at 12:28 PM, Aaron W

Re: [Cake] cake separate qos for lan

2016-03-28 Thread Stephen Hemminger
On Mon, 28 Mar 2016 22:20:58 +0300 Jonathan Morton wrote: > Did you try the IMQ alternative? I don’t see any reason why it shouldn’t > work, as long as you can build a kernel with IMQ support. IMQ was abandoned by original author because there was no way to make it reliable and SMP safe.