Re: [Cake] [PATCH net-next v8 1/7] sched: Add Common Applications Kept Enhanced (cake) qdisc

On Mon, May 7, 2018 at 11:37 AM, Toke Høiland-Jørgensen wrote: > Cong Wang writes: > >> On Fri, May 4, 2018 at 12:10 PM, Toke Høiland-Jørgensen wrote: >>> Thank you for the review! A few comments below, I'll fix the rest. >>> [...]

Re: [Cake] [PATCH net-next v8 1/7] sched: Add Common Applications Kept Enhanced (cake) qdisc

Cong Wang writes: > On Fri, May 4, 2018 at 12:10 PM, Toke Høiland-Jørgensen wrote: >> Thank you for the review! A few comments below, I'll fix the rest. >> >>> [...] >>> >>> So sch_cake doesn't accept normal tc filters? Is this intentional? >>> If so,

Re: [Cake] [PATCH net-next v8 1/7] sched: Add Common Applications Kept Enhanced (cake) qdisc

On Fri, May 4, 2018 at 12:10 PM, Toke Høiland-Jørgensen wrote: > Thank you for the review! A few comments below, I'll fix the rest. > >> [...] >> >> So sch_cake doesn't accept normal tc filters? Is this intentional? >> If so, why? > > For two reasons: > > - The two-level scheduling

Re: [Cake] [PATCH net-next v8 1/7] sched: Add Common Applications Kept Enhanced (cake) qdisc

Thank you for the review! A few comments below, I'll fix the rest. > [...] > > So sch_cake doesn't accept normal tc filters? Is this intentional? > If so, why? For two reasons: - The two-level scheduling used in CAKE (tins / diffserv classes, and flow hashing) does not map in an obvious way

[Cake] [PATCH net-next v8 1/7] sched: Add Common Applications Kept Enhanced (cake) qdisc

sch_cake targets the home router use case and is intended to squeeze the most bandwidth and latency out of even the slowest ISP links and routers, while presenting an API simple enough that even an ISP can configure it. Example of use on a cable ISP uplink: tc qdisc add dev eth0 cake bandwidth