Re: [Cake] BUG_ON vs WARN_ON

2016-10-07 Thread Kevin Darbyshire-Bryant
On 07/10/16 14:35, Jonathan Morton wrote: On 7 Oct, 2016, at 16:27, Kevin Darbyshire-Bryant wrote: It's now ok...so far :-) Okay. I think I’ve found a couple of other things to improve, so stand by… I'm not sure I can take all this excitement you know :) __

Re: [Cake] BUG_ON vs WARN_ON

2016-10-07 Thread Jonathan Morton
> On 7 Oct, 2016, at 16:27, Kevin Darbyshire-Bryant > wrote: > > It's now ok...so far :-) Okay. I think I’ve found a couple of other things to improve, so stand by… - Jonathan Morton ___ Cake mailing list Cake@lists.bufferbloat.net https://lists.

Re: [Cake] BUG_ON vs WARN_ON

2016-10-07 Thread Kevin Darbyshire-Bryant
On 05/10/16 19:53, Jonathan Morton wrote: I wonder what it was that caused yesterday's issues? I really must try again when I've more time to get proper access. I’m having trouble reproducing it here. I know one of my boxes froze the very first time I loaded it, but it’s been running fine e

Re: [Cake] BUG_ON vs WARN_ON

2016-10-06 Thread Jonathan Morton
> On 6 Oct, 2016, at 07:19, Dave Taht wrote: > > master Right - that’s stable code. I’m doing experimental stuff in the cobalt branch. - Jonathan Morton ___ Cake mailing list Cake@lists.bufferbloat.net https://lists.bufferbloat.net/listinfo/cake

Re: [Cake] BUG_ON vs WARN_ON

2016-10-05 Thread Dave Taht
master On Wed, Oct 5, 2016 at 8:59 PM, Kevin Darbyshire-Bryant wrote: > > > On 05/10/16 17:38, Dave Taht wrote: >> >> I cannot repeat that result this morning, with either replace or >> change. > > > Out of interest Dave, which branch are you building/testing? The 'master' > or 'cobalt'? --

Re: [Cake] BUG_ON vs WARN_ON

2016-10-05 Thread Kevin Darbyshire-Bryant
On 05/10/16 17:38, Dave Taht wrote: I cannot repeat that result this morning, with either replace or change. Out of interest Dave, which branch are you building/testing? The 'master' or 'cobalt'? ___ Cake mailing list Cake@lists.bufferbloat.net

Re: [Cake] BUG_ON vs WARN_ON

2016-10-05 Thread Jonathan Morton
>> I wonder what it was that caused yesterday's issues? I really must try >> again when I've more time to get proper access. > > I’m having trouble reproducing it here. I know one of my boxes froze the > very first time I loaded it, but it’s been running fine ever since. Another > machine is

Re: [Cake] BUG_ON vs WARN_ON

2016-10-05 Thread Dave Taht
I cannot repeat that result this morning, with either replace or change. I *was* running far more extensive tests between changing things that way than I just did, but a string of quick tests, changing the bandwidth, changing it to unlimited, etc got the correct behaviors throughout for both replac

Re: [Cake] BUG_ON vs WARN_ON

2016-10-05 Thread Jonathan Morton
> On 5 Oct, 2016, at 18:55, Kevin Darbyshire-Bryant > wrote: > > I don't trust tc replace and I'm pretty sure we've been here before. Does tc change (with the same arguments otherwise) behave any differently? - Jonathan Morton ___ Cake mailing lis

Re: [Cake] BUG_ON vs WARN_ON

2016-10-05 Thread Kevin Darbyshire-Bryant
On 05/10/16 16:53, Dave Taht wrote: I did test this version of cake yesterday, had no major problems, aside from: 1) it seeming not to register drops under some circumstances in the statistics. (could be flent) 2) switching stuff like this tc qdisc add dev eth0 root cake bandwidth 700mbit tc

Re: [Cake] BUG_ON vs WARN_ON

2016-10-05 Thread Dave Taht
I did test this version of cake yesterday, had no major problems, aside from: 1) it seeming not to register drops under some circumstances in the statistics. (could be flent) 2) switching stuff like this tc qdisc add dev eth0 root cake bandwidth 700mbit tc qdisc replace dev eth0 root cake bandwi

Re: [Cake] BUG_ON vs WARN_ON

2016-10-05 Thread Jonathan Morton
> On 5 Oct, 2016, at 18:45, Kevin Darbyshire-Bryant > wrote: > > I wonder what it was that caused yesterday's issues? I really must try again > when I've more time to get proper access. I’m having trouble reproducing it here. I know one of my boxes froze the very first time I loaded it, bu

Re: [Cake] BUG_ON vs WARN_ON

2016-10-05 Thread Kevin Darbyshire-Bryant
On 05/10/16 16:42, Jonathan Morton wrote: On 5 Oct, 2016, at 18:24, Kevin Darbyshire-Bryant wrote: How amenable are you to changing all 4 BUG_ON instances in cake to WARN_ON? Linus isn't a complete fan and I'm thinking that producing a stack trace and trying to carry on is more helpful to

Re: [Cake] BUG_ON vs WARN_ON

2016-10-05 Thread Jonathan Morton
> On 5 Oct, 2016, at 18:24, Kevin Darbyshire-Bryant > wrote: > > How amenable are you to changing all 4 BUG_ON instances in cake to WARN_ON? > > Linus isn't a complete fan and I'm thinking that producing a stack trace and > trying to carry on is more helpful to a remote accessed, no serial in

[Cake] BUG_ON vs WARN_ON

2016-10-05 Thread Kevin Darbyshire-Bryant
Hi Jonathan, How amenable are you to changing all 4 BUG_ON instances in cake to WARN_ON? Linus isn't a complete fan and I'm thinking that producing a stack trace and trying to carry on is more helpful to a remote accessed, no serial interface type device than just killing the kernel dead. Qu