Re: [Cake] cake in lede-17.01

2018-07-15 Thread Kevin Darbyshire-Bryant
> On 15 Jul 2018, at 17:13, Georgios Amanakis wrote: > > I am not sure we need this in 4.4. > In the patch we check for "d->tail->nla_type == padattr". > However, all gnet_stats_copy*() are defined without a padding attribute. Hmm, I wonder how they handle attribute alignment on MIPS….or

Re: [Cake] cake in lede-17.01

2018-07-15 Thread Georgios Amanakis
I am not sure we need this in 4.4. In the patch we check for "d->tail->nla_type == padattr". However, all gnet_stats_copy*() are defined without a padding attribute. On top of that on a TP-Link WR-941ND (ar71xx) the stats appear fine. Any insight would be greatly appreciated. George

Re: [Cake] cake in lede-17.01

2018-07-15 Thread Kevin Darbyshire-Bryant
> On 15 Jul 2018, at 14:32, Georgios Amanakis wrote: > > Dear All, > > I backported cake as of commit c91b94f and tc-adv as of 3968731 > (latest). I tested in a TP-Link WR-941NDv3 and everything looks ok, > including the stats. > > Could someone take a look at the pull requests? >

[Cake] cake in lede-17.01

2018-07-15 Thread Georgios Amanakis
Dear All, I backported cake as of commit c91b94f and tc-adv as of 3968731 (latest). I tested in a TP-Link WR-941NDv3 and everything looks ok, including the stats. Could someone take a look at the pull requests? https://github.com/openwrt/openwrt/pull/1180