Re: [Cake] de-natting & host fairness

2016-09-27 Thread Kevin Darbyshire-Bryant
Two buglets found: in sch_cake - the atm/ptm flag options are not passed back to tc userspace correctly - ptm isn't sent back. in tc/q_cake - the additional pre-set ptm+overhead options don't set 'overhead_set' so the overhead doesn't get used. On 28/09/16 04:06, Jonathan Morton wrote: O

Re: [Cake] de-natting & host fairness

2016-09-27 Thread Sebastian Moeller
Hi Jonathan, On September 28, 2016 1:08:04 AM GMT+02:00, Jonathan Morton wrote: > >> On 26 Sep, 2016, at 06:20, Kevin Darbyshire-Bryant > wrote: >> >> Another github user 'tegularius' presented some beautifully crafted >code that did the lookups in a much neater way. Originally it too had >an

Re: [Cake] de-natting & host fairness

2016-09-27 Thread Noah Causin
Thank you. On 9/28/2016 12:38 AM, Kevin Darbyshire-Bryant wrote: On 27/09/16 21:40, Noah Causin wrote: Thank you for all your help. The de-nat with dual-flow isolation works great. I tested it simultaneously with two separate virtual machines, one running a Flent 50 flows download test and

Re: [Cake] de-natting & host fairness

2016-09-27 Thread Kevin Darbyshire-Bryant
On 27/09/16 21:40, Noah Causin wrote: Thank you for all your help. The de-nat with dual-flow isolation works great. I tested it simultaneously with two separate virtual machines, one running a Flent 50 flows download test and the other running a Flent 8 flows download test. Throughput was ev

Re: [Cake] de-natting & host fairness

2016-09-27 Thread Jonathan Morton
> On 28 Sep, 2016, at 06:33, Kevin Darbyshire-Bryant > wrote: > > those ternaries are if/else in disguise... Many CPUs can handle those as conditional moves without branching - including ARM in particular; near-universal conditional execution was one of its original headline features. Most

Re: [Cake] de-natting & host fairness

2016-09-27 Thread Kevin Darbyshire-Bryant
On 28/09/16 04:06, Jonathan Morton wrote: On 28 Sep, 2016, at 05:56, Kevin Darbyshire-Bryant wrote: Does this need to be another variable/parameter or could it be the next bit along in the flow type? I’ve already pushed it to the ‘cobalt’ branch, so you can see how I’ve done it and start

Re: [Cake] de-natting & host fairness

2016-09-27 Thread Jonathan Morton
> On 28 Sep, 2016, at 05:56, Kevin Darbyshire-Bryant > wrote: > > Does this need to be another variable/parameter or could it be the next bit > along in the flow type? I’ve already pushed it to the ‘cobalt’ branch, so you can see how I’ve done it and start testing. I’ve verified that it com

Re: [Cake] de-natting & host fairness

2016-09-27 Thread Kevin Darbyshire-Bryant
On 28/09/16 00:08, Jonathan Morton wrote: On 26 Sep, 2016, at 06:20, Kevin Darbyshire-Bryant wrote: Another github user 'tegularius' presented some beautifully crafted code that did the lookups in a much neater way. Originally it too had an 'ingress' lookup problem. This was worked on and

Re: [Cake] de-natting & host fairness

2016-09-27 Thread Jonathan Morton
> On 26 Sep, 2016, at 06:20, Kevin Darbyshire-Bryant > wrote: > > Another github user 'tegularius' presented some beautifully crafted code that > did the lookups in a much neater way. Originally it too had an 'ingress' > lookup problem. This was worked on and I hacked some conditional 'dena

Re: [Cake] de-natting & host fairness

2016-09-27 Thread Jonathan Morton
> On 27 Sep, 2016, at 23:40, Noah Causin wrote: > > The de-nat with dual-flow isolation works great. I tested it simultaneously > with two separate virtual machines, one running a Flent 50 flows download > test and the other running a Flent 8 flows download test. Throughput was > even betwe

Re: [Cake] de-natting & host fairness

2016-09-27 Thread Noah Causin
Thank you for all your help. The de-nat with dual-flow isolation works great. I tested it simultaneously with two separate virtual machines, one running a Flent 50 flows download test and the other running a Flent 8 flows download test. Throughput was even between the machines, and the laten

Re: [Cake] cake for net-next 4.8

2016-09-27 Thread Jonathan Morton
> On 27 Sep, 2016, at 22:29, Dave Taht wrote: > > OK, at some point, but I have to abandon the lab, it looks like: Yet another reason to be glad I live in a cold and slightly damp country. > https://groups.google.com/forum/#!topic/bbr-dev/VNUBKAeJSdc If BBR is not currently responding to CE m

Re: [Cake] cake for net-next 4.8

2016-09-27 Thread Dave Taht
On Tue, Sep 27, 2016 at 11:56 AM, Jonathan Morton wrote: > >> On 27 Sep, 2016, at 21:18, Dave Taht wrote: >> >>> On Tue, Sep 27, 2016 at 10:52 AM, Jonathan Morton >>> wrote: >>> On 25 Sep, 2016, at 21:30, Dave Taht wrote: Judging from me tearing apart how TCP BBR works (presentl

Re: [Cake] cake for net-next 4.8

2016-09-27 Thread Jonathan Morton
> On 27 Sep, 2016, at 21:18, Dave Taht wrote: > >> On Tue, Sep 27, 2016 at 10:52 AM, Jonathan Morton >> wrote: >> >>> On 25 Sep, 2016, at 21:30, Dave Taht wrote: >>> >>> Judging from me tearing apart how TCP BBR works (presently) with ecn, >>> it looks like we need to add the equivalent to

Re: [Cake] cake for net-next 4.8

2016-09-27 Thread Dave Taht
On Tue, Sep 27, 2016 at 10:52 AM, Jonathan Morton wrote: > >> On 25 Sep, 2016, at 21:30, Dave Taht wrote: >> >> Judging from me tearing apart how TCP BBR works (presently) with ecn, >> it looks like we need to add the equivalent to fq_codel ce_threshold >> behaviors as well. > > If I’m reading th

Re: [Cake] cake for net-next 4.8

2016-09-27 Thread Jonathan Morton
> On 25 Sep, 2016, at 21:30, Dave Taht wrote: > > Judging from me tearing apart how TCP BBR works (presently) with ecn, > it looks like we need to add the equivalent to fq_codel ce_threshold > behaviors as well. If I’m reading the legend correctly, you are setting ce_threshold to 1ms to get th

Re: [Cake] cake for net-next 4.8

2016-09-27 Thread Jonathan Morton
> On 27 Sep, 2016, at 19:04, Dave Taht wrote: > > Annoying. Perhaps my link to the blog in my .sig? Perhaps they object > to my verbosity? This seems relevant in the headers: Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com; spf=pass (google.c

Re: [Cake] cake for net-next 4.8

2016-09-27 Thread Dave Taht
Annoying. Perhaps my link to the blog in my .sig? Perhaps they object to my verbosity? On Tue, Sep 27, 2016 at 7:38 AM, Jonathan Morton wrote: > >> On 25 Sep, 2016, at 21:30, Dave Taht wrote: >> >> I quickly got sch_cake to work on top of net next. The attached diff >> is probably not correct in

Re: [Cake] de-natting & host fairness

2016-09-27 Thread Kevin Darbyshire-Bryant
LEDE already has a patch included in the basefiles 'iproute2' package to make tc cake aware. If you replace package/network/utils/iproute2/patches/950-add-cake-to-tc.patch (which is unaware of the nat options) with the attached nat option aware version then recompile, you should find you've a

Re: [Cake] de-natting & host fairness

2016-09-27 Thread Noah Causin
Thank you for helping me get cake to compile on LEDE. The issue I have now is getting tc-adv to compile. I use this MakeFile: https://github.com/antoinedeschenes/openwrt-sqm/tree/master/net/tc-adv I use these commands to compile it: make package/feeds/sqm/tc-adv/clean -j 1 V=s make package/fee

Re: [Cake] cake for net-next 4.8

2016-09-27 Thread Jonathan Morton
> On 25 Sep, 2016, at 21:30, Dave Taht wrote: > > I quickly got sch_cake to work on top of net next. The attached diff > is probably not correct in some respect or another (what's to_free > for? And it looks like statistics collection has been parallelized > elsewhere) Yet another mail I had to