[Cake] trouble with cobalt

2017-11-25 Thread Dave Taht
https://seekingalpha.com/article/4127448-cobalt-cliff-two-dire-warnings-musk-soliloquy?page=2 -- Dave Täht CEO, TekLibre, LLC http://www.teklibre.com Tel: 1-669-226-2619 ___ Cake mailing list Cake@lists.bufferbloat.net https://lists.bufferbloat.net/lis

Re: [Cake] new patchset for upstream net-next

2017-11-25 Thread Dave Taht
awesome. On Sat, Nov 25, 2017 at 8:38 PM, wrote: > I am currently testing latest net-next with both sch_cake and > nf_conntrack compiled as integrals (Y instead of M). So far it works as > expected (previous build was 4.9.64, sch_cake out-of-tree, and > nf_conntrack as module). > > Are there any

Re: [Cake] new patchset for upstream net-next

2017-11-25 Thread gamanakis
I am currently testing latest net-next with both sch_cake and nf_conntrack compiled as integrals (Y instead of M). So far it works as expected (previous build was 4.9.64, sch_cake out-of-tree, and nf_conntrack as module). Are there any specific tests you would like me to run? I am attaching the p

Re: [Cake] new patchset for upstream net-next

2017-11-25 Thread gamanakis
Just finished building, setting both sch_cake and nf_conntrack as integral succeeds. Setting nf_conntrack as module fails with sch_cake as integral (makes sense). I am remote right now and cannot test the newly built kernel, hopefully I will get it done tonight. George On Sat, 2017-11-25 at 17:0

Re: [Cake] new patchset for upstream net-next

2017-11-25 Thread George Amanakis
I am giving it another try. nf_conntrack was built as a module. I am rebuilding on a clean dir, nf_conntrack set as integral this time. Will report soon. George On 11/25/2017 8:00 PM, Dave Taht wrote: I just got back from town and pushed a version that builds into the for_upstream_4.16 branc

Re: [Cake] new patchset for upstream net-next

2017-11-25 Thread Dave Taht
I just got back from town and pushed a version that builds into the for_upstream_4.16 branch, with kevins latest. Trying another build here, with "m", takes hours. thx for trying 'y'! As for what's going wrong... is nf_conntrack being built? as a module ? as integral? We've always built cake and

Re: [Cake] new patchset for upstream net-next

2017-11-25 Thread George Amanakis
grep'ing in net-next for nf_ct_get_tuplepr reveals these are still in use. On 11/25/2017 7:49 PM, George Amanakis wrote: I tried Kevin's latest commit, now it fails with:   CHK include/config/kernel.release   CHK include/generated/uapi/linux/version.h   DESCEND  objtool   CHK inclu

Re: [Cake] new patchset for upstream net-next

2017-11-25 Thread George Amanakis
I tried Kevin's latest commit, now it fails with:   CHK include/config/kernel.release   CHK include/generated/uapi/linux/version.h   DESCEND  objtool   CHK include/generated/utsrelease.h   CHK scripts/mod/devicetable-offsets.h   CHK include/generated/bounds.h   CHK include

Re: [Cake] allocate_src allocate_dst

2017-11-25 Thread Kevin Darbyshire-Bryant
https://github.com/dtaht/sch_cake/pull/74 Once again, sorry about the screwup. > On 25 Nov 2017, at 20:49, Kevin Darbyshire-Bryant > wrote: > > [This sender failed our fraud detection checks and may not be who they appear > to be. Learn about spoofing at http://aka.ms/LearnAboutSpoofing] > >

Re: [Cake] allocate_src allocate_dst

2017-11-25 Thread Kevin Darbyshire-Bryant
Ooops, sorry, dodge merge on my part from my work tree back to cobalt. A fix & PR will be with you shortly…. apologies. Kevin > On 25 Nov 2017, at 20:03, George Amanakis wrote: > > I think we missed an "allocate_host" in cake_hash(), line ~810: > > if (allocate_host) { > srchost_

Re: [Cake] allocate_src allocate_dst

2017-11-25 Thread George Amanakis
I think we missed an "allocate_host" in cake_hash(), line ~810: if (allocate_host) {             srchost_idx = srchost_hash % CAKE_QUEUES;             inner_hash = srchost_idx % CAKE_SET_WAYS;             outer_hash = srchost_idx - inner_hash;             for (i = 0, k = inner_hash; i < CAKE_SET_

Re: [Cake] allocate_src allocate_dst

2017-11-25 Thread Jonathan Morton
Gotos are fairly common in kernel code, chiefly for exception handling. Obviously structured code is still preferred where it makes sense, but there are cases where it would actually confuse matters. I hope to be able to spend most of tomorrow going over the code as it currently stands. I even ha

Re: [Cake] allocate_src allocate_dst

2017-11-25 Thread Pete Heist
> On Nov 25, 2017, at 5:48 PM, Dave Taht wrote: > > I am unfond of the gotos as well. But I'm gonna go do laundry. :) If > someone else beats me to it? To me the very occasional goto can be nice as an intellectual mint on your pillow- ooh, I didn’t expect to find that there, kind of thing. See

[Cake] new patchset for upstream net-next

2017-11-25 Thread Dave Taht
I fired off a build of this with the changes to allocate_src/dst that kevin just committed... which will take long enough for me to do laundry. Hopefully. Regardless, I'm out of action for 3 hrs. I'd certainly love it if others integrated this against net-next and tried it. In particular nobody (i

Re: [Cake] allocate_src allocate_dst

2017-11-25 Thread Kevin Darbyshire-Bryant
> On 25 Nov 2017, at 16:41, Jonathan Morton wrote: > > Not quite. The "dual" enums have more than one bit set, so you have to test > them for equality. > > - Jonathan Morton Here you go https://github.com/ldir-EDB0/sch_cake/commit/795db1d1df9f9a400d8c4861eeff59b85994ccfb - rebased onto c

Re: [Cake] allocate_src allocate_dst

2017-11-25 Thread Dave Taht
On Sat, Nov 25, 2017 at 8:52 AM, Dave Taht wrote: > Please ignore that patchset. I'll regenerate it later. The tarball, anyway. (I'd generated it before I ripped out perturb) The branch looks ok to my bleeding eyes thus far. > > On Sat, Nov 25, 2017 at 8:45 AM, Dave Taht wrote: >> I have a for

Re: [Cake] allocate_src allocate_dst

2017-11-25 Thread Dave Taht
Please ignore that patchset. I'll regenerate it later. On Sat, Nov 25, 2017 at 8:45 AM, Dave Taht wrote: > I have a for_upstream_4.16 branch which you might want to pull and > take a look at. > > It no longer compiles out of tree, so you can apply it against the > current net-next kernel, with pa

Re: [Cake] allocate_src allocate_dst

2017-11-25 Thread Dave Taht
On Sat, Nov 25, 2017 at 8:28 AM, Pete Heist wrote: > >> On Nov 25, 2017, at 3:08 PM, Kevin Darbyshire-Bryant >> wrote: >> >>> On 25 Nov 2017, at 03:59, Dave Taht wrote: >>> >>> there is no place in the current code base where these are not both >>> true or both false. Thus redundant. >>> >>> ?

Re: [Cake] allocate_src allocate_dst

2017-11-25 Thread Dave Taht
On Sat, Nov 25, 2017 at 8:43 AM, Kevin Darbyshire-Bryant wrote: > > >> On 25 Nov 2017, at 16:41, Jonathan Morton wrote: >> >> Not quite. The "dual" enums have more than one bit set, so you have to test >> them for equality. >> >> - Jonathan Morton > > Oh dammit, yes they are dual bit flags, rat

Re: [Cake] allocate_src allocate_dst

2017-11-25 Thread Dave Taht
I have a for_upstream_4.16 branch which you might want to pull and take a look at. It no longer compiles out of tree, so you can apply it against the current net-next kernel, with patchset for that is attached. I'm compiling this version now (which takes a while), and going out to do laundry. up

Re: [Cake] allocate_src allocate_dst

2017-11-25 Thread Kevin Darbyshire-Bryant
> On 25 Nov 2017, at 16:41, Jonathan Morton wrote: > > Not quite. The "dual" enums have more than one bit set, so you have to test > them for equality. > > - Jonathan Morton Oh dammit, yes they are dual bit flags, rats. good catch. v2 shortly he he :-) __

Re: [Cake] allocate_src allocate_dst

2017-11-25 Thread Jonathan Morton
Not quite. The "dual" enums have more than one bit set, so you have to test them for equality. - Jonathan Morton ___ Cake mailing list Cake@lists.bufferbloat.net https://lists.bufferbloat.net/listinfo/cake

Re: [Cake] allocate_src allocate_dst

2017-11-25 Thread Kevin Darbyshire-Bryant
> On 25 Nov 2017, at 15:19, Jonathan Morton wrote: > > I think I originally intended to make them individually conditional on the > src/dest host flags, but that idea evidently got forgotten. > > - Jonathan Morton Ahh, is this https://github.com/ldir-EDB0/sch_cake/commit/53953e073e26c45ac67

Re: [Cake] allocate_src allocate_dst

2017-11-25 Thread Jonathan Morton
Part of making an upstream patch involves collapsing those ifdefs to match the current kernel version. That by itself should considerably simplify that function. - Jonathan Morton ___ Cake mailing list Cake@lists.bufferbloat.net https://lists.bufferbloa

Re: [Cake] allocate_src allocate_dst

2017-11-25 Thread Pete Heist
> On Nov 25, 2017, at 3:08 PM, Kevin Darbyshire-Bryant > wrote: > >> On 25 Nov 2017, at 03:59, Dave Taht wrote: >> >> there is no place in the current code base where these are not both >> true or both false. Thus redundant. >> >> ? > > Yes, interesting that. Been there since introduced in

Re: [Cake] allocate_src allocate_dst

2017-11-25 Thread Jonathan Morton
I think I originally intended to make them individually conditional on the src/dest host flags, but that idea evidently got forgotten. - Jonathan Morton ___ Cake mailing list Cake@lists.bufferbloat.net https://lists.bufferbloat.net/listinfo/cake

[Cake] Fwd: [patch iproute2 00/11] tc: jsonify couple of qdics, filter and actions

2017-11-25 Thread Dave Taht
there is a bunch of activity restructuring iproute2... this last patchset, for json. -- Forwarded message -- From: Jiri Pirko Date: Sat, Nov 25, 2017 at 6:48 AM Subject: [patch iproute2 00/11] tc: jsonify couple of qdics, filter and actions To: net...@vger.kernel.org Cc: step...@

Re: [Cake] allocate_src allocate_dst

2017-11-25 Thread Kevin Darbyshire-Bryant
> On 25 Nov 2017, at 03:59, Dave Taht wrote: > > there is no place in the current code base where these are not both > true or both false. Thus redundant. > > ? Yes, interesting that. Been there since introduced in 5a6da2ba Add triple-isolation support. *EXPERIMENTAL* Have done a PR https