Re: [Cake] [PATCH] q_cake: Update xstats format to use per-tin structure

2018-03-01 Thread Sebastian Moeller
Dear All, 

I am a bit confused now which tc repository is the one to track.

I believe Jonathan made changes to https://github.com/dtaht/tc-adv

while https://github.com/dtaht/iproute2-cake-next seems overall more recent 
(modulo Jonathan's changes)

So which one is it?

BTW, my testing so far with the latest tc-adv did not result in any crashes, 
but I also did not research whether the overhead account behaves like 
expected...

Best Regards
Sebastian


> On Mar 1, 2018, at 12:02, Jonathan Morton  wrote:
> 
>> On 11 Feb, 2018, at 7:26 pm, Toke Høiland-Jørgensen  wrote:
>> 
>> This updates tc to understand the updated cake xstats structure (which
>> splits out the tin stats in a separate structure the length of which is
>> included in the containing struct).
>> 
>> Old versions of the cake stats will no longer be understood by the
>> resulting version of tc.
> 
> I think you could make a pull request for these patches now.  I can then add 
> new stats to the new code instead of duplicating work.
> 
> - Jonathan Morton
> 
> ___
> Cake mailing list
> Cake@lists.bufferbloat.net
> https://lists.bufferbloat.net/listinfo/cake

___
Cake mailing list
Cake@lists.bufferbloat.net
https://lists.bufferbloat.net/listinfo/cake


Re: [Cake] [PATCH] q_cake: Update xstats format to use per-tin structure

2018-03-01 Thread Jonathan Morton
> On 11 Feb, 2018, at 7:26 pm, Toke Høiland-Jørgensen  wrote:
> 
> This updates tc to understand the updated cake xstats structure (which
> splits out the tin stats in a separate structure the length of which is
> included in the containing struct).
> 
> Old versions of the cake stats will no longer be understood by the
> resulting version of tc.

I think you could make a pull request for these patches now.  I can then add 
new stats to the new code instead of duplicating work.

 - Jonathan Morton

___
Cake mailing list
Cake@lists.bufferbloat.net
https://lists.bufferbloat.net/listinfo/cake