[Cake] [PATCH net-next v10 0/7] sched: Add Common Applications Kept Enhanced (cake) qdisc

2018-05-14 Thread Toke Høiland-Jørgensen
This patch series adds the CAKE qdisc, and has been split up to ease review. I have attempted to split out each configurable feature into its own patch. The first commit adds the base shaper and packet scheduler, while subsequent commits add the optional features. The full userspace API and most d

[Cake] [PATCH net-next v10 6/7] sch_cake: Add overhead compensation support to the rate shaper

2018-05-14 Thread Toke Høiland-Jørgensen
This commit adds configurable overhead compensation support to the rate shaper. With this feature, userspace can configure the actual bottleneck link overhead and encapsulation mode used, which will be used by the shaper to calculate the precise duration of each packet on the wire. This feature is

[Cake] [PATCH net-next v10 3/7] sch_cake: Add optional ACK filter

2018-05-14 Thread Toke Høiland-Jørgensen
The ACK filter is an optional feature of CAKE which is designed to improve performance on links with very asymmetrical rate limits. On such links (which are unfortunately quite prevalent, especially for DSL and cable subscribers), the downstream throughput can be limited by the number of ACKs capab

[Cake] [PATCH net-next v10 5/7] sch_cake: Add DiffServ handling

2018-05-14 Thread Toke Høiland-Jørgensen
This adds support for DiffServ-based priority queueing to CAKE. If the shaper is in use, each priority tier gets its own virtual clock, which limits that tier's rate to a fraction of the overall shaped rate, to discourage trying to game the priority mechanism. CAKE defaults to a simple, three-tier

[Cake] [PATCH net-next v10 1/7] sched: Add Common Applications Kept Enhanced (cake) qdisc

2018-05-14 Thread Toke Høiland-Jørgensen
sch_cake targets the home router use case and is intended to squeeze the most bandwidth and latency out of even the slowest ISP links and routers, while presenting an API simple enough that even an ISP can configure it. Example of use on a cable ISP uplink: tc qdisc add dev eth0 cake bandwidth 20

[Cake] [PATCH net-next v10 4/7] sch_cake: Add NAT awareness to packet classifier

2018-05-14 Thread Toke Høiland-Jørgensen
When CAKE is deployed on a gateway that also performs NAT (which is a common deployment mode), the host fairness mechanism cannot distinguish internal hosts from each other, and so fails to work correctly. To fix this, we add an optional NAT awareness mode, which will query the kernel conntrack me

[Cake] [PATCH net-next v10 7/7] sch_cake: Conditionally split GSO segments

2018-05-14 Thread Toke Høiland-Jørgensen
At lower bandwidths, the transmission time of a single GSO segment can add an unacceptable amount of latency due to HOL blocking. Furthermore, with a software shaper, any tuning mechanism employed by the kernel to control the maximum size of GSO segments is thrown off by the artificial limit on ban

[Cake] [PATCH net-next v10 2/7] sch_cake: Add ingress mode

2018-05-14 Thread Toke Høiland-Jørgensen
The ingress mode is meant to be enabled when CAKE runs downlink of the actual bottleneck (such as on an IFB device). The mode changes the shaper to also account dropped packets to the shaped rate, as these have already traversed the bottleneck. Enabling ingress mode will also tune the AQM to alway

Re: [Cake] [PATCH net-next v9 1/7] sched: Add Common Applications Kept Enhanced (cake) qdisc

2018-05-14 Thread Toke Høiland-Jørgensen
David Miller writes: > From: Toke Høiland-Jørgensen > Date: Mon, 14 May 2018 11:08:28 +0200 > >> David Miller writes: >> >>> From: Toke Høiland-Jørgensen >>> Date: Tue, 08 May 2018 16:34:19 +0200 >>> +struct cake_flow { + /* this stuff is all needed per-flow at dequeue time */

Re: [Cake] [PATCH net-next v9 1/7] sched: Add Common Applications Kept Enhanced (cake) qdisc

2018-05-14 Thread David Miller
From: Toke Høiland-Jørgensen Date: Mon, 14 May 2018 11:08:28 +0200 > David Miller writes: > >> From: Toke Høiland-Jørgensen >> Date: Tue, 08 May 2018 16:34:19 +0200 >> >>> +struct cake_flow { >>> + /* this stuff is all needed per-flow at dequeue time */ >>> + struct sk_buff*head; >>> +

Re: [Cake] [PATCH net-next v9 1/7] sched: Add Common Applications Kept Enhanced (cake) qdisc

2018-05-14 Thread Toke Høiland-Jørgensen
David Miller writes: > From: Toke Høiland-Jørgensen > Date: Tue, 08 May 2018 16:34:19 +0200 > >> +struct cake_flow { >> +/* this stuff is all needed per-flow at dequeue time */ >> +struct sk_buff*head; >> +struct sk_buff*tail; > > Please do not invent your own SKB list handli