[Cake] [PATCH net] gso_segment: Reset skb->mac_len after modifying network header

2018-09-11 Thread Toke Høiland-Jørgensen
When splitting a GSO segment that consists of encapsulated packets, the skb->mac_len of the segments can end up being set wrong, causing packet drops in particular when using act_mirred and ifb interfaces in combination with a qdisc that splits GSO packets. This happens because at the time

Re: [Cake] Cake vs fq_codel and c/burst on an ER-X bridge

2018-09-11 Thread Dave Taht
On Tue, Sep 11, 2018 at 11:45 AM Pete Heist wrote: > > > On Sep 11, 2018, at 8:28 PM, Sebastian Moeller wrote: > > > Yeah, good point, I left nat there because I had one port configured for > routing and the other for the bridge and was sometimes swapping between the > two. I realize now I

Re: [Cake] Cake vs fq_codel and c/burst on an ER-X bridge

2018-09-11 Thread Pete Heist
> On Sep 11, 2018, at 8:28 PM, Sebastian Moeller wrote: >> >> Yeah, good point, I left nat there because I had one port configured for >> routing and the other for the bridge and was sometimes swapping between the >> two. I realize now I actually sent the numbers for routing, not bridging.

Re: [Cake] Cake vs fq_codel and c/burst on an ER-X bridge

2018-09-11 Thread Dave Taht
Next time I have sufficient spare brain cells I would like to try shaping across cores. I don't know how to share a bit of data between qdiscs as yet, so my plan to prove it out, is to use a static variable for time_next_packet (has to be 32 bits also), and atomically update it between the

Re: [Cake] Cake vs fq_codel and c/burst on an ER-X bridge

2018-09-11 Thread Dave Taht
that was me shaping at 900. On Tue, Sep 11, 2018 at 11:27 AM Pete Heist wrote: > > > > On Sep 11, 2018, at 10:20 AM, Dave Taht wrote: > > > > What I "fixed" was on the apu2 with the burst/cburst change, I went > > from completely bottlenecked on one softirq to having 3 eat cpu, and > > from

Re: [Cake] Cake vs fq_codel and c/burst on an ER-X bridge

2018-09-11 Thread Sebastian Moeller
Hi Pete, > On Sep 11, 2018, at 20:09, Pete Heist wrote: > > >> On Sep 11, 2018, at 9:54 AM, Sebastian Moeller wrote: >>> >>> So this has turned info an interesting exercise that produced a result >>> counter to what the common wisdom has been (that fq_codel is “faster” than >>> cake >>

Re: [Cake] Cake vs fq_codel and c/burst on an ER-X bridge

2018-09-11 Thread Pete Heist
> On Sep 11, 2018, at 10:20 AM, Dave Taht wrote: > > What I "fixed" was on the apu2 with the burst/cburst change, I went > from completely bottlenecked on one softirq to having 3 eat cpu, and > from 400mbps to 900mbps. Now, that's a quad core and the e1000 (?) > driver. The edgerouter X is a

Re: [Cake] Cake vs fq_codel and c/burst on an ER-X bridge

2018-09-11 Thread Sebastian Moeller
Hi Dave, > On Sep 11, 2018, at 10:30, Dave Taht wrote: > > On Tue, Sep 11, 2018 at 1:20 AM Sebastian Moeller wrote: >> >> Hi Dave, >> >>> On Sep 11, 2018, at 10:20, Dave Taht wrote: >>> >>> What I "fixed" was on the apu2 with the burst/cburst change, I went >>> from completely

Re: [Cake] Cake vs fq_codel and c/burst on an ER-X bridge

2018-09-11 Thread Dave Taht
On Tue, Sep 11, 2018 at 1:20 AM Sebastian Moeller wrote: > > Hi Dave, > > > On Sep 11, 2018, at 10:20, Dave Taht wrote: > > > > What I "fixed" was on the apu2 with the burst/cburst change, I went > > from completely bottlenecked on one softirq to having 3 eat cpu, and > > from 400mbps to

Re: [Cake] Cake vs fq_codel and c/burst on an ER-X bridge

2018-09-11 Thread Sebastian Moeller
Hi Dave, > On Sep 11, 2018, at 10:20, Dave Taht wrote: > > What I "fixed" was on the apu2 with the burst/cburst change, I went > from completely bottlenecked on one softirq to having 3 eat cpu, and > from 400mbps to 900mbps. Now, that's a quad core and the e1000 (?) > driver. The edgerouter X

Re: [Cake] Cake vs fq_codel and c/burst on an ER-X bridge

2018-09-11 Thread Dave Taht
What I "fixed" was on the apu2 with the burst/cburst change, I went from completely bottlenecked on one softirq to having 3 eat cpu, and from 400mbps to 900mbps. Now, that's a quad core and the e1000 (?) driver. The edgerouter X is a dual core, and you did see a small improvement in throughput,

Re: [Cake] Cake vs fq_codel and c/burst on an ER-X bridge

2018-09-11 Thread Sebastian Moeller
Hi Pete, > On Sep 11, 2018, at 00:40, Pete Heist wrote: > > Subject changed from “Cake on elements of a bridge”... > > On Sep 10, 2018, at 9:55 PM, Dave Taht wrote: >> >> On Mon, Sep 10, 2018 at 12:29 PM Pete Heist wrote: >>> >>> For anyone who followed this, yes, the regular soft bridge