[Cake] host hashes and NAT neglected in src/dst-host mode

2019-01-06 Thread gamanakis
I was having a look at cake's hash code and it seems srchost_hash and dsthost_hash, as well as the flowkeys in NAT are not calculated in plain "srchost" or "dsthost" modes. CAKE_FLOW_FLOWS and CAKE_FLOW_HOSTS are both 0 (conditional in line 633) when src/dst-host is set as flow mode. So the code

Re: [Cake] cake infinite loop(?) with hfsc on one-armed router

2019-01-06 Thread Dave Taht
another answer is to disable gro/tso in the driver via ethtool. On Sun, Jan 6, 2019 at 4:30 PM Pete Heist wrote: > > > > On Jan 6, 2019, at 9:56 PM, Toke Høiland-Jørgensen wrote: > > > > Pete Heist writes: > > > >> Lastly, is using cake as a leaf to htb risky until a fix is made? I’ve > >>

Re: [Cake] cake infinite loop(?) with hfsc on one-armed router

2019-01-06 Thread Pete Heist
> On Jan 6, 2019, at 9:56 PM, Toke Høiland-Jørgensen wrote: > > Pete Heist writes: > >> Lastly, is using cake as a leaf to htb risky until a fix is made? I’ve >> been doing that for a while without any apparent issues, though I’m >> hesitating now to try that in a production environment. > >

Re: [Cake] cake infinite loop(?) with hfsc on one-armed router

2019-01-06 Thread Toke Høiland-Jørgensen
Pete Heist writes: > Lastly, is using cake as a leaf to htb risky until a fix is made? I’ve > been doing that for a while without any apparent issues, though I’m > hesitating now to try that in a production environment. Hmm, that's a good question. I would expect so; but I would also expect the

Re: [Cake] cake infinite loop(?) with hfsc on one-armed router

2019-01-06 Thread Toke Høiland-Jørgensen
Pete Heist writes: >> On Jan 5, 2019, at 11:27 PM, Toke Høiland-Jørgensen wrote: >> >> Pete Heist writes: >> On Jan 5, 2019, at 9:10 PM, Toke Høiland-Jørgensen wrote: Well, it's the same WARN_ON(), and if that patch had been applied, debugging our issue would have been

Re: [Cake] (SCE) Some Congestion Experienced

2019-01-06 Thread Jonathan Morton
> On 6 Jan, 2019, at 8:43 pm, Dave Taht wrote: > > thing is, I can't remember what he called it (EWR?), nor when/where it > was discussed. Nor if there was a novel solution to the ece bit on the > ack side? I think I was calling it ELR - Explicit Load Regulation. My current thinking on the

[Cake] (SCE) Some Congestion Experienced

2019-01-06 Thread Dave Taht
I am thinking of making a go at jon's alternate ecn approach in the ietf, before the dual-q draft gets any further. It's not just that the latest draft specifes that all classic traffic get 1/4th the bandwidth, but the total lack of analyzable source code and the frand patent...