Re: [Cake] [PATCH 0/4] sched: Fix qdisc interactions exposed by using sch_cake as a leaf qdisc

2019-01-09 Thread Toke Høiland-Jørgensen
David Miller writes: > From: Toke Høiland-Jørgensen > Date: Mon, 7 Jan 2019 20:47:29 +0100 > >> This series fixes a couple of issues exposed by running sch_cake as a >> leaf qdisc in an HFSC tree, which were discovered and reported by Pete >> Heist. The interaction between CAKE's GSO splitting

Re: [Cake] [PATCH 1/4] sched: Avoid dereferencing skb pointer after child enqueue

2019-01-09 Thread Cong Wang
On Mon, Jan 7, 2019 at 11:50 AM Toke Høiland-Jørgensen wrote: > @@ -1254,7 +1256,7 @@ static int qfq_enqueue(struct sk_buff *skb, struct > Qdisc *sch, > if (cl->qdisc->q.qlen != 1) { > if (unlikely(skb == cl->qdisc->ops->peek(cl->qdisc)) && Isn't this comparison

Re: [Cake] cake infinite loop(?) with hfsc on one-armed router

2019-01-09 Thread Toke Høiland-Jørgensen
Pete Heist writes: >> On Jan 8, 2019, at 11:27 PM, Toke Høiland-Jørgensen wrote: >> >> Pete Heist writes: >> >>> Your patch in the latest kernels looks simpler. Bringing the patch >>> back to prior kernel versions would be appreciated, but I can >>> understand how 3.16 becomes less and less

Re: [Cake] [PATCH 1/4] sched: Avoid dereferencing skb pointer after child enqueue

2019-01-09 Thread Toke Høiland-Jørgensen
Cong Wang writes: > On Mon, Jan 7, 2019 at 11:50 AM Toke Høiland-Jørgensen wrote: >> @@ -1254,7 +1256,7 @@ static int qfq_enqueue(struct sk_buff *skb, struct >> Qdisc *sch, >> if (cl->qdisc->q.qlen != 1) { >> if (unlikely(skb == cl->qdisc->ops->peek(cl->qdisc)) && > > >