Re: [Cake] [PATCH iproute2] q_cake: Add support for setting the fwmark option

2019-04-05 Thread Stephen Hemminger
On Thu, 4 Apr 2019 15:09:10 +0200 Toke Høiland-Jørgensen wrote: > This adds support for the newly added fwmark option to CAKE, which allows > overriding the tin selection from the per-packet firewall marks. The fwmark > field is a bitmask that is applied to the fwmark to select the tin. > >

Re: [Cake] [PATCH for-4.19 0/3] Backport of series: 'sched: A few small fixes for sch_cake' from 5.1

2019-04-05 Thread Toke Høiland-Jørgensen
Greg Kroah-Hartman writes: > On Fri, Apr 05, 2019 at 02:13:18PM +0200, Toke Høiland-Jørgensen wrote: >> Greg Kroah-Hartman writes: >> >> > On Fri, Apr 05, 2019 at 12:28:21PM +0200, Toke Høiland-Jørgensen wrote: >> >> Hi Greg >> >> >> >> This series contains backports for a couple of fixes to

Re: [Cake] [PATCH for-4.19 0/3] Backport of series: 'sched: A few small fixes for sch_cake' from 5.1

2019-04-05 Thread Greg Kroah-Hartman
On Fri, Apr 05, 2019 at 02:13:18PM +0200, Toke Høiland-Jørgensen wrote: > Greg Kroah-Hartman writes: > > > On Fri, Apr 05, 2019 at 12:28:21PM +0200, Toke Høiland-Jørgensen wrote: > >> Hi Greg > >> > >> This series contains backports for a couple of fixes to sch_cake that was > >> just > >>

Re: [Cake] [PATCH for-4.19 0/3] Backport of series: 'sched: A few small fixes for sch_cake' from 5.1

2019-04-05 Thread Greg Kroah-Hartman
On Fri, Apr 05, 2019 at 12:28:21PM +0200, Toke Høiland-Jørgensen wrote: > Hi Greg > > This series contains backports for a couple of fixes to sch_cake that was just > merged for 5.1. This series backports an earlier refactoring commit, which > makes > the fixes themselves apply cleanly from

[Cake] [PATCH for-4.19 2/3] sch_cake: Use tc_skb_protocol() helper for getting packet protocol

2019-04-05 Thread Toke Høiland-Jørgensen
Commit bbd669a868bba591ffd38b7bc75a7b361bb54b04 upstream. We shouldn't be using skb->protocol directly as that will miss cases with hardware-accelerated VLAN tags. Use the helper instead to get the right protocol number. Reported-by: Kevin Darbyshire-Bryant Signed-off-by: Toke Høiland-Jørgensen

[Cake] [PATCH for-4.19 0/3] Backport of series: 'sched: A few small fixes for sch_cake' from 5.1

2019-04-05 Thread Toke Høiland-Jørgensen
Hi Greg This series contains backports for a couple of fixes to sch_cake that was just merged for 5.1. This series backports an earlier refactoring commit, which makes the fixes themselves apply cleanly from upstream. -Toke --- Toke Høiland-Jørgensen (3): sch_cake: Simplify logic in