Re: [Cake] [PATCH for-4.19 0/3] Backport of series: 'sched: A few small fixes for sch_cake' from 5.1
Greg Kroah-Hartman writes: > On Fri, Apr 05, 2019 at 02:13:18PM +0200, Toke Høiland-Jørgensen wrote: >> Greg Kroah-Hartman writes: >> >> > On Fri, Apr 05, 2019 at 12:28:21PM +0200, Toke Høiland-Jørgensen wrote: >> >> Hi Greg >> >> >> >> This series contains backports for a couple of fixes to sch_cake that was >> >> just >> >> merged for 5.1. This series backports an earlier refactoring commit, >> >> which makes >> >> the fixes themselves apply cleanly from upstream. >> > >> > You have read: >> > https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html >> > for how to submit networking patches to the stable trees, right? >> > >> > I suggest trying it that way first... >> >> Yeah, Dave already queued the original fixes up for stable, but they are >> not going to apply cleanly on 4.19; hence the first patch in this >> series. >> >> I thought it was better to just include the full series with that, for >> context, but maybe that was wrong? Should I just have sent the first >> one? If so, feel free to just take the first patch in this series and >> let the others go through the usual stable submission process... > > Dave queues up and sends me the stable backports for networking code, > as the document states. If there is a special series needed for 4.19, > I'm sure he would be glad to take them. Or, I can take them directly, > after I have the 5.0 series queued up, if I get an ack from him. > > But to seemingly circumvent the normal process, isn't ok, I need to > know that at least you tried :) Well I did ask Dave if he wanted me to supply a backport, see https://marc.info/?l=linux-netdev=155440061002032=2 - I just thought sending that directly to you was the natural thing to do. Certainly wasn't trying to circumvent process, just haven't done any backports for the net tree before :) Actually, looking at the log again now, I see that I got my versions mixed up, and the backport patch is also needed for 5.0... so I guess I'll just (re-)submit that to Dave to put into his stable queue... -Toke ___ Cake mailing list Cake@lists.bufferbloat.net https://lists.bufferbloat.net/listinfo/cake
Re: [Cake] [PATCH for-4.19 0/3] Backport of series: 'sched: A few small fixes for sch_cake' from 5.1
On Fri, Apr 05, 2019 at 02:13:18PM +0200, Toke Høiland-Jørgensen wrote: > Greg Kroah-Hartman writes: > > > On Fri, Apr 05, 2019 at 12:28:21PM +0200, Toke Høiland-Jørgensen wrote: > >> Hi Greg > >> > >> This series contains backports for a couple of fixes to sch_cake that was > >> just > >> merged for 5.1. This series backports an earlier refactoring commit, which > >> makes > >> the fixes themselves apply cleanly from upstream. > > > > You have read: > > https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html > > for how to submit networking patches to the stable trees, right? > > > > I suggest trying it that way first... > > Yeah, Dave already queued the original fixes up for stable, but they are > not going to apply cleanly on 4.19; hence the first patch in this > series. > > I thought it was better to just include the full series with that, for > context, but maybe that was wrong? Should I just have sent the first > one? If so, feel free to just take the first patch in this series and > let the others go through the usual stable submission process... Dave queues up and sends me the stable backports for networking code, as the document states. If there is a special series needed for 4.19, I'm sure he would be glad to take them. Or, I can take them directly, after I have the 5.0 series queued up, if I get an ack from him. But to seemingly circumvent the normal process, isn't ok, I need to know that at least you tried :) thanks, greg k-h ___ Cake mailing list Cake@lists.bufferbloat.net https://lists.bufferbloat.net/listinfo/cake
Re: [Cake] [PATCH for-4.19 0/3] Backport of series: 'sched: A few small fixes for sch_cake' from 5.1
On Fri, Apr 05, 2019 at 12:28:21PM +0200, Toke Høiland-Jørgensen wrote: > Hi Greg > > This series contains backports for a couple of fixes to sch_cake that was just > merged for 5.1. This series backports an earlier refactoring commit, which > makes > the fixes themselves apply cleanly from upstream. You have read: https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html for how to submit networking patches to the stable trees, right? I suggest trying it that way first... thanks, greg k-h ___ Cake mailing list Cake@lists.bufferbloat.net https://lists.bufferbloat.net/listinfo/cake
[Cake] [PATCH for-4.19 0/3] Backport of series: 'sched: A few small fixes for sch_cake' from 5.1
Hi Greg This series contains backports for a couple of fixes to sch_cake that was just merged for 5.1. This series backports an earlier refactoring commit, which makes the fixes themselves apply cleanly from upstream. -Toke --- Toke Høiland-Jørgensen (3): sch_cake: Simplify logic in cake_select_tin() sch_cake: Use tc_skb_protocol() helper for getting packet protocol sch_cake: Make sure we can write the IP header before changing DSCP bits net/sched/sch_cake.c | 57 +- 1 file changed, 28 insertions(+), 29 deletions(-) ___ Cake mailing list Cake@lists.bufferbloat.net https://lists.bufferbloat.net/listinfo/cake
