Re: [Cake] [PATCH net-next v12 3/7] sch_cake: Add optional ACK filter

2018-05-18 Thread Sebastian Moeller
Hi Kevin, > On May 18, 2018, at 13:18, Kevin Darbyshire-Bryant > wrote: > > > >> On 18 May 2018, at 05:27, Cong Wang wrote: >> >> On Thu, May 17, 2018 at 4:23 AM, Toke Høiland-Jørgensen wrote: >>> Eric Dumazet

Re: [Cake] [PATCH net-next v12 3/7] sch_cake: Add optional ACK filter

2018-05-18 Thread Kevin Darbyshire-Bryant
> On 18 May 2018, at 05:27, Cong Wang wrote: > > On Thu, May 17, 2018 at 4:23 AM, Toke Høiland-Jørgensen wrote: >> Eric Dumazet writes: >> >>> On 05/16/2018 01:29 PM, Toke Høiland-Jørgensen wrote: The ACK filter is an

Re: [Cake] [PATCH net-next v12 3/7] sch_cake: Add optional ACK filter

2018-05-18 Thread Cong Wang
On Thu, May 17, 2018 at 4:23 AM, Toke Høiland-Jørgensen wrote: > Eric Dumazet writes: > >> On 05/16/2018 01:29 PM, Toke Høiland-Jørgensen wrote: >>> The ACK filter is an optional feature of CAKE which is designed to improve >>> performance on links with very

Re: [Cake] [PATCH net-next v12 3/7] sch_cake: Add optional ACK filter

2018-05-18 Thread Ryan Mounce
On 18 May 2018 at 13:38, Eric Dumazet wrote: > > > On 05/17/2018 07:36 PM, Ryan Mounce wrote: >> On 17 May 2018 at 22:41, Toke Høiland-Jørgensen wrote: >>> Eric Dumazet writes: >>> On 05/17/2018 04:23 AM, Toke Høiland-Jørgensen

Re: [Cake] [PATCH net-next v12 3/7] sch_cake: Add optional ACK filter

2018-05-17 Thread Eric Dumazet
On 05/17/2018 07:36 PM, Ryan Mounce wrote: > On 17 May 2018 at 22:41, Toke Høiland-Jørgensen wrote: >> Eric Dumazet writes: >> >>> On 05/17/2018 04:23 AM, Toke Høiland-Jørgensen wrote: >>> We don't do full parsing of SACKs, no; we were trying to

Re: [Cake] [PATCH net-next v12 3/7] sch_cake: Add optional ACK filter

2018-05-17 Thread Ryan Mounce
On 17 May 2018 at 22:41, Toke Høiland-Jørgensen wrote: > Eric Dumazet writes: > >> On 05/17/2018 04:23 AM, Toke Høiland-Jørgensen wrote: >> >>> >>> We don't do full parsing of SACKs, no; we were trying to keep things >>> simple... We do detect the presence

Re: [Cake] [PATCH net-next v12 3/7] sch_cake: Add optional ACK filter

2018-05-17 Thread Toke Høiland-Jørgensen
Eric Dumazet writes: > On 05/17/2018 04:23 AM, Toke Høiland-Jørgensen wrote: > >> >> We don't do full parsing of SACKs, no; we were trying to keep things >> simple... We do detect the presence of SACK options, though, and the >> presence of SACK options on an ACK will

Re: [Cake] [PATCH net-next v12 3/7] sch_cake: Add optional ACK filter

2018-05-17 Thread Eric Dumazet
On 05/17/2018 04:23 AM, Toke Høiland-Jørgensen wrote: > > We don't do full parsing of SACKs, no; we were trying to keep things > simple... We do detect the presence of SACK options, though, and the > presence of SACK options on an ACK will make previous ACKs be considered > redundant. > But

Re: [Cake] [PATCH net-next v12 3/7] sch_cake: Add optional ACK filter

2018-05-17 Thread Toke Høiland-Jørgensen
Eric Dumazet writes: > On 05/16/2018 01:29 PM, Toke Høiland-Jørgensen wrote: >> The ACK filter is an optional feature of CAKE which is designed to improve >> performance on links with very asymmetrical rate limits. On such links >> (which are unfortunately quite

Re: [Cake] [PATCH net-next v12 3/7] sch_cake: Add optional ACK filter

2018-05-17 Thread Eric Dumazet
On 05/16/2018 01:29 PM, Toke Høiland-Jørgensen wrote: > The ACK filter is an optional feature of CAKE which is designed to improve > performance on links with very asymmetrical rate limits. On such links > (which are unfortunately quite prevalent, especially for DSL and cable > subscribers), the

[Cake] [PATCH net-next v12 3/7] sch_cake: Add optional ACK filter

2018-05-16 Thread Toke Høiland-Jørgensen
The ACK filter is an optional feature of CAKE which is designed to improve performance on links with very asymmetrical rate limits. On such links (which are unfortunately quite prevalent, especially for DSL and cable subscribers), the downstream throughput can be limited by the number of ACKs