Re: [Cake] [PATCH net-next v2] Add Common Applications Kept Enhanced (cake) qdisc

2018-04-27 Thread kbuild test robot
Hi Toke, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Toke-H-iland-J-rgensen/Add-Common-Applications-Kept-Enhanced-cake-qdisc/20180426-064653 config: parisc-allmodconfig (attached as

Re: [Cake] [PATCH net-next v2] Add Common Applications Kept Enhanced (cake) qdisc

2018-04-24 Thread Toke Høiland-Jørgensen
Georgios Amanakis writes: > On Tue, Apr 24, 2018 at 11:47 AM, Georgios Amanakis > wrote: >>> >>> Does anyone know if there is a way to do this so the module/builtin >>> split doesn't bite us? >>> >> #ifdef CONFIG_NF_CONNTRACK ?? That is basically what

Re: [Cake] [PATCH net-next v2] Add Common Applications Kept Enhanced (cake) qdisc

2018-04-24 Thread Georgios Amanakis
On Tue, Apr 24, 2018 at 11:47 AM, Georgios Amanakis wrote: >> >> Does anyone know if there is a way to do this so the module/builtin >> split doesn't bite us? >> > #ifdef CONFIG_NF_CONNTRACK ?? ___ Cake mailing list

Re: [Cake] [PATCH net-next v2] Add Common Applications Kept Enhanced (cake) qdisc

2018-04-24 Thread Toke Høiland-Jørgensen
Georgios Amanakis writes: > On Tue, 24 Apr 2018 13:44:06 +0200 > Toke Høiland-Jørgensen wrote: > >> +config NET_SCH_CAKE >> + tristate "Common Applications Kept Enhanced (CAKE)" >> + help >> + Say Y here if you want to use the Common

Re: [Cake] [PATCH net-next v2] Add Common Applications Kept Enhanced (cake) qdisc

2018-04-24 Thread Georgios Amanakis
On Tue, 24 Apr 2018 13:44:06 +0200 Toke Høiland-Jørgensen wrote: > +config NET_SCH_CAKE > + tristate "Common Applications Kept Enhanced (CAKE)" > + help > + Say Y here if you want to use the Common Applications Kept Enhanced > + (CAKE) queue management

Re: [Cake] [PATCH net-next v2] Add Common Applications Kept Enhanced (cake) qdisc

2018-04-24 Thread Stephen Hemminger
On Tue, 24 Apr 2018 13:44:06 +0200 Toke Høiland-Jørgensen wrote: > +static const u8 precedence[] = {0, 0, 0, 0, 0, 0, 0, 0, > + 1, 1, 1, 1, 1, 1, 1, 1, > + 2, 2, 2, 2, 2, 2, 2, 2, > + 3, 3, 3, 3, 3,

Re: [Cake] [PATCH net-next v2] Add Common Applications Kept Enhanced (cake) qdisc

2018-04-24 Thread Stephen Hemminger
On Tue, 24 Apr 2018 13:44:06 +0200 Toke Høiland-Jørgensen wrote: > +struct tc_cake_xstats { > + __u16 version; > + __u16 tin_stats_size; /* == sizeof(struct tc_cake_tin_stats) */ > + __u32 capacity_estimate; > + __u32 memory_limit; > + __u32 memory_used; > +

[Cake] [PATCH net-next v2] Add Common Applications Kept Enhanced (cake) qdisc

2018-04-24 Thread Toke Høiland-Jørgensen
sch_cake targets the home router use case and is intended to squeeze the most bandwidth and latency out of even the slowest ISP links and routers, while presenting an API simple enough that even an ISP can configure it. Example of use on a cable ISP uplink: tc qdisc add dev eth0 cake bandwidth