Re: [Cake] eliminating link_ms and increasing packets to 64 bits

2018-03-23 Thread Toke Høiland-Jørgensen
Dave Taht writes: > the preceding space handles column alignment. the %12 is probably > going to be misleading. The space separates columns, the %12 aligns them. So it will break alignment. But as I said, mostly a cosmetic issue, so probably not something we should spend a lot of time on fixing.

Re: [Cake] eliminating link_ms and increasing packets to 64 bits

2018-03-23 Thread Dave Taht
the preceding space handles column alignment. the %12 is probably going to be misleading. On Fri, Mar 23, 2018 at 2:58 AM, Toke Høiland-Jørgensen wrote: > Dave Taht writes: > >> fprintf(f, " pkts"); >> FOR_EACH_TIN(stnc, tst, i) >> - fprintf(f, " %12u", tst->sent.pac

Re: [Cake] eliminating link_ms and increasing packets to 64 bits

2018-03-23 Thread Toke Høiland-Jørgensen
Dave Taht writes: > fprintf(f, " pkts"); > FOR_EACH_TIN(stnc, tst, i) > - fprintf(f, " %12u", tst->sent.packets); > + fprintf(f, " %12llu", tst->sent.packets); > fprintf(f, "\n"); Presumably this can potentially break column alignment? Not sure that

[Cake] eliminating link_ms and increasing packets to 64 bits

2018-03-22 Thread Dave Taht
It looks like tc-adv is currently canonical? I've briefly tested the attached against net-next. -- Dave Täht CEO, TekLibre, LLC http://www.teklibre.com Tel: 1-669-226-2619 From 21d25530b42d6c6e484b673182834275dba6b495 Mon Sep 17 00:00:00 2001 From: Dave Taht Date: Thu, 22 Mar 2018 14:53:59 -0