Re: [Cake] [PATCH net-next v8 1/7] sched: Add Common Applications Kept Enhanced (cake) qdisc

On Mon, May 7, 2018 at 11:37 AM, Toke Høiland-Jørgensen <t...@toke.dk> wrote: > Cong Wang <xiyou.wangc...@gmail.com> writes: > >> On Fri, May 4, 2018 at 12:10 PM, Toke Høiland-Jørgensen <t...@toke.dk> wrote: >>> Thank you for the review!

Re: [Cake] [PATCH net-next v8 1/7] sched: Add Common Applications Kept Enhanced (cake) qdisc

On Fri, May 4, 2018 at 12:10 PM, Toke Høiland-Jørgensen wrote: > Thank you for the review! A few comments below, I'll fix the rest. > >> [...] >> >> So sch_cake doesn't accept normal tc filters? Is this intentional? >> If so, why? > > For two reasons: > > - The two-level scheduling

Re: [Cake] [PATCH net-next v12 3/7] sch_cake: Add optional ACK filter

On Thu, May 17, 2018 at 4:23 AM, Toke Høiland-Jørgensen wrote: > Eric Dumazet writes: > >> On 05/16/2018 01:29 PM, Toke Høiland-Jørgensen wrote: >>> The ACK filter is an optional feature of CAKE which is designed to improve >>> performance on links with very

Re: [Cake] [PATCH net-next v12 1/7] sched: Add Common Applications Kept Enhanced (cake) qdisc

On Wed, May 16, 2018 at 1:29 PM, Toke Høiland-Jørgensen wrote: > + > +static struct Qdisc *cake_leaf(struct Qdisc *sch, unsigned long arg) > +{ > + return NULL; > +} > + > +static unsigned long cake_find(struct Qdisc *sch, u32 classid) > +{ > + return 0; > +} > + >

Re: [Cake] [PATCH net-next v12 4/7] sch_cake: Add NAT awareness to packet classifier

On Wed, May 16, 2018 at 1:29 PM, Toke Høiland-Jørgensen wrote: > When CAKE is deployed on a gateway that also performs NAT (which is a > common deployment mode), the host fairness mechanism cannot distinguish > internal hosts from each other, and so fails to work correctly. > > To

Re: [Cake] [PATCH net-next v6] Add Common Applications Kept Enhanced (cake) qdisc

On Tue, May 1, 2018 at 12:12 PM, Eric Dumazet wrote: > > I guess that nobody really wants to really review Cake if > it is a file with 2700 lines of code and hundreds of variables/tunables. > > Sure, we have big files in networking land, as a result of thousands of >

Re: [Cake] [PATCH net-next v6] Add Common Applications Kept Enhanced (cake) qdisc

On Mon, Apr 30, 2018 at 2:27 PM, Dave Taht <dave.t...@gmail.com> wrote: > On Mon, Apr 30, 2018 at 2:21 PM, Cong Wang <xiyou.wangc...@gmail.com> wrote: >> On Sun, Apr 29, 2018 at 2:34 PM, Toke Høiland-Jørgensen <t...@toke.dk> wrote: >>> sch_cake targets the

Re: [Cake] [PATCH net-next v6] Add Common Applications Kept Enhanced (cake) qdisc

On Sun, Apr 29, 2018 at 2:34 PM, Toke Høiland-Jørgensen wrote: > sch_cake targets the home router use case and is intended to squeeze the > most bandwidth and latency out of even the slowest ISP links and routers, > while presenting an API simple enough that even an ISP can

Re: [Cake] [PATCH 1/4] sched: Avoid dereferencing skb pointer after child enqueue

On Wed, Jan 9, 2019 at 12:14 AM Toke Høiland-Jørgensen wrote: > > Cong Wang writes: > > > On Mon, Jan 7, 2019 at 11:50 AM Toke Høiland-Jørgensen wrote: > >> @@ -1254,7 +1256,7 @@ static int qfq_enqueue(struct sk_buff *skb, struct > >> Qdisc *sch, > &

Re: [Cake] [PATCH 1/4] sched: Avoid dereferencing skb pointer after child enqueue

On Mon, Jan 7, 2019 at 11:50 AM Toke Høiland-Jørgensen wrote: > @@ -1254,7 +1256,7 @@ static int qfq_enqueue(struct sk_buff *skb, struct > Qdisc *sch, > if (cl->qdisc->q.qlen != 1) { > if (unlikely(skb == cl->qdisc->ops->peek(cl->qdisc)) && Isn't this comparison

Re: [Cake] [PATCH net v2] sched: consistently handle layer3 header accesses in the presence of VLANs

On Fri, Jul 3, 2020 at 8:22 AM Toke Høiland-Jørgensen wrote: > diff --git a/include/linux/if_vlan.h b/include/linux/if_vlan.h > index b05e855f1ddd..d0c1cb0d264d 100644 > --- a/include/linux/if_vlan.h > +++ b/include/linux/if_vlan.h > @@ -308,6 +308,35 @@ static inline bool eth_type_vlan(__be16

Re: [Cake] [PATCH net-next] net: sched: remove redundant NULL check in change hook function

On Sat, Aug 27, 2022 at 09:49:10AM +0800, Zhengchao Shao wrote: > Currently, the change function can be called by two ways. The one way is > that qdisc_change() will call it. Before calling change function, > qdisc_change() ensures tca[TCA_OPTIONS] is not empty. The other way is > that .init()