Re: [Cake] triple flow isolation

2016-01-11 Thread Kevin Darbyshire-Bryant
On 11/01/16 18:16, moeller0 wrote: > Hi Kevin, > > I agree the triple mode seems under-documented ;) Yes that's true but it is experimental after all - and I'm experimenting with it :-) >> On Jan 11, 2016, at 18:40 , Kevin Darbyshire-Bryant >> <ke...@darbyshire-bryant.m

[Cake] Possible BUG - parent backlog incorrectly updated in case of NET_XMIT_CN

2016-06-07 Thread Kevin Darbyshire-Bryant
Hi All, I was nosing through linux-netdev last night when I saw this fix for qdisc backlog reporting issues with NET_XMIT_CN in fq_codel: http://marc.info/?l=linux-netdev=146506223800713=2 I had a nose at CAKE but couldn't quit work out if a similar issue is present but I suspect it is.

Re: [Cake] Possible BUG - parent backlog incorrectly updated in case of NET_XMIT_CN

2016-06-07 Thread Kevin Darbyshire-Bryant
On 07/06/16 15:50, Jonathan Morton wrote: On 7 Jun, 2016, at 14:20, Kevin Darbyshire-Bryant <ke...@darbyshire-bryant.me.uk> wrote: I had a nose at CAKE but couldn't quit work out if a similar issue is present but I suspect it is. Certainly if Eric can't get it right "My prior att

Re: [Cake] CAKE upstream in LEDE

2016-06-07 Thread Kevin Darbyshire-Bryant
On 07/06/16 18:00, Dave Taht wrote: possibly 1. tc - 4.4.0-1 - Traffic control utility is what I have. Yes, you peaked too soon :-) Should be tc 4.4.0-2 :-) KDB ___ Cake mailing list Cake@lists.bufferbloat.net

Re: [Cake] Possible BUG - parent backlog incorrectly updated in case of NET_XMIT_CN

2016-06-11 Thread Kevin Darbyshire-Bryant
On 07/06/16 16:05, Kevin Darbyshire-Bryant wrote: On 07/06/16 15:50, Jonathan Morton wrote: On 7 Jun, 2016, at 14:20, Kevin Darbyshire-Bryant <ke...@darbyshire-bryant.me.uk> wrote: I had a nose at CAKE but couldn't quit work out if a similar issue is present but I s

Re: [Cake] New to cake. Some questions

2016-06-09 Thread Kevin Darbyshire-Bryant
On 09/06/16 21:58, Dennis Fedtke wrote: Hi Currently im running lede + cake + sqm_scripts and i have some questions: 1. What is considered the "optimal" setup atm for cake? e.g. which cake script should i use piece or layer cake? Piece of cake doesn't use diffserv hence doesn't 'soft shape'

[Cake] bufferbloat.net is sorely missed.

2016-06-10 Thread Kevin Darbyshire-Bryant
Greetings All, May this message find you in acceptable health and reasonable humour :-) Possibly/probably as a result of CAKE getting into LEDE I note a few people saying 'bufferbloat.net' is down. This is unfortunate just at a time when a hoped for uptick in interest factor may well be upon

Re: [Cake] [Bloat] bufferbloat.net is sorely missed.

2016-06-10 Thread Kevin Darbyshire-Bryant
On 10/06/16 10:02, Toke Høiland-Jørgensen wrote: Kevin Darbyshire-Bryant <ke...@darbyshire-bryant.me.uk> writes: Possibly/probably as a result of CAKE getting into LEDE I note a few people saying 'bufferbloat.net' is down. This is unfortunate just at a time when a hoped for

Re: [Cake] [lede-project/source] Add support for cake qdisc (#72)

2016-06-01 Thread Kevin Darbyshire-Bryant
On 01/06/16 12:41, moeller0 wrote: Hi Toke, I'm guessing this was probably discussed before and I've simply forgotten; but why does this (rewriting dscp bits) need to be part of the qdisc when you can do it with iptables? Well, cake looks at the DSCP bits already, if it can do the

Re: [Cake] [Codel] Proposing COBALT

2016-06-27 Thread Kevin Darbyshire-Bryant
On 27/06/16 04:56, Jonathan Morton wrote: On 4 Jun, 2016, at 22:55, Jonathan Morton wrote: COBALT should turn out to be a reasonable antidote to sender-side cheating, due to the way BLUE works; the drop probability remains steady until the queue has completely

Re: [Cake] [Codel] Proposing COBALT

2016-06-28 Thread Kevin Darbyshire-Bryant
On 28/06/16 03:51, Jonathan Morton wrote: On 27 Jun, 2016, at 18:18, Kevin Darbyshire-Bryant <ke...@darbyshire-bryant.me.uk> wrote: How do you feel about switching that package to the cobalt variant for wider stress testing? I think the best way to do that would be to merge the

Re: [Cake] tp-link archer c7 & cake & mac80211 fq_codel

2016-05-11 Thread Kevin Darbyshire-Bryant
LEDE on the C7 isn't a problem. Neither is sch_cake. Unfortunately AR71xx is on a 4.1 kernel. In the very brief flirtation I had with 4.4 on the C7, it appeared to work except for USB...at that point I backed out :-) Kevin On 11/05/16 22:53, Dave Taht wrote: > looks like it can be easily

Re: [Cake] tp-link archer c7 & cake & mac80211 fq_codel

2016-05-12 Thread Kevin Darbyshire-Bryant
On 11/05/16 23:39, Dave Taht wrote: > On Wed, May 11, 2016 at 3:15 PM, Kevin Darbyshire-Bryant > <ke...@darbyshire-bryant.me.uk> wrote: >> Forgot to mention - in slightly better news, the recent fq_codel >> flows_cnt = 128 recommendation from Eric has made it up

Re: [Cake] cake, codel5.h, ecn marking & dropping. Confused

2016-05-04 Thread Kevin Darbyshire-Bryant
On 04/05/16 12:41, Jonathan Morton wrote: >> On 4 May, 2016, at 12:57, Kevin Darbyshire-Bryant >> <ke...@darbyshire-bryant.me.uk> wrote: >> >> In essence my (mis)understanding of this code is something like: We've >> got here because we've been dropping

[Cake] cake, codel5.h, ecn marking & dropping. Confused

2016-05-04 Thread Kevin Darbyshire-Bryant
Hi All, As a result of Eric's recent change to fq_codel which, to use an analogy, when being subject to loads of sh*t, it's better to use a shovel to get rid of it rather than a teaspoon, I started having a nose deeper into cake than I've ever gone before. I was also interested to note that one

Re: [Cake] Beating bufferbloat

2016-05-01 Thread Kevin Darbyshire-Bryant
Hi Alec, I don't use that build, I roll my own so I don't know if there's anything particularly clever with it. However: I assume your clients are getting IPs via DHCP. The DHCP server on Openwrt is the truly wonderful dnsmasq. By default, dnsmasq advertises itself as the local dns

Re: [Cake] UDP floods and taking advantage of egress signalling at ingress

2016-05-06 Thread Kevin Darbyshire-Bryant
016 at 12:29 AM, Kevin Darbyshire-Bryant <ke...@darbyshire-bryant.me.uk<mailto:ke...@darbyshire-bryant.me.uk>> wrote: Hi All, My brain woke up with this idea rattling around in it this morning...obviously the subconscious has been busy. So here it is: Is there any way to use the egress drop

[Cake] Cake strange behaviour

2016-07-16 Thread Kevin Darbyshire-Bryant
Hi guys, Encountering some behaviour that I don't understand. Line is a 40/10 cake limited to 39000/9840. Overheads 12, 'dual-dsthosts' in ingress, 'dual-srcshosts' on engress - limiting the on the WAN line. Take a look at my ping response graph

Re: [Cake] Cake strange behaviour

2016-07-16 Thread Kevin Darbyshire-Bryant
to replicate? Hmmm, so far I've used a local flent server...I wonder if RTT is at play here? Kevin On 7/16/16 11:35 AM, Kevin Darbyshire-Bryant wrote: Hi guys, Encountering some behaviour that I don't understand. Line is a 40/10 cake limited to 39000/9840. Overheads 12, 'dual-dsthosts' in ingress

Re: [Cake] [Codel] Proposing COBALT

2016-06-28 Thread Kevin Darbyshire-Bryant
On 28/06/16 16:33, Jonathan Morton wrote: On 28 Jun, 2016, at 11:40, Kevin Darbyshire-Bryant <ke...@darbyshire-bryant.me.uk> wrote: Would you like me to split out 'sparse_flows' and 'decaying_flows'? No. A flow with BLUE active won’t be in “decaying flows” continuously until t

Re: [Cake] flow dissector idea/enhancement - help

2016-06-30 Thread Kevin Darbyshire-Bryant
On 02/06/16 13:29, Jonathan Morton wrote: On 2 Jun, 2016, at 14:09, Kevin Darbyshire-Bryant <ke...@darbyshire-bryant.me.uk> wrote: Cake uses the flow dissector API to do flow hashing...including per host flows for dual/triple isolation. The unfortunate bit is that the qdisc inev

Re: [Cake] [Codel] Proposing COBALT

2016-06-30 Thread Kevin Darbyshire-Bryant
On 29/06/16 16:22, Kevin Darbyshire-Bryant wrote: Ok, so the above is done: cobalt merged into mainline cake/master. cobalt branch rebased/fast-forwarded to the same place, so don't forget to 'git pull' (or fetch & merge) your own repos. Patches for LEDE to point at those latest upd

Re: [Cake] flow dissector idea/enhancement - help

2016-07-01 Thread Kevin Darbyshire-Bryant
On 30/06/16 20:23, Kevin Darbyshire-Bryant wrote: On 30/06/16 11:27, Jonathan Morton wrote: On 30 Jun, 2016, at 12:33, Kevin Darbyshire-Bryant <ke...@darbyshire-bryant.me.uk> wrote: +#ifdef CONFIG_NET_SCH_ESFQ_NFCT + enum ip_conntrack_info ctinfo; + struct nf_co

Re: [Cake] [Codel] Proposing COBALT

2016-06-29 Thread Kevin Darbyshire-Bryant
On 28/06/16 18:37, Kevin Darbyshire-Bryant wrote: Ok, so I've pushed the 'split u32 last_len into 2 u16' tweaks to tc-adv & sch_cake. I will push a corresponding change into LEDE for the iproute2 (tc) package. The push of sch_cake itself will happen after I've merged co

Re: [Cake] flow dissector idea/enhancement - help

2016-07-01 Thread Kevin Darbyshire-Bryant
On 01/07/16 09:11, Kevin Darbyshire-Bryant wrote: I'm beginning to think there's a reason why enhanced sfq which is where I found that code never made it upstream :-/ It's been/being an interesting little diversion...and I've modified a kernel module that so far doesn't crash :-) KDB

Re: [Cake] Configuring cake for VDSL2 bridged connection

2016-08-24 Thread Kevin Darbyshire-Bryant
The 'less wrong' overhead figure is 12. The incumbent telco BT who provide access to the 'last mile' (or the bit from the nearest FTTC cabinet and the property) use a VLAN tag, adding another 4 bytes to each frame going over the wire. The above guesswork based on SIN498

Re: [Cake] Configuring cake for VDSL2 bridged connection

2016-09-14 Thread Kevin Darbyshire-Bryant
On 14/09/16 21:06, techic...@gmail.com wrote: I'm back again, been quite busy so lost track of this. I'm using LEDE now too. Is there an easy way to see cake is actually working? A command or something I can type in just to get clarification? You can prove that cake is being used as the

[Cake] de-natting & host fairness

2016-09-25 Thread Kevin Darbyshire-Bryant
Greetings! A while back I started on a quest to make cake 'nat' aware as the lack of host fairness in a typical home router environment was the only thing that prevented cake from being the ultimate qdisc in my opinion. This involves dealing with conntrack which on egress is easy (the kernel

Re: [Cake] BUG_ON vs WARN_ON

2016-10-05 Thread Kevin Darbyshire-Bryant
On 05/10/16 17:38, Dave Taht wrote: I cannot repeat that result this morning, with either replace or change. Out of interest Dave, which branch are you building/testing? The 'master' or 'cobalt'? ___ Cake mailing list Cake@lists.bufferbloat.net

Re: [Cake] BUG_ON vs WARN_ON

2016-10-05 Thread Kevin Darbyshire-Bryant
On 05/10/16 16:53, Dave Taht wrote: I did test this version of cake yesterday, had no major problems, aside from: 1) it seeming not to register drops under some circumstances in the statistics. (could be flent) 2) switching stuff like this tc qdisc add dev eth0 root cake bandwidth 700mbit

Re: [Cake] BUG_ON vs WARN_ON

2016-10-05 Thread Kevin Darbyshire-Bryant
On 05/10/16 16:42, Jonathan Morton wrote: On 5 Oct, 2016, at 18:24, Kevin Darbyshire-Bryant <ke...@darbyshire-bryant.me.uk> wrote: How amenable are you to changing all 4 BUG_ON instances in cake to WARN_ON? Linus isn't a complete fan and I'm thinking that producing a stack trace and

Re: [Cake] BUG_ON vs WARN_ON

2016-10-07 Thread Kevin Darbyshire-Bryant
On 05/10/16 19:53, Jonathan Morton wrote: I wonder what it was that caused yesterday's issues? I really must try again when I've more time to get proper access. I’m having trouble reproducing it here. I know one of my boxes froze the very first time I loaded it, but it’s been running fine

Re: [Cake] BUG_ON vs WARN_ON

2016-10-07 Thread Kevin Darbyshire-Bryant
On 07/10/16 14:35, Jonathan Morton wrote: On 7 Oct, 2016, at 16:27, Kevin Darbyshire-Bryant <ke...@darbyshire-bryant.me.uk> wrote: It's now ok...so far :-) Okay. I think I’ve found a couple of other things to improve, so stand by… I'm not sure I can take all this excitement yo

[Cake] de NATting on older kernels

2016-10-09 Thread Kevin Darbyshire-Bryant
Greetings, Guido Sarducci has very kindly done the work to backport de-natting to <4.4.0 kernels (commit 70169dba14daa6ef7907af9c1e922ef9f797993a) This is now merged into cake/master. For those following the tree, don't forget to pull :-) JM - I've not yet cherry-picked that into cobalt

Re: [Cake] Master branch updated

2016-10-04 Thread Kevin Darbyshire-Bryant
On 04/10/16 08:22, Jonathan Morton wrote: I’ve just merged the NAT, PTM and Linux-4.8 compatibility stuff into the master branch of Cake. It’s stable code and a definite improvement. This frees up the Cobalt branch for more experimentation, such as the rewrite of triple-isolate that I also

Re: [Cake] Configuring cake for VDSL2 bridged connection

2016-09-15 Thread Kevin Darbyshire-Bryant
On 14/09/16 21:48, Sebastian Moeller wrote: Whilst in this section of the LuCi GUI, I noticed "Which linklayer adaptation mechanism to use; for testing only", has a "cake" option? Should this be enabled? Yes it should be enabled. This really depends... Tc's stab (size table) method

Re: [Cake] de-natting & host fairness

2016-09-28 Thread Kevin Darbyshire-Bryant
: On 28 Sep, 2016, at 05:56, Kevin Darbyshire-Bryant <ke...@darbyshire-bryant.me.uk> wrote: Does this need to be another variable/parameter or could it be the next bit along in the flow type? I’ve already pushed it to the ‘cobalt’ branch, so you can see how I’ve done it and start testing.

Re: [Cake] de-natting & host fairness

2016-09-27 Thread Kevin Darbyshire-Bryant
On 28/09/16 00:08, Jonathan Morton wrote: On 26 Sep, 2016, at 06:20, Kevin Darbyshire-Bryant <ke...@darbyshire-bryant.me.uk> wrote: Another github user 'tegularius' presented some beautifully crafted code that did the lookups in a much neater way. Originally it too had an 'ingress'

Re: [Cake] de-natting & host fairness

2016-09-28 Thread Kevin Darbyshire-Bryant
On 28/09/16 07:07, Kevin Darbyshire-Bryant wrote: Two buglets found: in sch_cake - the atm/ptm flag options are not passed back to tc userspace correctly - ptm isn't sent back. Just fixed that & pushed don't forget to pull :-) ___

Re: [Cake] de-natting & host fairness

2016-09-27 Thread Kevin Darbyshire-Bryant
, Noah Causin On 9/26/2016 10:32 PM, Kevin Darbyshire-Bryant wrote: Easy fix. See the added DEPENDS line in the attached patch for the package Makefile :-) I'm guessing you've updated the git checkout hash to point at a suitable place. Cheers, Kevin On 27/09/16 02:52, Noah Causin wrote

Re: [Cake] de-natting & host fairness

2016-09-26 Thread Kevin Darbyshire-Bryant
measure as cake will not simply reduce the available bandwidth when running out of CPU cycles but first will allow the latency to increase. Best Regards Sebastian On Sep 26, 2016, at 05:20 , Kevin Darbyshire-Bryant <ke...@darbyshire-bryant.me.uk> wrote: Greetings! A while back I star

Re: [Cake] de-natting & host fairness

2016-09-26 Thread Kevin Darbyshire-Bryant
On 26/09/16 14:28, moeller0 wrote: Hi Kevin, This really needs to be tested. As I mentioned the 'ingress' side of things is harder work because the kernel hasn't filled in the conntrack pointer for us. There are some remaining concerns over how reliable our own lookup actually is. The

Re: [Cake] de-natting & host fairness

2016-09-26 Thread Kevin Darbyshire-Bryant
: Package kmod-sched-cake is missing dependencies for the following libraries: nf_conntrack.ko >From 2d0d549f072379da20be70535c14b40496d42dfb Mon Sep 17 00:00:00 2001 From: Kevin Darbyshire-Bryant <ke...@darbyshire-bryant.me.uk> Date: Thu, 30 Jun 2016 16:09:32 +0100 Subject: [PATCH 1/3] k

Re: [Cake] Choosing a tin to work on

2017-04-12 Thread Kevin Darbyshire-Bryant
On 11/04/17 14:59, George Amanakis wrote: Hi Jonathan, I have some questions regarding the algorithm to choose a tin to dequeue from in sch_cake.c: ---8< int oi, best_tin=0; s64 best_time = 0xUL; for(oi=0; oi < q->tin_cnt; oi++) {

Re: [Cake] Questions on Cake/cobalts experiment ingress mode

2017-04-06 Thread Kevin Darbyshire-Bryant
Ahh, cheers Jonathan, understand! (and thanks for the really quick reply) Kevin (much less confused) On 06/04/17 10:19, Jonathan Morton wrote: On 6 Apr, 2017, at 12:17, Kevin Darbyshire-Bryant <ke...@darbyshire-bryant.me.uk> wrote: Can I now apply two qdiscs to eth0 di

[Cake] Questions on Cake/cobalts experiment ingress mode

2017-04-06 Thread Kevin Darbyshire-Bryant
Hi All, I've been out of the loop for a while and just noticed the 'ingress' mode for cake in the cobalt experimental branch. Colour me confused on how to use this. My (typical) situation is I've 'eth0' as my WAN port connected to an ISP VDSL2 modem - this is naturally asymmetric in

Re: [Cake] cake status & forks

2017-06-29 Thread Kevin Darbyshire-Bryant
On 27/06/17 19:41, Adrian Popescu wrote: Hello, I've been reading the code for a while. I'll experiment and send any useful patches. The technical docs would have been extremely useful in the process. The CakeTechnical page is useful, but it lacks descriptions of the algorithms. Is cake

Re: [Cake] Cake on LEDE - package maintainer required

2017-06-13 Thread Kevin Darbyshire-Bryant
On 13/06/2017 23:02, Stephen Hemminger wrote: > On Tue, 13 Jun 2017 18:41:05 +0100 > Kevin Darbyshire-Bryant <ke...@darbyshire-bryant.me.uk> wrote: > >> Hi All, >> >> This email finds me looking for a volunteer/s to take over the ownership >> of the cake q

[Cake] Cake on LEDE - package maintainer required

2017-06-13 Thread Kevin Darbyshire-Bryant
Hi All, This email finds me looking for a volunteer/s to take over the ownership of the cake qdisc module package in LEDE. It's not particularly onerous, in essence making sure the package points at the git commit considered 'stable'. In theory there's a 'matching' user space patch for

Re: [Cake] Cake on LEDE - package maintainer required

2017-06-28 Thread Kevin Darbyshire-Bryant
On 28/06/17 00:58, Outback Dingo wrote: Ill take it Thank you, appreciated. I can update my patch into LEDE where I drop maintainer to change to you, or you can generate your own patch to take over up to you. The PKG_MAINTAINER field does require a real name though. Cheers,

[Cake] WiSHLIST Meticulous In-person Cake Codebase Study Session

2017-10-10 Thread Kevin Darbyshire-Bryant
I wish this would happen for cake: https://lists.zx2c4.com/pipermail/wireguard/2017-October/001801.html ___ Cake mailing list Cake@lists.bufferbloat.net https://lists.bufferbloat.net/listinfo/cake

Re: [Cake] overhead and mpu

2017-09-05 Thread Kevin Darbyshire-Bryant
On 05/09/17 09:01, Sebastian Moeller wrote: I believe this is used internally so cake can deduce the size of the automatically added overhead (the linux kernel will add 14 bytes on ethernet interfaces automatically, which while certainly justifiable are not the ideal value for an

Re: [Cake] overhead and mpu

2017-09-05 Thread Kevin Darbyshire-Bryant
On 05/09/17 15:37, Ryan Mounce wrote: +1 It would also be nice for tc to know whether the overhead has been explicitly configured and report appropriately. In my case I use cake on a VLAN sub-interface that happens to have a hard_header_len of 18 after the 802.1q tag, and then use the

Re: [Cake] allocate_src allocate_dst

2017-11-25 Thread Kevin Darbyshire-Bryant
> On 25 Nov 2017, at 16:41, Jonathan Morton wrote: > > Not quite. The "dual" enums have more than one bit set, so you have to test > them for equality. > > - Jonathan Morton Here you go

[Cake] RFC: allocate without the gotos

2017-11-26 Thread Kevin Darbyshire-Bryant
Hi All, If anyone is brave I’ve just done a commit with the src/dst host allocate stuff minus the gotos. Not even compile tested! Woke up with it in my head. I’m not convinced it’s really cleaner, absolutely no idea if it’s faster. But it’s here with all sorts of major caveats :-)

Re: [Cake] RFC: allocate without the gotos

2017-11-26 Thread Kevin Darbyshire-Bryant
> On 26 Nov 2017, at 10:00, Jonathan Morton wrote: > > On a purely theoretical basis, it probably isn't as fast, because now the > 'found' condition has to be tested multiple times on the fast and slow paths > alike. Only if the compiler is smart enough to transform

Re: [Cake] allocate_src allocate_dst

2017-11-26 Thread Kevin Darbyshire-Bryant
Have to say, my perception is that I’ve a small cpu usage improvement for my use case with these changes. Then I would expect that ‘cos I use ‘dual-srchost’ on egress and ‘dual-dsthost’ on ingress, so I’m saving running the dst/src host allocation code on egress/ingress respectively. Of

Re: [Cake] allocate_src allocate_dst

2017-11-25 Thread Kevin Darbyshire-Bryant
https://github.com/dtaht/sch_cake/pull/74 Once again, sorry about the screwup. > On 25 Nov 2017, at 20:49, Kevin Darbyshire-Bryant > <ke...@darbyshire-bryant.me.uk> wrote: > > [This sender failed our fraud detection checks and may not be who they appear > to be. Learn a

Re: [Cake] allocate_src allocate_dst

2017-11-25 Thread Kevin Darbyshire-Bryant
> On 25 Nov 2017, at 16:41, Jonathan Morton wrote: > > Not quite. The "dual" enums have more than one bit set, so you have to test > them for equality. > > - Jonathan Morton Oh dammit, yes they are dual bit flags, rats. good catch. v2 shortly he he :-)

Re: [Cake] allocate_src allocate_dst

2017-11-25 Thread Kevin Darbyshire-Bryant
> On 25 Nov 2017, at 15:19, Jonathan Morton wrote: > > I think I originally intended to make them individually conditional on the > src/dest host flags, but that idea evidently got forgotten. > > - Jonathan Morton Ahh, is this

Re: [Cake] allocate_src allocate_dst

2017-11-25 Thread Kevin Darbyshire-Bryant
Ooops, sorry, dodge merge on my part from my work tree back to cobalt. A fix & PR will be with you shortly…. apologies. Kevin > On 25 Nov 2017, at 20:03, George Amanakis wrote: > > I think we missed an "allocate_host" in cake_hash(), line ~810: > > if (allocate_host) {

Re: [Cake] new patchset for upstream net-next

2017-11-26 Thread Kevin Darbyshire-Bryant
> On 26 Nov 2017, at 18:22, Dave Taht wrote: > > Toke Høiland-Jørgensen writes: > >> gamana...@gmail.com writes: >> >>> Just finished building, setting both sch_cake and nf_conntrack as >>> integral succeeds. Setting nf_conntrack as module fails with sch_cake

Re: [Cake] cobalt through checkpatch

2017-11-23 Thread Kevin Darbyshire-Bryant
> On 21 Nov 2017, at 21:59, Dave Taht wrote: > > > You will want to pull and rebase on top of this. > > Are there any other patches still lying out of tree worth considering? Just did a PR for turning max_skblen (or whatever it is) to a u32….since there *are* super packets

Re: [Cake] cobalt through checkpatch

2017-11-23 Thread Kevin Darbyshire-Bryant
> On 23 Nov 2017, at 17:07, Dave Taht <d...@taht.net> wrote: > > Kevin Darbyshire-Bryant <ke...@darbyshire-bryant.me.uk> writes: >> >> Just did a PR for turning max_skblen (or whatever it is) to a u32….since >> there *are* super packets out there

Re: [Cake] Cake tree unreadable

2017-11-28 Thread Kevin Darbyshire-Bryant
> On 28 Nov 2017, at 18:48, Dave Taht wrote: > > > > It sounds like your git-foo is stronger than ours! I'm not even trying > to get head to work, tho my intent would be to promote cobalt to it. git checkout master git pull (does the equivalent of git fetch origin; git

Re: [Cake] allocate_src allocate_dst

2017-11-25 Thread Kevin Darbyshire-Bryant
> On 25 Nov 2017, at 03:59, Dave Taht wrote: > > there is no place in the current code base where these are not both > true or both false. Thus redundant. > > ? Yes, interesting that. Been there since introduced in 5a6da2ba Add triple-isolation support. *EXPERIMENTAL*

Re: [Cake] options for shrinking cake xstats

2017-12-16 Thread Kevin Darbyshire-Bryant
This didn’t seem to generate any response so I’ll have a go :-) > On 6 Dec 2017, at 00:06, Dave Taht wrote: > > as 1400+ bytes on the parisc stack, is a bit much. That said, I don't > see much possibility for shrinkage overall. How much over do you happen to know? I see a

Re: [Cake] overhead for double nat VDSL2 connection

2017-12-17 Thread Kevin Darbyshire-Bryant
> On 17 Dec 2017, at 15:23, Sebastian Moeller wrote: > > Hi Mark, > >> On Dec 17, 2017, at 11:45, Mark Captur wrote: >> >> My setup is as follows >> >> vdsl2 modem doing pppoe itself and nat to 10.x.x.x -> lede master eth0.2 >> (wan static ip in

Re: [Cake] [Fwd: Re: RHODIUM - nuking blue (for testing)]

2017-12-07 Thread Kevin Darbyshire-Bryant
> On 7 Dec 2017, at 02:19, Jonathan Morton wrote: > > > It would be nice to have a test showing blue being useful. > > To do that, you would need to have a saturating unresponsive load, such as a > UDP flood, which drives Cake's queue to the memory limit. Even then, I

Re: [Cake] cake vs fqcodel with 1 client, 4 servers

2017-12-07 Thread Kevin Darbyshire-Bryant
> On 7 Dec 2017, at 08:21, Jonathan Morton wrote: > > Okay, I found that the parameters used were suspicious and didn't prevent > Cake from dropping packets. I've pushed a tc-adv update to fix that, so you > should try that again. > > Other RTT keywords are

Re: [Cake] overheads or rate calculation changed?

2017-12-21 Thread Kevin Darbyshire-Bryant
> On 22 Dec 2017, at 06:38, Jonathan Morton wrote: > >> On 21 Dec, 2017, at 2:54 am, Andy Furniss wrote: >> >> refactor cake_advance_shaper and ack_filter >> >> cake_advance_shaper now returns a modified len argument to >> reflect

Re: [Cake] overheads or rate calculation changed?

2017-12-24 Thread Kevin Darbyshire-Bryant
> On 23 Dec 2017, at 21:03, Sebastian Moeller wrote: > > Hi All, > > just had a look for hard_header_len in the linux kernel: > linux/include/linux/netdevice.h: > * @hard_header_len: Maximum hardware header length. > * @min_header_len: Minimum hardware header

Re: [Cake] overheads or rate calculation changed?

2017-12-24 Thread Kevin Darbyshire-Bryant
> On 24 Dec 2017, at 10:39, Jonathan Morton wrote: > > If you combine the 'raw' keyword with an overhead spec, that disables the > hard_header_len compensation. > > - Jonathan Morton Indeed. I think all I’m proving is ‘make something idiot proof…..they’ll only go

Re: [Cake] overheads or rate calculation changed?

2017-12-22 Thread Kevin Darbyshire-Bryant
> On 22 Dec 2017, at 10:00, Jonathan Morton wrote: > > Git seems to regularly get confused when similar code changes occur in > parallel in different branches. In this case, I had the original version of > ingress mode while the public tree had the reconstructed

Re: [Cake] [PATCH] q_cake: Update xstats format to use per-tin structure

2018-03-07 Thread Kevin Darbyshire-Bryant
> On 7 Mar 2018, at 18:27, Kevin Darbyshire-Bryant > <ke...@darbyshire-bryant.me.uk> wrote: > > > >> On 7 Mar 2018, at 12:59, Toke Høiland-Jørgensen <t...@toke.dk> wrote: >> >> >>> qdisc cake 8004: root refcnt 4486780 bandwidth 199

Re: [Cake] [PATCH] q_cake: Update xstats format to use per-tin structure

2018-03-07 Thread Kevin Darbyshire-Bryant
> On 7 Mar 2018, at 12:59, Toke Høiland-Jørgensen wrote: > > >> qdisc cake 8004: root refcnt 4486780 bandwidth 19900Kbit diffserv3 >> dual-srchost nat rtt 100.0ms ptm overhead 4502152 >> Sent 42615751 bytes 4491092 pkt (dropped 4491108, overlimits 4491124 >> requeues 4491152)

Re: [Cake] [PATCH] q_cake: Update xstats format to use per-tin structure

2018-03-08 Thread Kevin Darbyshire-Bryant
> On 8 Mar 2018, at 07:59, Kevin Darbyshire-Bryant > <ke...@darbyshire-bryant.me.uk> wrote: > > Definitely dubious and I’m no longer convinced it’s a cake only issue. > Looked at my AP which is running an older version of openwrt, so older cake, > older kerne

Re: [Cake] [PATCH] q_cake: Update xstats format to use per-tin structure

2018-03-08 Thread Kevin Darbyshire-Bryant
> On 8 Mar 2018, at 00:49, Jonathan Morton wrote: > >> On 7 Mar, 2018, at 11:34 pm, Toke Høiland-Jørgensen wrote: >> >> Ah, totally missed that those were wrong as well. The values for >> dropped, overlimits and requeues are not printed by the

Re: [Cake] [PATCH] q_cake: Update xstats format to use per-tin structure

2018-03-08 Thread Kevin Darbyshire-Bryant
> On 8 Mar 2018, at 10:57, Toke Høiland-Jørgensen <t...@toke.dk> wrote: > > Kevin Darbyshire-Bryant <ke...@darbyshire-bryant.me.uk> writes: > >> Archer c7 v2. master branch of openwrt > > Ah, great; I actually have one of those sitting on my desk that I

Re: [Cake] [PATCH] q_cake: Update xstats format to use per-tin structure

2018-03-08 Thread Kevin Darbyshire-Bryant
> On 8 Mar 2018, at 11:09, Kevin Darbyshire-Bryant > <ke...@darbyshire-bryant.me.uk> wrote: > > > >> On 8 Mar 2018, at 10:57, Toke Høiland-Jørgensen <t...@toke.dk> wrote: >> >> Kevin Darbyshire-Bryant <ke...@darbyshire-bryant.me.uk> wri

Re: [Cake] [PATCH 2/2] tc print_uint format fixes

2018-03-11 Thread Kevin Darbyshire-Bryant
> On 11 Mar 2018, at 20:50, Toke Høiland-Jørgensen <t...@toke.dk> wrote: > > Kevin Darbyshire-Bryant <l...@darbyshire-bryant.me.uk> writes: > >> Signed-off-by: Kevin Darbyshire-Bryant <l...@darbyshire-bryant.me.uk> >> --- >&

Re: [Cake] [PATCH 1/2] cake: print_uint format fixes

2018-03-11 Thread Kevin Darbyshire-Bryant
> On 11 Mar 2018, at 20:49, Toke Høiland-Jørgensen <t...@toke.dk> wrote: > > Thank you for the patch! :) > >> Signed-off-by: Kevin Darbyshire-Bryant <l...@darbyshire-bryant.me.uk> >> --- >> tc/q_cake.c | 15 --- >> 1 file changed, 8

Re: [Cake] [PATCH 1/2] cake: print_uint format fixes

2018-03-12 Thread Kevin Darbyshire-Bryant
> On 11 Mar 2018, at 23:34, Stephen Hemminger <step...@networkplumber.org> > wrote: > > On Sun, 11 Mar 2018 22:10:51 + > Kevin Darbyshire-Bryant <ke...@darbyshire-bryant.me.uk> wrote: > >> negative? >> >> Tried it, and you’d sort of guess

[Cake] [PATCH 2/2] tc print_uint format fixes

2018-03-11 Thread Kevin Darbyshire-Bryant
Signed-off-by: Kevin Darbyshire-Bryant <l...@darbyshire-bryant.me.uk> --- tc/tc_qdisc.c | 3 ++- tc/tc_util.c | 24 2 files changed, 14 insertions(+), 13 deletions(-) diff --git a/tc/tc_qdisc.c b/tc/tc_qdisc.c index 70279b9d..3ec74a1c 100644 --- a/tc/tc_qdisc.c

[Cake] [PATCH 1/2] cake: print_uint format fixes

2018-03-11 Thread Kevin Darbyshire-Bryant
Signed-off-by: Kevin Darbyshire-Bryant <l...@darbyshire-bryant.me.uk> --- tc/q_cake.c | 15 --- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/tc/q_cake.c b/tc/q_cake.c index 44cadb63..f888bd2a 100644 --- a/tc/q_cake.c +++ b/tc/q_cake.c @@ -47,6 +47,7 @@ #i

[Cake] fixing tc cake output since json-ification

2018-03-11 Thread Kevin Darbyshire-Bryant
Here's 2 patches that fix (for me!) tc's strange output on a MIPS platform. [PATCH 1/2] cake: print_uint format fixes [PATCH 2/2] tc print_uint format fixes ___ Cake mailing list Cake@lists.bufferbloat.net https://lists.bufferbloat.net/listinfo/cake

Re: [Cake] [PATCH 1/2] cake: print_uint format fixes

2018-03-12 Thread Kevin Darbyshire-Bryant
> On 12 Mar 2018, at 15:38, Toke Høiland-Jørgensen wrote: > > Stephen Hemminger writes: > Using the ‘PRId64’ macro won’t work because print_int is using ‘int’ type internally whereas print_uint uses ‘uint64_t’ internally. So the format

Re: [Cake] [PATCH 1/2] cake: print_uint format fixes

2018-03-16 Thread Kevin Darbyshire-Bryant
formats you should use the relevant PRIdN or PRIuN formats as defined in inttypes.h e.g. print_uint64(PRINT_ANY, "refcnt", "refcnt %" PRIu64 " ", t->tcm_info) Signed-off-by: Kevin Darbyshire-Bryant <l...@darbyshire-bryant.me.uk> --- include/json_print.h | 6 +-

Re: [Cake] [PATCH] q_cake: Update xstats format to use per-tin structure

2018-03-10 Thread Kevin Darbyshire-Bryant
> On 8 Mar 2018, at 11:21, Toke Høiland-Jørgensen wrote: > >> >> Oh and curiously the bad values go away if you ask for json output >> it’s much better. Which rather points at a ‘feature’ of the >> ‘print_string’ behaviour. > > Right. Well, the print_* functions are behind

Re: [Cake] [PATCH] q_cake: Update xstats format to use per-tin structure

2018-03-07 Thread Kevin Darbyshire-Bryant
> On 7 Mar 2018, at 10:31, Toke Høiland-Jørgensen wrote: > >> > > Please don't put something different into LEDE than what we're working > on upstreaming. It is difficult enough to keep track of the different > versions as they are. The tc-adv repo is already rebased on the

Re: [Cake] [PATCH] q_cake: Update xstats format to use per-tin structure

2018-03-07 Thread Kevin Darbyshire-Bryant
There were some useful stats column re-alignment changes as well, wonder if you got those? > On 7 Mar 2018, at 10:36, Toke Høiland-Jørgensen <t...@toke.dk> wrote: > > Toke Høiland-Jørgensen <t...@toke.dk> writes: > >> Kevin Darbyshire-Bryant <ke...@darbyshire

Re: [Cake] [PATCH] q_cake: Update xstats format to use per-tin structure

2018-03-07 Thread Kevin Darbyshire-Bryant
<t...@toke.dk> wrote: > > Kevin Darbyshire-Bryant <ke...@darbyshire-bryant.me.uk> writes: > >> There were some useful stats column re-alignment changes as well, >> wonder if you got those? > > Probably not, as that code is not longer directly diff

Re: [Cake] [PATCH] q_cake: Update xstats format to use per-tin structure

2018-03-07 Thread Kevin Darbyshire-Bryant
Hi All, > On 7 Mar 2018, at 08:50, Toke Høiland-Jørgensen wrote: > > Jonathan Morton writes: > >>> On 6 Mar, 2018, at 11:06 pm, Toke Høiland-Jørgensen wrote: >>> >>> ...on the iproute2 side the only >>> thing missing before we can attempt

Re: [Cake] [PATCH net-next v12 3/7] sch_cake: Add optional ACK filter

2018-05-18 Thread Kevin Darbyshire-Bryant
> On 18 May 2018, at 05:27, Cong Wang wrote: > > On Thu, May 17, 2018 at 4:23 AM, Toke Høiland-Jørgensen wrote: >> Eric Dumazet writes: >> >>> On 05/16/2018 01:29 PM, Toke Høiland-Jørgensen wrote: The ACK filter is an

Re: [Cake] tc not showing detailed stats

2018-05-20 Thread Kevin Darbyshire-Bryant
> On 20 May 2018, at 14:23, Georgios Amanakis wrote: > > Hi All, > > I am running latest tc-adv (r4227) and sch-cake/cobalt (r500), and "tc > -s qdisc show" doesn't show detailed stats anymore. Latest known > working revisions for me were tc-adv:r4226 sch-cake:r494. > >

Re: [Cake] A few puzzling Cake results

2018-04-18 Thread Kevin Darbyshire-Bryant via Cake
--- Begin Message --- > On 18 Apr 2018, at 12:25, Toke Høiland-Jørgensen wrote: > > Toke Høiland-Jørgensen writes: > >> Jonathan Morton writes: >> On 17 Apr, 2018, at 12:42 pm, Toke Høiland-Jørgensen wrote: -

Re: [Cake] A few puzzling Cake results

2018-04-18 Thread Kevin Darbyshire-Bryant via Cake
--- Begin Message --- > On 18 Apr 2018, at 19:11, Toke Høiland-Jørgensen wrote: > > Jonas Mårtensson writes: > >> Dave, in the thread referenced earlier that led to this change you said: >> >> "The loss of throughput here compared to non-ingress

Re: [Cake] A few puzzling Cake results

2018-04-19 Thread Kevin Darbyshire-Bryant via Cake
--- Begin Message --- > On 18 Apr 2018, at 19:16, Kevin Darbyshire-Bryant via Cake > <cake@lists.bufferbloat.net> wrote: > > I know this can be writted betterrer but I think this is the sort of thing > we’re pondering over? > > https://github.co

Re: [Cake] Testing variants of the MTU latency scaling

2018-04-24 Thread Kevin Darbyshire-Bryant via Cake
--- Begin Message --- Assuming you’re using luci to configure then enabling both show and use advanced configuration & show and use dangerous configurations… then enter ‘ingress’ in the ‘advanced option string to pass to ingress queuing’ will enable ingress mode. Maybe that helps? > On 24 Apr

Re: [Cake] Testing variants of the MTU latency scaling

2018-04-24 Thread Kevin Darbyshire-Bryant via Cake
--- Begin Message --- > On 23 Apr 2018, at 11:50, Jonathan Morton wrote: > >> Right. Pushed the patch to the cobalt branch, feel free to fix it up :) > > Given that I basically had to revert 80% of it and start again, perhaps not > the best policy. Ha :-)

  1   2   >