Re: [Cake] [PATCH] q_cake: Update xstats format to use per-tin structure

2018-03-10 Thread Luis E. Garcia
Nice work Kevin. On Sat, Mar 10, 2018 at 09:56 Kevin Darbyshire-Bryant < ke...@darbyshire-bryant.me.uk> wrote: > > > > On 8 Mar 2018, at 11:21, Toke Høiland-Jørgensen wrote: > > > >> > >> Oh and curiously the bad values go away if you ask for json output > >> it’s much better.

Re: [Cake] [PATCH] q_cake: Update xstats format to use per-tin structure

2018-03-10 Thread Kevin Darbyshire-Bryant
> On 8 Mar 2018, at 11:21, Toke Høiland-Jørgensen wrote: > >> >> Oh and curiously the bad values go away if you ask for json output >> it’s much better. Which rather points at a ‘feature’ of the >> ‘print_string’ behaviour. > > Right. Well, the print_* functions are behind

Re: [Cake] [PATCH] q_cake: Update xstats format to use per-tin structure

2018-03-08 Thread Pete Heist
> On Mar 7, 2018, at 12:26 PM, Dave Taht wrote: > > For those that haven't been tracking https://www.facebook.com/dtaht - > > I bought an old 35' sailboat in the santa cruz, ca, harbor in December > for 1 BTC. I figured living aboard would be cheaper than california >

Re: [Cake] [PATCH] q_cake: Update xstats format to use per-tin structure

2018-03-08 Thread Georgios Amanakis
I am currently testing on my router, Archlinux with kernels 4.14.24/4.15.7, sch_cake from cobalt and tc-adv but it is behaving as it should: ==8<== qdisc cake 8001: dev ens4 root refcnt 2 bandwidth 12200Kbit besteffort dual-dsthost wash ingress rtt 100.0ms noatm overhead 18mpu 64

Re: [Cake] [PATCH] q_cake: Update xstats format to use per-tin structure

2018-03-08 Thread Toke Høiland-Jørgensen
Kevin Darbyshire-Bryant writes: >> On 8 Mar 2018, at 11:09, Kevin Darbyshire-Bryant >> wrote: >> >> >> >>> On 8 Mar 2018, at 10:57, Toke Høiland-Jørgensen wrote: >>> >>> Kevin Darbyshire-Bryant

Re: [Cake] [PATCH] q_cake: Update xstats format to use per-tin structure

2018-03-08 Thread Kevin Darbyshire-Bryant
> On 8 Mar 2018, at 11:09, Kevin Darbyshire-Bryant > wrote: > > > >> On 8 Mar 2018, at 10:57, Toke Høiland-Jørgensen wrote: >> >> Kevin Darbyshire-Bryant writes: >> >>> Archer c7 v2. master branch of openwrt >>

Re: [Cake] [PATCH] q_cake: Update xstats format to use per-tin structure

2018-03-08 Thread Kevin Darbyshire-Bryant
> On 8 Mar 2018, at 10:57, Toke Høiland-Jørgensen wrote: > > Kevin Darbyshire-Bryant writes: > >> Archer c7 v2. master branch of openwrt > > Ah, great; I actually have one of those sitting on my desk that I could > potentially reflash without

Re: [Cake] [PATCH] q_cake: Update xstats format to use per-tin structure

2018-03-08 Thread Toke Høiland-Jørgensen
Kevin Darbyshire-Bryant writes: > Archer c7 v2. master branch of openwrt Ah, great; I actually have one of those sitting on my desk that I could potentially reflash without breaking anything too important. In the meantime; do you get the same weird output on the

Re: [Cake] [PATCH] q_cake: Update xstats format to use per-tin structure

2018-03-08 Thread Toke Høiland-Jørgensen
Kevin Darbyshire-Bryant writes: >> On 8 Mar 2018, at 07:59, Kevin Darbyshire-Bryant >> wrote: >> >> Definitely dubious and I’m no longer convinced it’s a cake only issue. >> Looked at my AP which is running an older version of

Re: [Cake] [PATCH] q_cake: Update xstats format to use per-tin structure

2018-03-08 Thread Kevin Darbyshire-Bryant
> On 8 Mar 2018, at 07:59, Kevin Darbyshire-Bryant > wrote: > > Definitely dubious and I’m no longer convinced it’s a cake only issue. > Looked at my AP which is running an older version of openwrt, so older cake, > older kernel etc etc and all qdiscs are

Re: [Cake] [PATCH] q_cake: Update xstats format to use per-tin structure

2018-03-08 Thread Kevin Darbyshire-Bryant
> On 8 Mar 2018, at 00:49, Jonathan Morton wrote: > >> On 7 Mar, 2018, at 11:34 pm, Toke Høiland-Jørgensen wrote: >> >> Ah, totally missed that those were wrong as well. The values for >> dropped, overlimits and requeues are not printed by the

Re: [Cake] [PATCH] q_cake: Update xstats format to use per-tin structure

2018-03-07 Thread Jonathan Morton
> On 7 Mar, 2018, at 11:34 pm, Toke Høiland-Jørgensen wrote: > > Ah, totally missed that those were wrong as well. The values for > dropped, overlimits and requeues are not printed by the cake-specific > code at all, so there is something else dubious going on. Could they be

Re: [Cake] [PATCH] q_cake: Update xstats format to use per-tin structure

2018-03-07 Thread Toke Høiland-Jørgensen
Kevin Darbyshire-Bryant writes: >> On 7 Mar 2018, at 12:59, Toke Høiland-Jørgensen wrote: >> >> >>> qdisc cake 8004: root refcnt 4486780 bandwidth 19900Kbit diffserv3 >>> dual-srchost nat rtt 100.0ms ptm overhead 4502152 >>> Sent 42615751 bytes

Re: [Cake] [PATCH] q_cake: Update xstats format to use per-tin structure

2018-03-07 Thread Jonathan Morton
> On 7 Mar, 2018, at 8:27 pm, Kevin Darbyshire-Bryant > wrote: > >> Are you using the latest kernel code? Those values were added in an >> incompatible manner, so if you don't have userspace and kernel code in >> sync they'll be garbage, basically… > > I’m using

Re: [Cake] [PATCH] q_cake: Update xstats format to use per-tin structure

2018-03-07 Thread Kevin Darbyshire-Bryant
> On 7 Mar 2018, at 18:27, Kevin Darbyshire-Bryant > wrote: > > > >> On 7 Mar 2018, at 12:59, Toke Høiland-Jørgensen wrote: >> >> >>> qdisc cake 8004: root refcnt 4486780 bandwidth 19900Kbit diffserv3 >>> dual-srchost nat rtt 100.0ms ptm

Re: [Cake] [PATCH] q_cake: Update xstats format to use per-tin structure

2018-03-07 Thread Kevin Darbyshire-Bryant
> On 7 Mar 2018, at 12:59, Toke Høiland-Jørgensen wrote: > > >> qdisc cake 8004: root refcnt 4486780 bandwidth 19900Kbit diffserv3 >> dual-srchost nat rtt 100.0ms ptm overhead 4502152 >> Sent 42615751 bytes 4491092 pkt (dropped 4491108, overlimits 4491124 >> requeues 4491152)

Re: [Cake] [PATCH] q_cake: Update xstats format to use per-tin structure

2018-03-07 Thread Dave Taht
On Wed, Mar 7, 2018 at 7:52 AM, Toke Høiland-Jørgensen wrote: > Dave Taht writes: > >> So it sounds like all the individual pieces are sync'd again? >> >> 4.16-rc4 is out, so there are several weeks left to make the net-next >> window. I note that I don't feel

Re: [Cake] [PATCH] q_cake: Update xstats format to use per-tin structure

2018-03-07 Thread Toke Høiland-Jørgensen
Dave Taht writes: > So it sounds like all the individual pieces are sync'd again? > > 4.16-rc4 is out, so there are several weeks left to make the net-next > window. I note that I don't feel strongly (never had) that I should be > the one to make the net-next submission,

Re: [Cake] [PATCH] q_cake: Update xstats format to use per-tin structure

2018-03-07 Thread Dave Taht
So it sounds like all the individual pieces are sync'd again? 4.16-rc4 is out, so there are several weeks left to make the net-next window. I note that I don't feel strongly (never had) that I should be the one to make the net-next submission, just so long as it now gets through checkpatch (?)...

Re: [Cake] [PATCH] q_cake: Update xstats format to use per-tin structure

2018-03-07 Thread Toke Høiland-Jørgensen
Sebastian Moeller writes: >> diff --git a/tc/q_cake.c b/tc/q_cake.c >> index e21552e8..95301b41 100644 >> --- a/tc/q_cake.c >> +++ b/tc/q_cake.c >> @@ -243,12 +243,22 @@ static int cake_parse_opt(struct qdisc_util *qu, int >> argc, char **argv, >>/* Typical

Re: [Cake] [PATCH] q_cake: Update xstats format to use per-tin structure

2018-03-07 Thread Sebastian Moeller
Hi Toke, > On Mar 7, 2018, at 13:59, Toke Høiland-Jørgensen wrote: > > Kevin Darbyshire-Bryant writes: > >> I don’t the column alignment can be correct because the print lines don’t >> include a leading space, so columns can run into each other.

Re: [Cake] [PATCH] q_cake: Update xstats format to use per-tin structure

2018-03-07 Thread Toke Høiland-Jørgensen
Kevin Darbyshire-Bryant writes: > I don’t the column alignment can be correct because the print lines don’t > include a leading space, so columns can run into each other. > > fprintf(f, "%12u", tst->unresponse_flows); > v > fprintf(f, " %12u",

Re: [Cake] [PATCH] q_cake: Update xstats format to use per-tin structure

2018-03-07 Thread Kevin Darbyshire-Bryant
I don’t the column alignment can be correct because the print lines don’t include a leading space, so columns can run into each other. fprintf(f, "%12u", tst->unresponse_flows); v fprintf(f, " %12u", tst->unresponse_flows); The header lines are probably wrong. Should be as per

Re: [Cake] [PATCH] q_cake: Update xstats format to use per-tin structure

2018-03-07 Thread Toke Høiland-Jørgensen
Kevin Darbyshire-Bryant writes: >> On 7 Mar 2018, at 10:31, Toke Høiland-Jørgensen wrote: >> >>> >> >> Please don't put something different into LEDE than what we're working >> on upstreaming. It is difficult enough to keep track of the different

Re: [Cake] [PATCH] q_cake: Update xstats format to use per-tin structure

2018-03-07 Thread Toke Høiland-Jørgensen
Kevin Darbyshire-Bryant writes: > There were some useful stats column re-alignment changes as well, > wonder if you got those? Probably not, as that code is not longer directly diff'able, unfortunately... The json-related changes were fairly intrusive...

Re: [Cake] [PATCH] q_cake: Update xstats format to use per-tin structure

2018-03-07 Thread Sebastian Moeller
Hi Kevin, > On Mar 7, 2018, at 12:07, Kevin Darbyshire-Bryant > wrote: > > > >> On 7 Mar 2018, at 10:31, Toke Høiland-Jørgensen wrote: >> >>> >> >> Please don't put something different into LEDE than what we're working >> on upstreaming. It

Re: [Cake] [PATCH] q_cake: Update xstats format to use per-tin structure

2018-03-07 Thread Kevin Darbyshire-Bryant
There were some useful stats column re-alignment changes as well, wonder if you got those? > On 7 Mar 2018, at 10:36, Toke Høiland-Jørgensen wrote: > > Toke Høiland-Jørgensen writes: > >> Kevin Darbyshire-Bryant writes: >> >>> Hi

Re: [Cake] [PATCH] q_cake: Update xstats format to use per-tin structure

2018-03-07 Thread Kevin Darbyshire-Bryant
> On 7 Mar 2018, at 10:31, Toke Høiland-Jørgensen wrote: > >> > > Please don't put something different into LEDE than what we're working > on upstreaming. It is difficult enough to keep track of the different > versions as they are. The tc-adv repo is already rebased on the

Re: [Cake] [PATCH] q_cake: Update xstats format to use per-tin structure

2018-03-07 Thread Toke Høiland-Jørgensen
Toke Høiland-Jørgensen writes: > Kevin Darbyshire-Bryant writes: > >> Hi All, >> >> >> >>> On 7 Mar 2018, at 08:50, Toke Høiland-Jørgensen wrote: >>> >>> Jonathan Morton writes: >>> > On 6 Mar, 2018, at

Re: [Cake] [PATCH] q_cake: Update xstats format to use per-tin structure

2018-03-07 Thread Toke Høiland-Jørgensen
Kevin Darbyshire-Bryant writes: > Hi All, > > > >> On 7 Mar 2018, at 08:50, Toke Høiland-Jørgensen wrote: >> >> Jonathan Morton writes: >> On 6 Mar, 2018, at 11:06 pm, Toke Høiland-Jørgensen wrote:

Re: [Cake] [PATCH] q_cake: Update xstats format to use per-tin structure

2018-03-07 Thread Kevin Darbyshire-Bryant
Hi All, > On 7 Mar 2018, at 08:50, Toke Høiland-Jørgensen wrote: > > Jonathan Morton writes: > >>> On 6 Mar, 2018, at 11:06 pm, Toke Høiland-Jørgensen wrote: >>> >>> ...on the iproute2 side the only >>> thing missing before we can attempt

Re: [Cake] [PATCH] q_cake: Update xstats format to use per-tin structure

2018-03-07 Thread Toke Høiland-Jørgensen
Jonathan Morton writes: >> On 6 Mar, 2018, at 11:06 pm, Toke Høiland-Jørgensen wrote: >> >> ...on the iproute2 side the only >> thing missing before we can attempt an upstream submission is an update >> of the man page, as far as I can tell. Any volunteers

Re: [Cake] [PATCH] q_cake: Update xstats format to use per-tin structure

2018-03-06 Thread Jonathan Morton
> On 6 Mar, 2018, at 11:06 pm, Toke Høiland-Jørgensen wrote: > > ...on the iproute2 side the only > thing missing before we can attempt an upstream submission is an update > of the man page, as far as I can tell. Any volunteers to do that? :) I could look into that tomorrow. -

Re: [Cake] [PATCH] q_cake: Update xstats format to use per-tin structure

2018-03-06 Thread Toke Høiland-Jørgensen
Toke Høiland-Jørgensen writes: > Stephen Hemminger writes: > >> On Sun, 11 Feb 2018 18:26:18 +0100 >> Toke Høiland-Jørgensen wrote: >> >>> This updates tc to understand the updated cake xstats structure (which >>> splits out the tin stats

Re: [Cake] [PATCH] q_cake: Update xstats format to use per-tin structure

2018-03-06 Thread Toke Høiland-Jørgensen
Stephen Hemminger writes: > On Sun, 11 Feb 2018 18:26:18 +0100 > Toke Høiland-Jørgensen wrote: > >> This updates tc to understand the updated cake xstats structure (which >> splits out the tin stats in a separate structure the length of which is >>

Re: [Cake] [PATCH] q_cake: Update xstats format to use per-tin structure

2018-03-06 Thread Stephen Hemminger
On Sun, 11 Feb 2018 18:26:18 +0100 Toke Høiland-Jørgensen wrote: > This updates tc to understand the updated cake xstats structure (which > splits out the tin stats in a separate structure the length of which is > included in the containing struct). > > Old versions of the cake

Re: [Cake] [PATCH] q_cake: Update xstats format to use per-tin structure

2018-03-06 Thread Sebastian Moeller
Hi Jonathan, > On Mar 6, 2018, at 14:08, Jonathan Morton wrote: > >> On 6 Mar, 2018, at 2:10 pm, Sebastian Moeller wrote: >> >> Question: am I right to assume that the _adj values are what you pass in as >> the true packet size into cake's

Re: [Cake] [PATCH] q_cake: Update xstats format to use per-tin structure

2018-03-06 Thread Jonathan Morton
> On 6 Mar, 2018, at 2:10 pm, Sebastian Moeller wrote: > > Question: am I right to assume that the _adj values are what you pass in as > the true packet size into cake's calculation? Yes, exactly. They include ATM, PTM and MPU factors when relevant. > I believe that before

Re: [Cake] [PATCH] q_cake: Update xstats format to use per-tin structure

2018-03-06 Thread Sebastian Moeller
Hi Jonathan, > On Mar 6, 2018, at 12:46, Jonathan Morton wrote: > >> On 6 Mar, 2018, at 1:17 pm, Toke Høiland-Jørgensen wrote: >> >>> So far it looks like everything is working fine and behaving as it >>> should (on a plain Ethernet interface). The one

Re: [Cake] [PATCH] q_cake: Update xstats format to use per-tin structure

2018-03-06 Thread Jonathan Morton
> On 6 Mar, 2018, at 1:17 pm, Toke Høiland-Jørgensen wrote: > >> So far it looks like everything is working fine and behaving as it >> should (on a plain Ethernet interface). The one wrinkle is that it >> takes a few thousand packets for the avg_off value to converge on the >>

Re: [Cake] [PATCH] q_cake: Update xstats format to use per-tin structure

2018-03-06 Thread Toke Høiland-Jørgensen
Jonathan Morton writes: >> On 1 Mar, 2018, at 1:06 pm, Sebastian Moeller wrote: >> >> BTW, my testing so far with the latest tc-adv did not result in any crashes, >> but I also did not research whether the overhead account behaves like >> expected... >

Re: [Cake] [PATCH] q_cake: Update xstats format to use per-tin structure

2018-03-05 Thread Jonathan Morton
> On 1 Mar, 2018, at 1:06 pm, Sebastian Moeller wrote: > > BTW, my testing so far with the latest tc-adv did not result in any crashes, > but I also did not research whether the overhead account behaves like > expected... I've just added the relevant stats output. This

Re: [Cake] [PATCH] q_cake: Update xstats format to use per-tin structure

2018-03-04 Thread Toke Høiland-Jørgensen
Toke Høiland-Jørgensen writes: > Jonathan Morton writes: > >>> On 11 Feb, 2018, at 7:26 pm, Toke Høiland-Jørgensen wrote: >>> >>> This updates tc to understand the updated cake xstats structure (which >>> splits out the tin stats in a

Re: [Cake] [PATCH] q_cake: Update xstats format to use per-tin structure

2018-03-01 Thread Sebastian Moeller
Dear All, I am a bit confused now which tc repository is the one to track. I believe Jonathan made changes to https://github.com/dtaht/tc-adv while https://github.com/dtaht/iproute2-cake-next seems overall more recent (modulo Jonathan's changes) So which one is it? BTW, my testing so far

Re: [Cake] [PATCH] q_cake: Update xstats format to use per-tin structure

2018-03-01 Thread Jonathan Morton
> On 11 Feb, 2018, at 7:26 pm, Toke Høiland-Jørgensen wrote: > > This updates tc to understand the updated cake xstats structure (which > splits out the tin stats in a separate structure the length of which is > included in the containing struct). > > Old versions of the cake