Re: [Cake] [PATCH net] gso_segment: Reset skb->mac_len after modifying network header

2018-09-13 Thread Toke Høiland-Jørgensen
On 13 September 2018 16:11:18 CEST, Eric Dumazet wrote: > > >On 09/11/2018 03:19 PM, Toke Høiland-Jørgensen wrote: >> When splitting a GSO segment that consists of encapsulated packets, >the >> skb->mac_len of the segments can end up being set wrong, causing >packet >> drops in particular when

Re: [Cake] [PATCH net] gso_segment: Reset skb->mac_len after modifying network header

2018-09-13 Thread Dave Taht
On Thu, Sep 13, 2018 at 7:11 AM Eric Dumazet wrote: > > > > On 09/11/2018 03:19 PM, Toke Høiland-Jørgensen wrote: > > When splitting a GSO segment that consists of encapsulated packets, the > > skb->mac_len of the segments can end up being set wrong, causing packet > > drops in particular when

Re: [Cake] [PATCH net] gso_segment: Reset skb->mac_len after modifying network header

2018-09-13 Thread Eric Dumazet
On 09/11/2018 03:19 PM, Toke Høiland-Jørgensen wrote: > When splitting a GSO segment that consists of encapsulated packets, the > skb->mac_len of the segments can end up being set wrong, causing packet > drops in particular when using act_mirred and ifb interfaces in > combination with a qdisc