Review Request: Support for path-stretchpoint-x and path-stretchpoint-y

2012-05-01 Thread Elvis Stansvik
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104804/ --- Review request for Calligra, Matus Hanzes, Thorsten Zachmann, and C.

Re: Review Request: Support for path-stretchpoint-x and path-stretchpoint-y

2012-05-01 Thread Elvis Stansvik
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104804/ --- (Updated May 1, 2012, 10:35 a.m.) Review request for Calligra, Matus

Re: Review Request: Support for path-stretchpoint-x and path-stretchpoint-y

2012-05-01 Thread Elvis Stansvik
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104804/ --- (Updated May 1, 2012, 10:48 a.m.) Review request for Calligra, Matus

Re: Review Request: Fixes: misspelt icon names, improved icon choices, out-dated/missing icons

2012-05-01 Thread Friedrich W. H. Kossebau
On April 28, 2012, 1:15 p.m., C. Boemann wrote: plugins/textshape/TextTool.cpp, line 419 http://git.reviewboard.kde.org/r/104729/diff/1/?file=58555#file58555line419 well the reason we don't use the real names for merge and spli is because they are not in kde 4.3, which is our

Re: Review Request: Fixes: misspelt icon names, improved icon choices, out-dated/missing icons

2012-05-01 Thread Friedrich W. H. Kossebau
On April 26, 2012, 11:45 a.m., Inge Wallin wrote: * chart_* icon names where oxygen has now office-chart-*, as also used in rest of file. But some chart_* are without any match and without any icon, please comment on that If there is an established standard, then we should

Re: Review Request: Fixes: misspelt icon names, improved icon choices, out-dated/missing icons

2012-05-01 Thread Friedrich W. H. Kossebau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104729/ --- (Updated May 1, 2012, 4:27 p.m.) Review request for Calligra. Changes

Re: Review Request: Fixes: misspelt icon names, improved icon choices, out-dated/missing icons

2012-05-01 Thread Friedrich W. H. Kossebau
On April 28, 2012, 1:15 p.m., C. Boemann wrote: plugins/textshape/TextTool.cpp, line 419 http://git.reviewboard.kde.org/r/104729/diff/1/?file=58555#file58555line419 well the reason we don't use the real names for merge and spli is because they are not in kde 4.3, which is our

Re: Review Request: Fixes: misspelt icon names, improved icon choices, out-dated/missing icons

2012-05-01 Thread C. Boemann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104729/#review13222 --- Ship it! ok let us give it a go, reverts are cheap and this

Re: Review Request: Fixes: misspelt icon names, improved icon choices, out-dated/missing icons

2012-05-01 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104729/#review13224 --- This review has been submitted with commit

Re: Review Request: support other numbering and bullet styles

2012-05-01 Thread C. Boemann
On Feb. 18, 2012, 10 p.m., C. Boemann wrote: Ship It! Inge Wallin wrote: Was this committed? If so, it should be closed. yes it was. Moji please close it as submited. - C. --- This is an automatically generated e-mail. To

Review Request: Fix Bug 284260 - Some text formatting is ignored for text-on-shape

2012-05-01 Thread Gopalakrishna Bhat
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104813/ --- Review request for Calligra. Description --- We used to ignore the

Re: Review Request: Support for path-stretchpoint-x and path-stretchpoint-y

2012-05-01 Thread Thorsten Zachmann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104804/#review13226 --- I will run cstester with the patch to see what changes are

Re: Review Request: Fix Bug 284260 - Some text formatting is ignored for text-on-shape

2012-05-01 Thread Thorsten Zachmann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104813/#review13228 --- As written in the comments the functionality should be moved

Shape shadows

2012-05-01 Thread Inge Wallin
https://bugs.kde.org/show_bug.cgi?id=260535 has the title: kpresenter:openoffice:Shadow of the picture is not getting displayed. I had a look at this, and the reason is the following code in void KoShapeShadow::Private::paintShadow() at line 86 in libs/flake/KoShapeShadow.cpp: if

Re: Review Request: Fixes: Calligra Words reads unit type setting only from ooo:view-settings, not from view-settings

2012-05-01 Thread C. Boemann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104701/#review13254 --- please close this as dismissed I'll make a more elaborate

Review Request: Don't change size of pictureshape after setting a new image

2012-05-01 Thread Sven Langkamp
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104819/ --- Review request for Calligra. Description --- The patch fixes bug

Re: Review Request: Don't change size of pictureshape after setting a new image

2012-05-01 Thread C. Boemann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104819/#review13255 --- Ship it! looks good though it doesn't fix the bug you

Re: Review Request: Don't change size of pictureshape after setting a new image

2012-05-01 Thread Sven Langkamp
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104819/ --- (Updated May 1, 2012, 10:50 p.m.) Review request for Calligra. Changes

Re: Review Request: Don't change size of pictureshape after setting a new image

2012-05-01 Thread C. Boemann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104819/#review13256 --- Ship it! Ship It! - C. Boemann On May 1, 2012, 10:50 p.m.,

Re: Shape shadows

2012-05-01 Thread Thorsten Zachmann
On Wednesday, May 02, 2012 12:16:34 AM Inge Wallin wrote: https://bugs.kde.org/show_bug.cgi?id=260535 has the title: kpresenter:openoffice:Shadow of the picture is not getting displayed. I had a look at this, and the reason is the following code in void