danders added a reviewer: leinir.
REPOSITORY
R8 Calligra
REVISION DETAIL
https://phabricator.kde.org/D15102
To: dcaliste, #calligra:_3.0, leinir
Cc: Calligra-Devel-list, cochise, vandenoever
boemann added a comment.
The problem here is if they think they can place a line on a specific pixel
position - we don't store coords as pixels - so it will not end being rendered
to a specific pixel anyway - we will just end up with users not getting what
they think they get, even in such
anthonyfieroni added a comment.
I agree with that, but in some situations like targeting embedded device with
especially knowing resolution :) I really don't know what can they'll see in
pixels, but defined resolution is possible case.
REPOSITORY
R8 Calligra
REVISION DETAIL
boemann added a comment.
Yes, that is exactly how they could use it but, I think we are doing a
disservice by offering such an option- there is no way an author can know the
destination resolution and it will only apply to one destination.
Besides why would they even need to know - we
anthonyfieroni added a comment.
That's purely abstract, i think to add DPI spinbox next to pixel setting. I'm
not a designer, but it looks like they want to work on *real* pixels that
should look on the target device, that's maybe DPI config will be relevant.
REPOSITORY
R8 Calligra
boemann added a comment.
What is the purpose of showing pixel units in general - pixels is not really
a unit except in very specific cases - I'd saythis is very very wrong
What is the size of pixel in your mind anyway?
REPOSITORY
R8 Calligra
REVISION DETAIL
anthonyfieroni updated this revision to Diff 40536.
anthonyfieroni added a comment.
Fix Tests as well.
Notable change is that i made to always use round functions toXXX, do we need
precision as offer qreal ?
REPOSITORY
R8 Calligra
CHANGES SINCE LAST UPDATE
danders accepted this revision.
danders added a comment.
This revision is now accepted and ready to land.
Haven't tested, but sounds sane :)
REPOSITORY
R8 Calligra
REVISION DETAIL
https://phabricator.kde.org/D15056
To: anthonyfieroni, #calligra:_3.0, danders, boemann
Cc:
