Re: Bumping qt version

2019-01-15 Thread Jaroslaw Staniek
On Tue, 15 Jan 2019 at 21:13, Adam Pigg wrote: > Sailfish will shortly (tm) be upgrading to 5.9 so that wont block for > much longer i hope. My understanding is they are working out the > legal issues around the license changes ... technically the port is > ready. I dont really understand the

Re: Bumping qt version

2019-01-15 Thread Adam Pigg
Sailfish will shortly (tm) be upgrading to 5.9 so that wont block for much longer i hope. My understanding is they are working out the legal issues around the license changes ... technically the port is ready. I dont really understand the issue myself! On Tue, 15 Jan 2019 at 12:01, René J.V.

Re: Bumping qt version

2019-01-15 Thread René J . V . Bertin
On Tuesday January 15 2019 12:53:03 Jaroslaw Staniek wrote: > If there's no reason to force upgrade, I would not. Also (guess what) LTS > distros seem refuse to upgrade without users doing extra steps. Amen to that! I'm very annoyed by the fact that KF5 Frameworks just moved to Qt 5.10, for no

Re: Bumping qt version

2019-01-15 Thread Jaroslaw Staniek
On Tue, 15 Jan 2019 at 12:44, wrote: > Any reason not to require qt 5.9? > We are at 5.3 atm. > Not strictly related to calligra.git but similar case for KEXI/KEXI frameworks: it is caused by Sailfish depending on such older Qt. If there's no reason to force upgrade, I would not. Also (guess

Bumping qt version

2019-01-15 Thread danders
Any reason not to require qt 5.9? We are at 5.3 atm.

D18095: Add new table layout unit tests

2019-01-15 Thread Dag Andersen
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R8:666ae5b484cc: Add new table layout unit tests (authored by danders). REPOSITORY R8 Calligra CHANGES SINCE LAST

D18095: Add new table layout unit tests

2019-01-15 Thread Camilla Boemann
boemann added a comment. absolutely REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D18095 To: danders, boemann, anthonyfieroni Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever

D18095: Add new table layout unit tests

2019-01-15 Thread Dag Andersen
danders added a comment. Even if they do not all pass, I think they should be commited if the tests/methods are ok and the reason for not passing are genuin bugs, no? REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D18095 To: danders, boemann, anthonyfieroni Cc: