niccolove added a comment.
I tried differents files (locale and remote, opening and printing), and
everything works okay. Other applications work normally, but calligrasheets
still crashes when trying to print a remote (odt) file - but I can see the file
is downloaded correctly, so it looks
boemann added a comment.
Please check with loading a normal document,. The same concerns now applies
to slotLoadCompleted - especially since you have now removed functionality from
it.
Also please check in all of our applications as some might reimplement
virtual methods
REPOSITORY
niccolove added a comment.
I've seen that openDoumentInternal is called every time a remote document is
used as input. I'm not sure if it's also used in different scenarios.
REPOSITORY
R8 Calligra
REVISION DETAIL
https://phabricator.kde.org/D18466
To: niccolove, danders
Cc: boemann,
boemann added a reviewer: danders.
REPOSITORY
R8 Calligra
REVISION DETAIL
https://phabricator.kde.org/D18466
To: niccolove, danders
Cc: boemann, Calligra-Devel-list, dcaliste, cochise, vandenoever
niccolove updated this revision to Diff 50100.
niccolove added a comment.
- Moving the if from slotLoadCompleted to openDocumentInternal.
REPOSITORY
R8 Calligra
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D18466?vs=50098=50100
BRANCH
print-remote-files (branched from master)
boemann added a comment.
Yes that description helped a lot, and you are doing great. Keep up the good
work :)
One concern though - how often and when is openDoumentInternal called. I'm a
bit afraid that we just add some functionality to a place that might be used
for something else
niccolove added a comment.
At this point my only worry is that the setRootDocument in
openDocumentInternal makes the check for opening a new window in
slotLoadCompleted useless. Moving the whole if statement from slotLoadCompleted
to openDocumentInternal also works, and could avoid to
niccolove added a comment.
Sure.
Calligra was crashing because the method "slotFilePrint" called "rootView()"
that tried to return the first elements of "d->rootViews". The problem is that
such list was empitya, as SetRootDocument was never called: that method is
called in openDocument
boemann added a comment.
Could you please describe what you have done and why
REPOSITORY
R8 Calligra
REVISION DETAIL
https://phabricator.kde.org/D18466
To: niccolove
Cc: boemann, Calligra-Devel-list, dcaliste, cochise, vandenoever
niccolove edited the test plan for this revision.
REPOSITORY
R8 Calligra
REVISION DETAIL
https://phabricator.kde.org/D18466
To: niccolove
Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever
niccolove updated this revision to Diff 50098.
niccolove added a comment.
- Fixed typos
REPOSITORY
R8 Calligra
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D18466?vs=50097=50098
BRANCH
print-remote-files (branched from master)
REVISION DETAIL
niccolove created this revision.
Herald added a project: Calligra: 3.0.
Herald added a subscriber: Calligra-Devel-list.
niccolove requested review of this revision.
REVISION SUMMARY
BUG:358581
REPOSITORY
R8 Calligra
BRANCH
print-remote-files (branched from master)
REVISION DETAIL
12 matches
Mail list logo
