Re: Proposed release calendar

Le dimanche, mars 21, 2021 10:42 PM, Pierre a écrit : > Hi everyone > > I was looking at our current changelog in master, and while we don't have much > to show regarding new features, several stability fixes were added, and the Qt > 5.15 compatibility may come in handy for distributors. > Since

Re: Minimum dependency versions

‐‐‐ Original Message ‐‐‐ Le jeudi, février 11, 2021 10:50 AM, Dan Leinir Turthra Jensen a écrit : > On Wednesday, 10 February 2021 22:48:53 GMT Pierre wrote: > > > On Wednesday, February 10, 2021 8:45:23 PM CET Camilla Boemann wrote: > > > > > I agree let's move ahead. We can't be

Re: Minimum dependency versions

‐‐‐ Original Message ‐‐‐ Le mercredi, février 10, 2021 11:48 PM, Pierre a écrit : > On Wednesday, February 10, 2021 8:45:23 PM CET Camilla Boemann wrote: > > > I agree let's move ahead. We can't be defined by what Jolla does and needs > > However let's only do it if development is going

Re: Minimum dependency versions

Le mercredi, février 10, 2021 7:45 PM, Pierre a écrit : > On Wednesday, February 10, 2021 9:30:43 AM CET Adam Pigg wrote: > > > I wish!!! ... try qt 5.6! > > On Wed, 10 Feb 2021 at 08:14, Halla Rempt b...@valdyas.org wrote: > > > > > On Wednesday, 10 February 2021 08:44:54 CET Pierre wrote: > >

D25714: [WIP]: Port away from deprecated KHtml

ognarb abandoned this revision. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D25714 To: ognarb, #calligra:_3.0 Cc: anthonyfieroni, danders, leinir, Calligra-Devel-list, blu-base, davidllewellynjones, dcaliste, ognarb, cochise, vandenoever

D29242: WIP: redesign sidebar

ognarb updated this revision to Diff 81490. ognarb added a comment. - More work in progress change TODO - don't make KoModeBox public - Implement add shapes action - Figure out how to draw line seperator - Fix some issues found when applying the Breeze ToolArea patch

D29242: WIP: redesign sidebar

ognarb planned changes to this revision. ognarb added a comment. In D29242#658883 , @boemann wrote: > Well you are definitely in the right class to make such changes. > > The thing is the current code was made to adopt to many different user

D29242: WIP: redesign sidebar

ognarb added a comment. There is a mockup here: T12837 this is really WIP I just created the diff because I asked someone to help me with a part of the code and I needed to show them the code. REPOSITORY R8 Calligra REVISION DETAIL

D29242: WIP: redesign sidebar

ognarb created this revision. Herald added a project: Calligra: 3.0. Herald added a subscriber: Calligra-Devel-list. ognarb requested review of this revision. REPOSITORY R8 Calligra BRANCH redesign REVISION DETAIL https://phabricator.kde.org/D29242 AFFECTED FILES

T12815: Create Calligra Framework by separating out applications and libraries

ognarb added a comment. +1 on the general idea Some remarks: - Do we want to have an abi and api stability in the Calligra frameworks? or do we prefer to do it like in PIM and only guaranty that all the package from a certain version are compatible? I think the second option is

D26221: Use QQC2 Dialog

ognarb edited the test plan for this revision. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D26221 To: ognarb, #calligra:_3.0, leinir Cc: danders, Calligra-Devel-list, davidllewellynjones, dcaliste, ognarb, cochise, vandenoever

D26221: Use QQC2 Dialog

This revision was automatically updated to reflect the committed changes. Closed by commit R8:d6cdb21118b2: Use QQC2 Dialog (authored by ognarb). REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26221?vs=72240=77299 REVISION DETAIL

Re: New website

h a normal sysadmin request. Cheers, Carl > --- > > Cheers, > > Dag > > Carl Schwan skrev den 2020-03-02 16:42: > > > Hello, > > the website progressed a lot during Season of KDE and it was completly > > updated. Thanks a lot to Anuj Bansal for his wo

Re: New website

plan will be to deploy the website before the end of this month, so that it can appear on my second monthly KDE web news :-) Cheers, Carl Schwan https://carlschwan.eu KDE Web developer ‐‐‐ Original Message ‐‐‐ Le mardi, janvier 7, 2020 9:53 PM, Carl Schwan a écrit : > Hi, >

New website

Hi, I already spoke a bit about it with Leinir, but I will mentor a Season of KDE project about updating the Calligra website. The idea of updating the Calligra website was really popular and I received more than 10 proposals for the website. I choose Anuj Bansal since he already contributed

D26221: Use QQC2 Dialog

ognarb marked an inline comment as done. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D26221 To: ognarb, #calligra:_3.0, leinir Cc: Calligra-Devel-list, davidllewellynjones, dcaliste, ognarb, cochise, vandenoever

D26221: Use QQC2 Dialog

ognarb updated this revision to Diff 72240. ognarb added a comment. - Center the loading animation REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26221?vs=72174=72240 BRANCH gemini-dialog REVISION DETAIL https://phabricator.kde.org/D26221 AFFECTED

D26050: Fix build with poppler 82

ognarb added a comment. In D26050#583223 , @leinir wrote: > In D26050#583007 , @ognarb wrote: > > > In D26050#582981 , @asturmlechner wrote: > > > > >

D26050: Fix build with poppler 82

ognarb added a comment. In D26050#582981 , @asturmlechner wrote: > In D26050#578862 , @anthonyfieroni wrote: > > > Maybe we can drop 62, but not 72. > > > If this is for master I don't see

D26221: Use QQC2 Dialog

ognarb edited the test plan for this revision. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D26221 To: ognarb, #calligra:_3.0, leinir Cc: Calligra-Devel-list, davidllewellynjones, dcaliste, ognarb, cochise, vandenoever

D26221: Use QQC2 Dialog

ognarb updated this revision to Diff 72174. ognarb added a comment. Update look REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26221?vs=72173=72174 BRANCH gemini-dialog REVISION DETAIL https://phabricator.kde.org/D26221 AFFECTED FILES

D26221: Use QQC2 Dialog

ognarb added reviewers: Calligra: 3.0, leinir. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D26221 To: ognarb, #calligra:_3.0, leinir Cc: Calligra-Devel-list, davidllewellynjones, dcaliste, ognarb, cochise, vandenoever

D26221: Use QQC2 Dialog

ognarb created this revision. Herald added a project: Calligra: 3.0. Herald added a subscriber: Calligra-Devel-list. ognarb requested review of this revision. REVISION SUMMARY Replace custom dialog with QQC2 Dialog TEST PLAN Screenshot comming REPOSITORY R8 Calligra BRANCH

D26050: Fix build with poppler 82

ognarb added a comment. Doesn't compile for me with Poppler 81. So I created a small patch on top of your patch F7835712: poppler-81.patch REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D26050 To: tcanabrava,

D25714: [WIP]: Port away from deprecated KHtml

ognarb retitled this revision from "Port away from deprecated KHtml" to "[WIP]: Port away from deprecated KHtml". REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D25714 To: ognarb, #calligra:_3.0 Cc: leinir, Calligra-Devel-list, davidllewellynjones, dcaliste, ognarb,

Qt version and new website

yll theme (https://invent.kde.org/websites/jekyll-kde-theme). So that we have a website looking like kontact.kde.org and cantor.kde.org. Cheers, Carl Schwan https://carlschwan.eu publickey - carl@carlschwan.eu - 0x7F564CB5.asc Description: application/pgp-keys signature.asc Description: Open

D25714: Port away from deprecated KHtml

ognarb added a reviewer: Calligra: 3.0. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D25714 To: ognarb, #calligra:_3.0 Cc: Calligra-Devel-list, davidllewellynjones, dcaliste, ognarb, cochise, vandenoever

D25714: Port away from deprecated KHtml

ognarb edited the summary of this revision. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D25714 To: ognarb Cc: Calligra-Devel-list, davidllewellynjones, dcaliste, ognarb, cochise, vandenoever

D25714: Port away from deprecated KHtml

ognarb added a task: T11542: Remove KHTML. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D25714 To: ognarb Cc: Calligra-Devel-list, davidllewellynjones, dcaliste, ognarb, cochise, vandenoever

D25714: Port away from deprecated KHtml

ognarb created this revision. Herald added a project: Calligra: 3.0. Herald added a subscriber: Calligra-Devel-list. ognarb requested review of this revision. TEST PLAN Compile, but I need to figure out why before and after this change the filter doesn't work. REPOSITORY R8 Calligra BRANCH

D25664: [WIP]: Port away from deprecated QSignalMapper

This revision was automatically updated to reflect the committed changes. Closed by commit R8:e29dc97256de: [WIP]: Port away from deprecated QSignalMapper (authored by ognarb). REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25664?vs=70790=70818 REVISION

D25664: [WIP]: Port away from deprecated QSignalMapper

ognarb marked 3 inline comments as done. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D25664 To: ognarb, #calligra:_3.0, #kf6, dfaure Cc: danders, dfaure, Calligra-Devel-list, davidllewellynjones, dcaliste, ognarb, cochise, vandenoever

D25664: [WIP]: Port away from deprecated QSignalMapper

ognarb updated this revision to Diff 70790. ognarb added a comment. Finish porting away from QSignalMapper REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25664?vs=70755=70790 BRANCH arcpatch-D25664 REVISION DETAIL https://phabricator.kde.org/D25664

D25664: [WIP]: Port away from deprecated QSignalMapper

ognarb added a comment. Ok I will replace the qAsConst with koAsConst ;) I suppose the reason why Calligra needs Qt5.3 is the Qt Quick 1 support? REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D25664 To: ognarb, #calligra:_3.0, #kf6, dfaure Cc: danders, dfaure,

D25664: [WIP]: Port away from deprecated QSignalMapper

ognarb planned changes to this revision. ognarb added a comment. Planned changes: Port all the QSignalMapper ;) REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D25664 To: ognarb, #calligra:_3.0, #kf6, dfaure Cc: dfaure, Calligra-Devel-list, davidllewellynjones,

D25664: [WIP]: Port away from deprecated QSignalMapper

ognarb updated this revision to Diff 70755. ognarb marked 7 inline comments as done. ognarb added a comment. Thanks for the review David. I will now follow your advice and continue porting away from QSignalMapper. REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE

D25664: [WIP]: Port away from deprecated QSignalMapper

ognarb retitled this revision from "[WIP]: Port away from QSignalMapper" to "[WIP]: Port away from deprecated QSignalMapper". ognarb edited the summary of this revision. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D25664 To: ognarb, #calligra:_3.0, #kf6 Cc:

D25664: [WIP]: Port away from QSignalMapper

ognarb edited the summary of this revision. ognarb edited the test plan for this revision. ognarb added reviewers: Calligra: 3.0, KF6. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D25664 To: ognarb, #calligra:_3.0, #kf6 Cc: Calligra-Devel-list, davidllewellynjones,

D25560: refactor: Run clang-tity modernize override

ognarb added a reviewer: Calligra: 3.0. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D25560 To: ognarb, #calligra:_3.0 Cc: Calligra-Devel-list, davidllewellynjones, dcaliste, ognarb, cochise, vandenoever

D25560: refactor: Run clang-tity modernize override

ognarb created this revision. Herald added a project: Calligra: 3.0. Herald added a subscriber: Calligra-Devel-list. ognarb requested review of this revision. REVISION SUMMARY - Reduce significantly the number of warnings during compilation - Only manual intervention was in

D25481: Port from qSort to std::sort

ognarb added a comment. Thanks for the review :) REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D25481 To: ognarb, #calligra:_3.0, dfaure Cc: Calligra-Devel-list, davidllewellynjones, dcaliste, ognarb, cochise, vandenoever

D25481: Port from qSort to std::sort

This revision was automatically updated to reflect the committed changes. Closed by commit R8:dd2b51a717f9: Port from qSort to std::sort (authored by ognarb). REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25481?vs=70192=70386 REVISION DETAIL

D25481: Port from qSort to std::sort

ognarb added a reviewer: Calligra: 3.0. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D25481 To: ognarb, #calligra:_3.0 Cc: Calligra-Devel-list, davidllewellynjones, dcaliste, ognarb, cochise, vandenoever

D19132: Update libs/widgets to c++11

This revision was automatically updated to reflect the committed changes. Closed by commit R8:c32f7ef9bbbf: Update libs/widgets to c++11 (authored by ognarb). REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19132?vs=52121=52341 REVISION DETAIL

D19132: Update libs/widgets to c++11

ognarb added a comment. In D19132#416519 , @danders wrote: > Ok, I can't say I have scrutinized every change, but... > Could you give a heads up when you continue with other parts or else there may be merge problems. > I'm working on

D19132: Update libs/widgets to c++11

ognarb updated this revision to Diff 52121. ognarb added a comment. Fix build REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19132?vs=52119=52121 BRANCH master REVISION DETAIL https://phabricator.kde.org/D19132 AFFECTED FILES CMakeLists.txt

D19132: Update libs/widgets to c++11

ognarb edited the summary of this revision. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D19132 To: ognarb, #calligra:_3.0, leinir Cc: danders, Calligra-Devel-list, dcaliste, cochise, vandenoever

D19132: Update libs/widgets to c++11

ognarb updated this revision to Diff 52119. ognarb added a comment. - Revert foreach modifications - Fix some forgotten 0 as nullptr instances REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19132?vs=52008=52119 BRANCH master REVISION DETAIL

D19132: Update libs/widgets to c++11

ognarb edited the summary of this revision. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D19132 To: ognarb, #calligra:_3.0 Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever

D19132: Update libs/widgets to c++11

ognarb added a reviewer: Calligra: 3.0. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D19132 To: ognarb, #calligra:_3.0 Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever

D19132: Update libs/widgets to c++11

ognarb created this revision. Herald added a project: Calligra: 3.0. Herald added a subscriber: Calligra-Devel-list. ognarb requested review of this revision. REVISION SUMMARY Use clang-tidy to: - Use default wenn possible for constructor and destructor - Use nullptr instead of 0 or NULL

D18994: Update screenshots for Calligra sheets 3.1

This revision was automatically updated to reflect the committed changes. Closed by commit R8:8c076253c674: Update screenshots for Calligra sheets 3.1 (authored by ognarb). REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18994?vs=51639=51707 REVISION DETAIL

D18994: Update screenshots for Calligra sheets 3.1

ognarb added a comment. In D18994#412049 , @leinir wrote: > A quick note that you kind of got the name of the suite wrong in a few places, it's called Calligra, not Callibra :) Sorry, I think I mixed up calligra and calibre. :)

D18994: Update screenshots for Callibra sheets 3.1

ognarb retitled this revision from "Update screenshots for Callibra 3.1" to "Update screenshots for Callibra sheets 3.1". ognarb edited the summary of this revision. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D18994 To: ognarb, #calligra:_3.0, #documentation Cc:

D18994: Update screenshots for Callibra 3.1

ognarb edited the test plan for this revision. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D18994 To: ognarb, #calligra:_3.0, #documentation Cc: Calligra-Devel-list, kde-doc-english, gennad, dcaliste, skadinna, cochise, vandenoever

D18994: Update screenshots for Callibra 3.1

ognarb updated this revision to Diff 51639. ognarb added a comment. Now compile with checkXML5 REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18994?vs=51638=51639 BRANCH master REVISION DETAIL https://phabricator.kde.org/D18994 AFFECTED FILES

D18994: Update screenshots for Callibra 3.1

ognarb added reviewers: Calligra: 3.0, Documentation. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D18994 To: ognarb, #calligra:_3.0, #documentation Cc: Calligra-Devel-list, kde-doc-english, gennad, dcaliste, skadinna, cochise, vandenoever

D18989: Remove minor duplicate code and fix related bug

This revision was automatically updated to reflect the committed changes. Closed by commit R8:791535d78da5: Remove minor duplicate code and fix related bug (authored by ognarb). REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18989?vs=51624=51627 REVISION

D18989: Remove minor duplicate code and fix related bug

ognarb added a reviewer: Calligra: 3.0. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D18989 To: ognarb, #calligra:_3.0 Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever

D18989: Remove minor duplicate code and fix related bug

ognarb created this revision. Herald added a project: Calligra: 3.0. Herald added a subscriber: Calligra-Devel-list. ognarb requested review of this revision. REVISION SUMMARY I forgot to change the icon size at one place in the last commit. Fix it and use a small function to avoid duplicate

D18963: Improve KoModeBox display in horizontal Mode

ognarb edited the test plan for this revision. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D18963 To: ognarb, #calligra:_3.0, #vdg, boemann Cc: danders, boemann, anthonyfieroni, abetts, ngraham, Calligra-Devel-list, dcaliste, cochise, vandenoever

D18963: Improve KoModeBox display in horizontal Mode

This revision was automatically updated to reflect the committed changes. Closed by commit R8:ede08705548e: Improve KoModeBox display in horizontal Mode (authored by ognarb). REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18963?vs=51594=51596 REVISION DETAIL

D18963: Improve KoModeBox display in horizontal Mode

ognarb updated this revision to Diff 51594. ognarb added a comment. remove more trailing whitespace REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18963?vs=51589=51594 BRANCH master REVISION DETAIL https://phabricator.kde.org/D18963 AFFECTED FILES

D18963: Improve KoModeBox display in horizontal Mode

ognarb updated this revision to Diff 51589. ognarb added a comment. remove trailing whitespace REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18963?vs=51523=51589 BRANCH master REVISION DETAIL https://phabricator.kde.org/D18963 AFFECTED FILES

D18963: Improve KoModeBox display in horizontal Mode

ognarb added a comment. Ok thanks for the review, I will retry to compile calligra master and see if it's still work and then land this diff.  REPOSITORY R8 Calligra BRANCH calligra/3.1 REVISION DETAIL https://phabricator.kde.org/D18963 To: ognarb, #calligra:_3.0, #vdg, boemann Cc:

D18963: Improve KoModeBox display in horizontal Mode

ognarb updated this revision to Diff 51523. ognarb added a comment. Remove debug output REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18963?vs=51522=51523 BRANCH calligra/3.1 REVISION DETAIL https://phabricator.kde.org/D18963 AFFECTED FILES

D18963: Improve KoModeBox display in horizontal Mode

ognarb edited the summary of this revision. ognarb added reviewers: Calligra: 3.0, VDG. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D18963 To: ognarb, #calligra:_3.0, #vdg Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever

D18963: Improve KoModeBox display in horizontal Mode

ognarb created this revision. Herald added a project: Calligra: 3.0. Herald added a subscriber: Calligra-Devel-list. ognarb requested review of this revision. REVISION SUMMARY Use less vertical space, don't change anything in vertical Mode TEST PLAN Compile, run, no bug found yet :D.

D16784: Remove whitespace created by D16721

ognarb edited the summary of this revision. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D16784 To: ognarb, anthonyfieroni Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever

D16784: Remove whitespace created by D16721

ognarb created this revision. ognarb added a reviewer: anthonyfieroni. Herald added a project: Calligra: 3.0. Herald added a subscriber: Calligra-Devel-list. ognarb requested review of this revision. REVISION SUMMARY :( REPOSITORY R8 Calligra BRANCH master REVISION DETAIL

D16721: Use Krita toolbar in Karbon

This revision was automatically updated to reflect the committed changes. Closed by commit R8:a7ee6f871af2: Use Krita toolbar in Karbon (authored by ognarb). REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16721?vs=45181=45182 REVISION DETAIL

D16721: Use Krita toolbar in Karbon

ognarb updated this revision to Diff 45181. ognarb marked an inline comment as done. ognarb added a comment. Remove all whitespace REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16721?vs=45173=45181 BRANCH master REVISION DETAIL

D16721: Use Krita toolbar in Karbon

ognarb removed a reviewer: Krita. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D16721 To: ognarb, #calligra:_3.0, #krita Cc: anthonyfieroni, Calligra-Devel-list, dcaliste, cochise, vandenoever

D16721: Use Krita toolbar in Karbon

ognarb added a comment. In D16721#356755 , @anthonyfieroni wrote: > Can you add screenshots of horizontal and vertical version, add it to test, just to have how it looks. I see some gestures that i cannot test, did you can, touchscreen, tablet

D16721: Use Krita toolbar in Karbon

ognarb updated this revision to Diff 45173. ognarb marked 5 inline comments as done. ognarb added a comment. Fix REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16721?vs=45169=45173 BRANCH master REVISION DETAIL https://phabricator.kde.org/D16721

D16721: Use Krita toolbar in Karbon

ognarb added a comment. In D16721#356595 , @anthonyfieroni wrote: > Can you test my suggestions, it's looks good to me. Yes work also for me :) About the title bar for the dock, I'm not a fan of KoDockWidgetTitleBar for the tool

D16721: Use Krita toolbar in Karbon

ognarb updated this revision to Diff 45169. ognarb marked 9 inline comments as done. ognarb added a comment. Apply change according to review REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16721?vs=45113=45169 BRANCH master REVISION DETAIL

D16721: Use Krita toolbar in Karbon

ognarb added a comment. In D16721#356162 , @anthonyfieroni wrote: > Config, if it's not set explicitly, + "rc" https://api.kde.org/frameworks/kconfig/html/kconfig_8cpp_source.html#l00607 So I propose I add in a later diff the same

D16721: Use Krita toolbar in Karbon

ognarb marked 2 inline comments as done. ognarb added a comment. About the config for the KoKineticScroller. Do you perhaps know where to find the .kcfg file from calligra? REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D16721 To: ognarb, #krita, #calligra:_3.0 Cc:

D16721: Use Krita toolbar in Karbon

ognarb marked 3 inline comments as done. ognarb added a comment. In D16721#355600 , @anthonyfieroni wrote: > Return QObjects, if you have problems copy linker output here. `make clean` solved the issue INLINE COMMENTS > anthonyfieroni

D16721: Use Krita toolbar in Karbon

ognarb updated this revision to Diff 45085. ognarb added a comment. Removing useless arg REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16721?vs=45082=45085 BRANCH master REVISION DETAIL https://phabricator.kde.org/D16721 AFFECTED FILES

D16721: Use Krita toolbar in Karbon

ognarb updated this revision to Diff 45082. ognarb marked 8 inline comments as done. ognarb added a comment. Remove bad code REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16721?vs=45031=45082 BRANCH master REVISION DETAIL

D16721: Use Krita toolbar in Karbon

ognarb updated this revision to Diff 45031. ognarb marked 3 inline comments as done. ognarb added a comment. Fix some indentation problem REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16721?vs=45021=45031 BRANCH master REVISION DETAIL

D16721: Use Krita toolbar in Karbon

ognarb updated this revision to Diff 45021. ognarb added a comment. Revert more change REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16721?vs=45020=45021 BRANCH master REVISION DETAIL https://phabricator.kde.org/D16721 AFFECTED FILES

D16721: Use Krita toolbar in Karbon

ognarb updated this revision to Diff 45020. ognarb added a comment. Revert foreach and remove whitespace REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16721?vs=45018=45020 BRANCH master REVISION DETAIL https://phabricator.kde.org/D16721 AFFECTED

D16721: Use Krita toolbar in Karbon

ognarb updated this revision to Diff 45018. ognarb added a comment. Rever foreach REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16721?vs=45016=45018 BRANCH master REVISION DETAIL https://phabricator.kde.org/D16721 AFFECTED FILES

D16721: Use Krita toolbar in Karbon

ognarb updated this revision to Diff 45016. ognarb marked an inline comment as done. ognarb added a comment. Revert some change more to come REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16721?vs=44995=45016 BRANCH master REVISION DETAIL

D16721: Use Krita toolbar in Karbon

ognarb edited the summary of this revision. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D16721 To: ognarb, #krita, #calligra:_3.0 Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever

D16721: Use Krita toolbar in Karbon

ognarb edited the summary of this revision. ognarb added reviewers: Krita, Calligra: 3.0. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D16721 To: ognarb, #krita, #calligra:_3.0 Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever

D16721: Use Krita toolbar in Karbon

ognarb created this revision. Herald added a project: Calligra: 3.0. Herald added a subscriber: Calligra-Devel-list. ognarb requested review of this revision. REVISION SUMMARY I copied all KoToolBox* file and KissKineticScroller (renamed to KoKineticScroller) from Krita repo. TEST PLAN