Re: Review Request: Possible fix for 294601 - Stretching the toolbox in width makes some tools unusable/ clickable and other issues with the toolbox layouting

2012-03-30 Thread Friedrich W. H. Kossebau
. --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104432/#review11996 --- On March 28, 2012, 1:24 p.m., Friedrich W. H. Kossebau wrote

Re: Review Request: Align toolbox behaviour in all Calligra programs (or: enable single column of buttons in Stage/Flow/Sheets)

2012-03-30 Thread Friedrich W. H. Kossebau
on one row). This really puzzles me. https://bugs.kde.org/show_bug.cgi?id=294601 Friedrich W. H. Kossebau wrote: Right, all programs can now have the toolbox with a single column of tool icons/buttons. Thus shipping now, thanks for review :) Will give that bug a short look

Re: Review Request: New shape for 1-D and 2-D barcodes

2012-03-28 Thread Friedrich W. H. Kossebau
., Friedrich W. H. Kossebau wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104235/ --- (Updated March 12, 2012, 5:42 p.m

Re: Review Request: Align toolbox behaviour in all Calligra programs (or: enable single column of buttons in Stage/Flow/Sheets)

2012-03-28 Thread Friedrich W. H. Kossebau
p.m., Friedrich W. H. Kossebau wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104426/ --- (Updated March 27, 2012, 12:20 p.m

Review Request: Possible fix for 294601 - Stretching the toolbox in width makes some tools unusable/ clickable and other issues with the toolbox layouting

2012-03-28 Thread Friedrich W. H. Kossebau
: http://git.reviewboard.kde.org/r/104432/diff/ Testing --- Thanks, Friedrich W. H. Kossebau ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Review Request: Align toolbox behaviour in all Calligra programs (or: enable single column of buttons in Stage/Flow/Sheets)

2012-03-27 Thread Friedrich W. H. Kossebau
in Stage, Flow, Sheets, Krita and Karbon, by resizing it, moving to other places and using tools. Thanks, Friedrich W. H. Kossebau ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request: Right-align labels on paragraph/character dialogs

2012-03-26 Thread Friedrich W. H. Kossebau
. --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104408/#review11863 --- On March 25, 2012, 11:16 p.m., Friedrich W. H. Kossebau wrote

Review Request: Fix wrongly always present dot behind bullet in preview of the Paragraph dialog

2012-03-26 Thread Friedrich W. H. Kossebau
/diff/ Testing --- Tried various bullet settings, no problem seen. Thanks, Friedrich W. H. Kossebau ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request: Fix wrongly always present dot behind bullet in preview of the Paragraph dialog

2012-03-26 Thread Friedrich W. H. Kossebau
generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104411/#review11866 --- On March 26, 2012, 6:52 a.m., Friedrich W. H. Kossebau wrote: --- This is an automatically

Review Request: right-align all labels in the document info dialog

2012-03-26 Thread Friedrich W. H. Kossebau
- libs/main/koDocumentInfoAboutWidget.ui d5a6ba7 libs/main/koDocumentInfoAuthorWidget.ui ef9cf57 Diff: http://git.reviewboard.kde.org/r/104416/diff/ Testing --- Thanks, Friedrich W. H. Kossebau ___ calligra-devel mailing list calligra-devel

[DONE] Re: Disabling Marble map shape for 2.4?

2012-03-25 Thread Friedrich W. H. Kossebau
Am Sonntag, 25. März 2012, 10:49:10 schrieb Cyrille Berger Skott: On Sunday 18 Mar 2012, Friedrich W. H. Kossebau wrote: Am Samstag, 17. März 2012, 23:20:38 schrieb Jaroslaw Staniek: Ok for disabling shapes but I'd like to keep marble for kexi reports and forms. Sure, only tested

Review Request: Right-align labels on paragraph/character dialogs

2012-03-25 Thread Friedrich W. H. Kossebau
, Friedrich W. H. Kossebau ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Review Request: remove wide left margin from KoModeBox

2012-03-25 Thread Friedrich W. H. Kossebau
the attached file, e.g. view in gwenview using the arrow keys to see the difference. Okay to forward port to master? Diffs - libs/main/KoModeBox.cpp 281a768 Diff: http://git.reviewboard.kde.org/r/104409/diff/ Testing --- Used a little bit. Thanks, Friedrich W. H. Kossebau

Review Request: have KoConnectionShapeConfigWidget use QFormLayout instead of QGridLayout

2012-03-25 Thread Friedrich W. H. Kossebau
the gap between Type: and the combo box. Also removes useless title Ellipse Shape in ui file. Okay to forward port to master? Diffs - libs/flake/KoConnectionShapeConfigWidget.ui 4f5e551 Diff: http://git.reviewboard.kde.org/r/104410/diff/ Testing --- Thanks, Friedrich W. H. Kossebau

Re: Review Request: remove wide left margin from KoModeBox

2012-03-25 Thread Friedrich W. H. Kossebau
. --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104409/#review11849 --- On March 25, 2012, 11:26 p.m., Friedrich W. H. Kossebau wrote

Re: Review Request: remove wide left margin from KoModeBox

2012-03-25 Thread Friedrich W. H. Kossebau
. --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104409/#review11851 --- On March 25, 2012, 11:26 p.m., Friedrich W. H. Kossebau wrote

Re: Review Request: remove wide left margin from KoModeBox

2012-03-25 Thread Friedrich W. H. Kossebau
://git.reviewboard.kde.org/r/104409/#review11857 --- On March 25, 2012, 11:26 p.m., Friedrich W. H. Kossebau wrote: --- This is an automatically generated e-mail. To reply, visit: http

Re: Review Request: Improve the layout of KoPageLayoutWidget and KWDocumentColumns, also add margins to print option pages

2012-03-23 Thread Friedrich W. H. Kossebau
. --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104370/#review11775 --- On March 22, 2012, 11:42 p.m., Friedrich W. H. Kossebau wrote

Review Request: Improve the layout of KoPageLayoutWidget and KWDocumentColumns, also add margins to print option pages

2012-03-22 Thread Friedrich W. H. Kossebau
/KWDocumentColumns.ui 56e58ca words/part/dialogs/KWStartupWidget.cpp a0a43ac Diff: http://git.reviewboard.kde.org/r/104370/diff/ Testing --- Used all the UIs touched and resized them a few times. Thanks, Friedrich W. H. Kossebau ___ calligra

Re: Review Request: Improve the layout of KoPageLayoutWidget and KWDocumentColumns, also add margins to print option pages

2012-03-22 Thread Friedrich W. H. Kossebau
a0a43ac Diff: http://git.reviewboard.kde.org/r/104370/diff/ Testing --- Used all the UIs touched and resized them a few times. Thanks, Friedrich W. H. Kossebau ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman

Re: Disabling Marble map shape for 2.4?

2012-03-18 Thread Friedrich W. H. Kossebau
Am Samstag, 17. März 2012, 23:20:38 schrieb Jaroslaw Staniek: Ok for disabling shapes but I'd like to keep marble for kexi reports and forms. Sure, only tested the Marble shape, so will not touch anything else (as visible in the patch). Cyrille, do you as release coordinator(?) give the final

Review Request: Recreate the XFig import filter

2012-03-17 Thread Friedrich W. H. Kossebau
/karbon/xfig/xfigimport_factory.cc 2a6b691 Diff: http://git.reviewboard.kde.org/r/104312/diff/ Testing --- Loaded successfully a lot of xfig 3.2 files, including the XFig examples in /usr/share/doc/packages/xfig/TheExamples/ Thanks, Friedrich W. H. Kossebau

Disabling Marble map shape for 2.4?

2012-03-17 Thread Friedrich W. H. Kossebau
Hi, can anybody seriously use the Marble/Map shape (both 2.4 and master)? I tried to use it, e.g. to create an invitation with the map to show how to reach the meeting point. But I find the shape not yet ready for prime time: * no (obvious?) way to remove the info boxes (compass, scalebar, ...)

z-index absolute or relative to containing group?

2012-03-16 Thread Friedrich W. H. Kossebau
Hi, see $subject, is the z-index of items absolute or relative to the containing group? I could not find anything relevant on the webs. Has this been discussed before? If not, were could this be discussed? All I found in the OpenDocument 1.2 spec is this, but it does not talk about this

Re: Project Proposal for Calligra

2012-03-15 Thread Friedrich W. H. Kossebau
Hi Jigar, Am Mittwoch, 14. März 2012, 17:23:16 schrieb jigar raisinghani: Hi Here is a project proposal which i would like to implement in Calligra Tables and Calligra Words. http://dl.dropbox.com/u/49042576/Project%20Proposal_JIGAR.pdf Instead of opening a different window

Kexi reports based on shapes, form letters, diagrams using data sources (was: Re: Review Request: New shape for 1-D and 2-D barcodes)

2012-03-15 Thread Friedrich W. H. Kossebau
Am Montag, 12. März 2012, 08:40:13 schrieb Adam Pigg: Kexi could do with an implementation of barcodes based on this, becuase the current version is hand-built, not using any library, and while it is assumed to work, its certainly not backed up with anything fully tested. Hm, I still am

calligra.org/tables needs to be changed to calligra.org/sheets

2012-03-14 Thread Friedrich W. H. Kossebau
Hi, now that Calligra Tables officially got renamed to Calligra Sheets, this needs to be reflected in the calligra.org website as well, ideally best before the next RC, because this is when a lot of people will visit those pages, and they better are consistent with what is actually released

Disabling 3rd-party tracking of visitors of calligra.org by-default

2012-03-14 Thread Friedrich W. H. Kossebau
Hi, currently calligra.org enables some social service company to track who is visiting this website. Under german law this is disallowed, at least as some people read the law IIRC. Could this be fixed to e.g. change the code to have people first activate the embedding by a first click? E.g.

Re: Review Request: Make parameter for KoShapeSavingContext::imageHref(...) const

2012-03-12 Thread Friedrich W. H. Kossebau
On March 12, 2012, 4:18 a.m., Commit Hook wrote: This review has been submitted with commit cc1069d8d8f6f782acb50d596528b5beab425793 by Friedrich W. H. Kossebau to branch master. Okay to backport also to 2.4? And how is ABI versioning handled, BTW, as this is BIC? - Friedrich W. H

Re: Review Request: Fix crash in Picture shape if no picture is set yet

2012-03-12 Thread Friedrich W. H. Kossebau
On March 12, 2012, 6:29 a.m., Commit Hook wrote: This review has been submitted with commit 83213ec798c49d06246cf43765f89a1f3a214a15 by Friedrich W. H. Kossebau to branch master. Okay to backport to 2.4? Or needs a separate review? - Friedrich W. H

Re: Review Request: New shape for 1-D and 2-D barcodes

2012-03-12 Thread Friedrich W. H. Kossebau
Hi Adam, Am Montag, 12. März 2012, 08:40:13 schrieb Adam Pigg: Kexi could do with an implementation of barcodes based on this, becuase the current version is hand-built, not using any library, and while it is assumed to work, its certainly not backed up with anything fully tested. Ah, had not

Re: Review Request: New shape for 1-D and 2-D barcodes

2012-03-12 Thread Friedrich W. H. Kossebau
, visit: http://git.reviewboard.kde.org/r/104235/#review11304 --- On March 12, 2012, 1:57 a.m., Friedrich W. H. Kossebau wrote: --- This is an automatically generated e-mail. To reply

Re: Review Request: New shape for 1-D and 2-D barcodes

2012-03-12 Thread Friedrich W. H. Kossebau
and deleted barcode shapes. Saved files with barcode shapes and loaded them again. Thanks, Friedrich W. H. Kossebau ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request: New shape for 1-D and 2-D barcodes

2012-03-12 Thread Friedrich W. H. Kossebau
, Friedrich W. H. Kossebau ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

[SOLVED] Re: How to... get foreground and background color in a shape?

2012-03-12 Thread Friedrich W. H. Kossebau
Am Montag, 12. März 2012, 17:17:29 schrieb Thorsten Zachmann: On Monday, March 12, 2012 16:20:03 Friedrich W. H. Kossebau wrote: Hi, hopefully soon a new version of the prison library is released, which will enable me to easily control the foreground and background colors

Re: Review Request: New shape for 1-D and 2-D barcodes

2012-03-12 Thread Friedrich W. H. Kossebau
/104235/diff/ Testing --- Created, edited and deleted barcode shapes. Saved files with barcode shapes and loaded them again. Thanks, Friedrich W. H. Kossebau ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman

Review Request: Make parameter for KoShapeSavingContext::imageHref(...) const

2012-03-11 Thread Friedrich W. H. Kossebau
/flake/KoShapeSavingContext.h f7d328c libs/flake/KoShapeSavingContext.cpp 07d4e16 Diff: http://git.reviewboard.kde.org/r/104234/diff/ Testing --- Thanks, Friedrich W. H. Kossebau ___ calligra-devel mailing list calligra-devel@kde.org https

Review Request: New shape for 1-D and 2-D barcodes

2012-03-11 Thread Friedrich W. H. Kossebau
/barcodeshapeplugin.h PRE-CREATION plugins/barcodeshape/barcodeshapeplugin.cpp PRE-CREATION Diff: http://git.reviewboard.kde.org/r/104235/diff/ Testing --- Created, edited and deleted barcode shapes. Saved files with barcode shapes and loaded them again. Thanks, Friedrich W. H. Kossebau

Re: Review Request: Fix crash in Picture shape if no picture is set yet

2012-03-11 Thread Friedrich W. H. Kossebau
in PictureShape::saveStyle(...) on imageData()-imageSize() due to imageData() returning 0. Diffs - plugins/pictureshape/PictureShape.cpp 1148641 Diff: http://git.reviewboard.kde.org/r/104237/diff/ Testing --- Thanks, Friedrich W. H. Kossebau

Re: Chaining textboxes, enhancing OpenDocument formats...

2012-03-05 Thread Friedrich W. H. Kossebau
Am Montag, 5. März 2012, 04:58:57 schrieb Thorsten Zachmann: Hello Friedrich, is there really no support for chaining textboxes in OpenDocument, so text content is flowing between those boxes, as needed? Please tell me there is. there is 19.118 draw:chain-next-name Ah, verrry good,

Chaining textboxes, enhancing OpenDocument formats...

2012-03-04 Thread Friedrich W. H. Kossebau
Hi, is there really no support for chaining textboxes in OpenDocument, so text content is flowing between those boxes, as needed? Please tell me there is. If not, where are actual discussions of the OpenDocument formats enhancement happening, so I could propose/discuss this feature I am used

Review Request: s/Karbon14/Karbon/g for all untranslated strings

2012-02-29 Thread Friedrich W. H. Kossebau
/SvgOutputDev.cpp f0e1035 filters/karbon/xaml/xamlexport.cc 326645b karbon/CHANGES 80a8a8b karbon/README f162ffc Diff: http://git.reviewboard.kde.org/r/104122/diff/ Testing --- Thanks, Friedrich W. H. Kossebau ___ calligra-devel mailing

Review Request: Saving and reloading a file with an Artistic Text object results in spaces added to the text content each time

2012-02-28 Thread Friedrich W. H. Kossebau
changed, e.g. color, to get more tspans in the stored SVG, then loaded and saved the file a few times. No longer any spaces are added to the text. Thanks, Friedrich W. H. Kossebau ___ calligra-devel mailing list calligra-devel@kde.org https

overflow-behavior with text boxes: clip does not clip?

2012-02-25 Thread Friedrich W. H. Kossebau
Hi, I expected style:overflow-behavior set to clip with no minimum size set to result in text which does not fit in a draw:text-box to be clipped, i.e. not shown. But instead text is also rendered outside of the text box (see attached screenshot). Is that a bug or a feature? From the spec:

Re: How to easily validate an OpenDocument file (or: where is oasisfilecheck?)

2012-02-23 Thread Friedrich W. H. Kossebau
Am Mittwoch, 22. Februar 2012, 22:50:34 schrieb Jos van den Oever: On Wednesday 22 February 2012 20:57:17 PM Friedrich W. H. Kossebau wrote: Hi, I would like to validate the odg files I create with my CDRv4 import filter. Searching for a validator I found http

Karbon or Karbon14?

2012-02-23 Thread Friedrich W. H. Kossebau
Hi, IIRC the official name of Karbon14 is now (Calligra) Karbon. But in the sources (including the .desktop files) the name is still Karbon14. Something inside me wants to fix this :) Okay if I provide a patch to change the name from Karbon14 to Karbon in all places left? Cheers Friedrich

How to easily validate an OpenDocument file (or: where is oasisfilecheck?)

2012-02-22 Thread Friedrich W. H. Kossebau
Hi, I would like to validate the odg files I create with my CDRv4 import filter. Searching for a validator I found http://community.kde.org/Calligra/KOffice_and_ODF#Validation which references oasisfilecheck and oasislint. But the link given is out- dated

Rebasing of work branches allowed?

2012-02-15 Thread Friedrich W. H. Kossebau
Hi, in other projects I have got used to the habit that, when updating a work branch to the lastest changes in the master branch, to rather rebase the work branch to the master branch instead of merging the commits from it, to keep a clean history in the branch itself, which I have found

Re: Rebasing of work branches allowed?

2012-02-15 Thread Friedrich W. H. Kossebau
Am Mittwoch, 15. Februar 2012, 16:30:31 schrieb Jaroslaw Staniek: On 15 February 2012 10:04, Friedrich W. H. Kossebau kosse...@kde.org wrote: Hi, in other projects I have got used to the habit that, when updating a work branch to the lastest changes in the master branch, to rather

How to report typos in the OpenDocument spec?

2012-02-15 Thread Friedrich W. H. Kossebau
Dear OpenDocument spec experts among you, the latest OpenDocument spec* has application.vnd.oasis.opendocument.graphics instead of application/vnd.oasis.opendocument.graphics all over the place. How can this typo ideally be reported? *

Can bool KoStore::open(const QString _name) take a path?

2012-02-14 Thread Friedrich W. H. Kossebau
Hi, reading through OD* writing filters I see two variants to open a file at a specifc path for writing. Do both result in the same? Filterkpr2odf::convert(...) has: //Save the preview picture output-enterDirectory(Thumbnails); output-open(thumbnail.png); ...

Re: CDR import - map to what format?

2012-02-13 Thread Friedrich W. H. Kossebau
Hi Sven, Am Freitag, 10. Februar 2012, 15:23:37 schrieb Sven Langkamp: On Fri, Feb 10, 2012 at 1:19 PM, Friedrich W. H. Kossebau kosse...@kde.orgwrote: Hi, so I have been progressing a little bit with the CDR import filter, I know more and more about the format. Still not enough

Re: CDR import - map to what format?

2012-02-13 Thread Friedrich W. H. Kossebau
Am Freitag, 10. Februar 2012, 15:51:34 schrieb Sven Langkamp: On Fri, Feb 10, 2012 at 1:19 PM, Friedrich W. H. Kossebau kosse...@kde.orgwrote: So what do I do about that? For the rectangles I would have guessed I could try to write a custom shape which supports all those properties. Odg

Re: CDR import - map to what format?

2012-02-13 Thread Friedrich W. H. Kossebau
Hi Thorsten, Am Samstag, 11. Februar 2012, 05:02:29 schrieb Thorsten Zachmann: On Friday, February 10, 2012 13:19:16 Friedrich W. H. Kossebau wrote: Hi, so I have been progressing a little bit with the CDR import filter, I know more and more about the format. Still not enough to render

Re: Initial work on a Karbon CDR import filter

2012-02-10 Thread Friedrich W. H. Kossebau
Hi Sven, Am Sonntag, 29. Januar 2012, 02:00:59 schrieb Sven Langkamp: On Sat, Jan 28, 2012 at 3:24 AM, Friedrich W. H. Kossebau kosse...@kde.orgwrote: Hi, last weekend I started to try if I can do an import filter for the CorelDraw file format. I managed to get first parts

CDR import - map to what format?

2012-02-10 Thread Friedrich W. H. Kossebau
Hi, so I have been progressing a little bit with the CDR import filter, I know more and more about the format. Still not enough to render the first things in their place, but e.g. I can now access all raw text, both from graphic text objects as block text objects. I also turned to stream some

Re: Initial work on a Karbon CDR import filter

2012-01-28 Thread Friedrich W. H. Kossebau
Hi Thorsten, Am Samstag, 28. Januar 2012, 05:03:23 schrieb Thorsten Zachmann: Some questions: Initially I tried to create directly a KarbonDocument object, not another SVG file. But then I found out that shapes like e.g. Rectangle and Ellipsis are only provided by factories from

Re: Initial work on a Karbon CDR import filter

2012-01-28 Thread Friedrich W. H. Kossebau
Hi Boudewijn, Am Samstag, 28. Januar 2012, 11:04:54 schrieb Boudewijn Rempt: On Saturday 28 January 2012 Jan, Friedrich W. H. Kossebau wrote: Hi, last weekend I started to try if I can do an import filter for the CorelDraw file format. I managed to get first parts of that format

Add concept of working memory formats to filters (was: Re: Initial work on a Karbon CDR import filter)

2012-01-28 Thread Friedrich W. H. Kossebau
Am Samstag, 28. Januar 2012, 11:04:54 schrieb Boudewijn Rempt: Some questions: Initially I tried to create directly a KarbonDocument object, not another SVG file. But then I found out that shapes like e.g. Rectangle and Ellipsis are only provided by factories from plugins, so I cannot

Re: Initial work on a Karbon CDR import filter

2012-01-28 Thread Friedrich W. H. Kossebau
Am Samstag, 28. Januar 2012, 17:14:06 schrieb Thorsten Zachmann: On Saturday, January 28, 2012 16:24:16 Friedrich W. H. Kossebau wrote: Hi Thorsten, Am Samstag, 28. Januar 2012, 05:03:23 schrieb Thorsten Zachmann: Some questions: Initially I tried to create directly

<    5   6   7   8   9   10